linux-stable.git/fs/xfs, branch master

xfs: Fix typo in comment

2026-05-11T10:58:38+00:00

Fix spelling mistake in comment:
 - occured -> occurred

Reviewed-by: Darrick J. Wong 
Signed-off-by: Md Shofiqul Islam 
Signed-off-by: Carlos Maiolino

xfs: fix the "limiting open zones" message

2026-05-11T10:51:57+00:00

The xfs logging macros include a newline, remove the \n, which adds an
extra one.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Carlos Maiolino 
Reviewed-by: Andrey Albershteyn 
Signed-off-by: Carlos Maiolino

xfs: flush delalloc blocks on ENOSPC in xfs_trans_alloc_icreate

2026-04-27T09:31:15+00:00

xfs_trans_alloc_icreate() can fail with ENOSPC when delalloc
reservations have consumed most of the available block count
(fdblocks).  xfs_trans_alloc() already retries internally with
xfs_blockgc_flush_all(), but that only trims post-EOF speculative
preallocation and may not free enough space for the transaction
reservation.

Add a retry with xfs_flush_inodes() when xfs_trans_alloc() returns
ENOSPC.  This forces writeback of all dirty inodes via
sync_inodes_sb(), converting delalloc reservations to real
allocations and freeing the over-reserved portion back to fdblocks.

This fixes all callers of xfs_trans_alloc_icreate() and removes
the existing caller-level retry from xfs_create(), which is now
handled centrally.

Signed-off-by: Ravi Singh 
Reviewed-by: Carlos Maiolino 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Carlos Maiolino

xfs: check da node block pad field during scrub

2026-04-27T08:36:36+00:00

The da node block header (xfs_da3_node_hdr) contains a __pad32 field
that should always be zero. Add a check for this during directory and
attribute btree scrubbing.

Since old kernels may have written non-zero padding without issues, flag
this as an optimization opportunity (preen) rather than corruption.

Signed-off-by: Yuto Ohnuki 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Carlos Maiolino

xfs: fix memory leak for data allocated by xfs_zone_gc_data_alloc()

2026-04-27T08:36:36+00:00

In xfs_zone_gc_mount(), on error, a struct xfs_zone_gc_data allocated
with xfs_zone_gc_data_alloc() is freed with kfree(), however, this
doesn't free the underlying folios or the rmap_irecs.

Use xfs_zone_gc_data_free() to correctly free this memory.

Fixes: 080d01c41d44 ("xfs: implement zoned garbage collection")
Cc: stable@vger.kernel.org # v6.15
Signed-off-by: Wilfred Mallawa 
Reviewed-by: Darrick J. Wong 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Carlos Maiolino

xfs: fix memory leak on error in xfs_alloc_zone_info()

2026-04-27T08:36:36+00:00

Currently, the 0th index of the zi_used_bucket_bitmap array is not freed
on error due to the pre-decrement then evaluate semantic of the while
loop used in xfs_alloc_zone_info(). Fix it by allowing for the i == 0
case to be covered.

Fixes: 080d01c41d44 ("xfs: implement zoned garbage collection")
Cc: stable@vger.kernel.org # v6.15
Reviewed-by: Damien Le Moal 
Reviewed-by: Carlos Maiolino 
Signed-off-by: Wilfred Mallawa 
Reviewed-by: Hans Holmberg 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Carlos Maiolino

xfs: check directory data block header padding in scrub

2026-04-27T08:36:36+00:00

Add the missing scrub check for the pad field in directory data block
headers. Old kernels may have written non-zero padding without issue,
and the write path now self-heals stale padding on modification. Flag
non-zero padding as an optimization opportunity (preen) rather than
corruption.

Add xchk_fblock_set_preen helper for reporting file fork block issues
that could be optimized. The trace event xchk_fblock_preen already
exists.

Signed-off-by: Yuto Ohnuki 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Carlos Maiolino

xfs: zero directory data block padding on write verification

2026-04-27T08:36:36+00:00

Old kernels did not zero the pad field in xfs_dir3_data_hdr when
initializing directory data blocks, so existing filesystems may have
non-zero padding on disk.

Zero the pad field in xfs_dir3_data_write_verify alongside the existing
LSN and checksum updates. The pad field is pure alignment padding with
no runtime meaning, so zeroing it during write verification is safe and
has no additional I/O cost. This lets filesystems gradually self-heal
stale non-zero padding as directories are modified, without requiring an
explicit repair pass.

Suggested-by: Dave Chinner 
Signed-off-by: Yuto Ohnuki 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Carlos Maiolino

xfs: zero entire directory data block header region at init

2026-04-27T08:36:36+00:00

xfs_dir3_data_init currently zeroes only the xfs_dir3_blk_hdr portion of
the directory data block header, then manually initializes the bestfree
entries in a loop. This leaves the pad field in xfs_dir3_data_hdr
uninitialized and requires explicit zeroing of each bestfree slot.

Zero the entire header region (geo->data_entry_offset bytes)
unconditionally before setting individual fields. This covers all
current and future header fields, all padding (implicit and explicit),
and the bestfree array, so the manual zeroing loop for bestfree can be
removed.

Suggested-by: Dave Chinner 
Signed-off-by: Yuto Ohnuki 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Carlos Maiolino

xfs: remove the meaningless XFS_ALLOC_FLAG_FREEING

2026-04-27T08:36:36+00:00

In xfs_refcount_finish_one(), there's no need to pass
XFS_ALLOC_FLAG_FREEING to xfs_alloc_read_agf().

So remove it.

Signed-off-by: Jinliang Zheng 
Reviewed-by: Darrick J. Wong 
Signed-off-by: Carlos Maiolino