linux-stable.git/fs/xfs/xfs_vnodeops.c, branch linux-3.7.y

xfs: avoid the iolock in xfs_free_eofblocks for evicted inodes

2012-07-29T21:22:20+00:00

Same rational as the last patch - these inodes are not reachable, so
don't bother with locking.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Rich Johnston 
Signed-off-by: Ben Myers

xfs: do not take the iolock in xfs_inactive

2012-07-29T21:16:49+00:00

An inode that enters xfs_inactive has been removed from all global
lists but the inode hash, and can't be recycled in xfs_iget before
it has been marked reclaimable.  Thus taking the iolock in here
is not nessecary at all, and given the amount of lockdep false
positives it has triggered already I'd rather remove the locking.

The only change outside of xfs_inactive is relaxing an assert in
xfs_itruncate_extents.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Rich Johnston 
Signed-off-by: Ben Myers

xfs: remove xfs_inactive_attrs

2012-07-29T21:15:33+00:00

Remove this helper as the code flow is a lot more obvious when it gets
merged into its only caller.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Rich Johnston 
Signed-off-by: Ben Myers

xfs: clean up xfs_inactive

2012-07-29T21:13:09+00:00

The code to reserve log space and join the inode to the transaction is
common for all cases, so don't duplicate it.  Also remove the trivial
xfs_inactive_symlink_local helper which can simply be opencode now.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Rich Johnston 
Signed-off-by: Ben Myers

xfs: make largest supported offset less shouty

2012-06-14T17:28:24+00:00

XFS_MAXIOFFSET() is just a simple macro that resolves to
mp->m_maxioffset. It doesn't need to exist, and it just makes the
code unnecessarily loud and shouty.

Make it quiet and easy to read.

Signed-off-by: Dave Chinner 
Reviewed-by: Eric Sandeen 
Signed-off-by: Ben Myers

xfs: fix delalloc quota accounting on failure

2012-05-21T15:45:43+00:00

xfstest 270 was causing quota reservations way beyond what was sane
(ten to hundreds of TB) for a 4GB filesystem. There's a sign problem
in the error handling path of xfs_bmapi_reserve_delalloc() because
xfs_trans_unreserve_quota_nblks() simple negates the value passed -
which doesn't work for an unsigned variable. This causes
reservations of close to 2^32 block instead of removing a
reservation of a handful of blocks.

Fix the same problem in the other xfs_trans_unreserve_quota_nblks()
callers where unsigned integer variables are used, too.

Signed-off-by: Dave Chinner 
Reviewed-by: Eric Sandeen 
Signed-off-by: Ben Myers

xfs: make XBF_MAPPED the default behaviour

2012-05-14T21:21:03+00:00

Rather than specifying XBF_MAPPED for almost all buffers, introduce
XBF_UNMAPPED for the couple of users that use unmapped buffers.

Signed-off-by: Dave Chinner 
Reviewed-by: Mark Tinguely 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Ben Myers

xfs: move xfs_get_extsz_hint() and kill xfs_rw.h

2012-05-14T21:20:58+00:00

The only thing left in xfs_rw.h is a function prototype for an inode
function.  Move that to xfs_inode.h, and kill xfs_rw.h.

Also move the function implementing the prototype from xfs_rw.c to
xfs_inode.c so we only have one function left in xfs_rw.c

Signed-off-by: Dave Chinner 
Reviewed-by: Mark Tinguely 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Ben Myers

xfs: move xfsagino_t to xfs_types.h

2012-05-14T21:20:54+00:00

Untangle the header file includes a bit by moving the definition of
xfs_agino_t to xfs_types.h. This removes the dependency that xfs_ag.h has on
xfs_inum.h, meaning we don't need to include xfs_inum.h everywhere we include
xfs_ag.h.

Signed-off-by: Dave Chinner 
Reviewed-by: Mark Tinguely 
Signed-off-by: Ben Myers

xfs: use iolock on XFS_IOC_ALLOCSP calls

2012-05-14T21:20:53+00:00

fsstress has a particular effective way of stopping debug XFS
kernels. We keep seeing assert failures due finding delayed
allocation extents where there should be none. This shows up when
extracting extent maps and we are holding all the locks we should be
to prevent races, so this really makes no sense to see these errors.

After checking that fsstress does not use mmap, it occurred to me
that fsstress uses something that no sane application uses - the
XFS_IOC_ALLOCSP ioctl interfaces for preallocation. These interfaces
do allocation of blocks beyond EOF without using preallocation, and
then call setattr to extend and zero the allocated blocks.

THe problem here is this is a buffered write, and hence the
allocation is a delayed allocation. Unlike the buffered IO path, the
allocation and zeroing are not serialised using the IOLOCK. Hence
the ALLOCSP operation can race with operations holding the iolock to
prevent buffered IO operations from occurring.

Signed-off-by: Dave Chinner 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Mark Tinguely 
Signed-off-by: Ben Myers