linux-stable.git/fs/xfs/xfs_rtalloc.c, branch linux-3.7.y

xfs: fix uninitialised variable in xfs_rtbuf_get()

2012-08-23T19:48:16+00:00

Results in this assert failure in generic/090:

XFS: Assertion failed: *nmap >= 1, file: fs/xfs/xfs_bmap.c, line: 4363
.....
Call Trace:
 [] xfs_bmapi_read+0x6b/0x370
 [] xfs_rtbuf_get+0x42/0x130
 [] xfs_rtget_summary+0x89/0x120
 [] xfs_rtallocate_extent_size+0xce/0x340
 [] xfs_rtallocate_extent+0x240/0x290
 [] xfs_bmap_rtalloc+0x1ba/0x340
 [] xfs_bmap_alloc+0x35/0x40
 [] xfs_bmapi_allocate+0xf1/0x350
 [] xfs_bmapi_write+0x66e/0xa60
 [] xfs_iomap_write_direct+0x22a/0x3f0
 [] __xfs_get_blocks+0x38b/0x5d0
 [] xfs_get_blocks_direct+0x14/0x20
 [] do_blockdev_direct_IO+0xf71/0x1eb0
 [] __blockdev_direct_IO+0x55/0x60
 [] xfs_vm_direct_IO+0x11a/0x1e0
 [] generic_file_direct_write+0xd7/0x1b0
 [] xfs_file_dio_aio_write+0x13c/0x320
 [] xfs_file_aio_write+0x1c2/0x1d0
 [] do_sync_write+0xa7/0xe0
 [] vfs_write+0xa8/0x160
 [] sys_pwrite64+0x92/0xb0
 [] system_call_fastpath+0x16/0x1b

Signed-off-by: Dave Chinner 
Signed-off-by: Ben Myers

xfs: move xfs_get_extsz_hint() and kill xfs_rw.h

2012-05-14T21:20:58+00:00

The only thing left in xfs_rw.h is a function prototype for an inode
function.  Move that to xfs_inode.h, and kill xfs_rw.h.

Also move the function implementing the prototype from xfs_rw.c to
xfs_inode.c so we only have one function left in xfs_rw.c

Signed-off-by: Dave Chinner 
Reviewed-by: Mark Tinguely 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Ben Myers

xfs: move xfsagino_t to xfs_types.h

2012-05-14T21:20:54+00:00

Untangle the header file includes a bit by moving the definition of
xfs_agino_t to xfs_types.h. This removes the dependency that xfs_ag.h has on
xfs_inum.h, meaning we don't need to include xfs_inum.h everywhere we include
xfs_ag.h.

Signed-off-by: Dave Chinner 
Reviewed-by: Mark Tinguely 
Signed-off-by: Ben Myers

xfs: clean up buffer get/read call API

2012-05-14T21:20:45+00:00

The xfs_buf_get/read API is not consistent in the units it uses, and
does not use appropriate or consistent units/types for the
variables.

Convert the API to use disk addresses and block counts for all
buffer get and read calls. Use consistent naming for all the
functions and their declarations, and convert the internal functions
to use disk addresses and block counts to avoid need to convert them
from one type to another and back again.

Fix all the callers to use disk addresses and block counts. In many
cases, this removes an additional conversion from the function call
as the callers already have a block count.

Signed-off-by: Dave Chinner 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Mark Tinguely 
Signed-off-by: Ben Myers

xfs: fix deadlock in xfs_rtfree_extent

2012-03-22T20:31:06+00:00

To fix the deadlock caused by repeatedly calling xfs_rtfree_extent

 - removed xfs_ilock() and xfs_trans_ijoin() from xfs_rtfree_extent(),
   instead added asserts that the inode is locked and has an inode_item
   attached to it.
 - in xfs_bunmapi() when dealing with an inode with the rt flag
   call xfs_ilock() and xfs_trans_ijoin() so that the
   reference count is bumped on the inode and attached it to the
   transaction before calling into xfs_bmap_del_extent, similar to
   what we do in xfs_bmap_rtalloc.

Signed-off-by: Kamal Dasu 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Ben Myers

xfs: simplify xfs_trans_ijoin* again

2011-10-12T02:15:08+00:00

There is no reason to keep a reference to the inode even if we unlock
it during transaction commit because we never drop a reference between
the ijoin and commit.  Also use this fact to merge xfs_trans_ijoin_ref
back into xfs_trans_ijoin - the third argument decides if an unlock
is needed now.

I'm actually starting to wonder if allowing inodes to be unlocked
at transaction commit really is worth the effort.  The only real
benefit is that they can be unlocked earlier when commiting a
synchronous transactions, but that could be solved by doing the
log force manually after the unlock, too.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Alex Elder

xfs: rename xfs_bmapi to xfs_bmapi_write

2011-10-12T02:15:04+00:00

Now that all the read-only users of xfs_bmapi have been converted to
use xfs_bmapi_read(), we can remove all the read-only handling cases
from xfs_bmapi().

Once this is done, rename xfs_bmapi to xfs_bmapi_write to reflect
the fact it is for allocation only. This enables us to kill the
XFS_BMAPI_WRITE flag as well.

Also clean up xfs_bmapi_write to the style used in the newly added
xfs_bmapi_read/delay functions.

Signed-off-by: Dave Chinner 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Alex Elder

xfs: remove xfs_bmapi_single()

2011-10-12T02:15:03+00:00

Now we have xfs_bmapi_read, there is no need for xfs_bmapi_single().
Change the remaining caller over and kill the function.

Signed-off-by: Dave Chinner 
Signed-off-by: Christoph Hellwig 
Signed-off-by: Alex Elder

xfs: Remove the macro XFS_BUF_PTR

2011-07-25T20:03:13+00:00

Remove the definition and usages of the macro XFS_BUF_PTR.

Signed-off-by: Chandra Seetharaman 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Alex Elder

xfs: Remove the macro XFS_BUF_ERROR and family

2011-07-25T19:57:46+00:00

Remove the definitions and usage of the macros XFS_BUF_ERROR,
XFS_BUF_GETERROR and XFS_BUF_ISERROR.

Signed-off-by: Chandra Seetharaman 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Alex Elder