linux-stable.git/fs/ufs, branch linux-4.9.y

fs/ufs: avoid potential u32 multiplication overflow

2020-08-21T09:02:11+00:00

[ Upstream commit 88b2e9b06381551b707d980627ad0591191f7a2d ]

The 64 bit ino is being compared to the product of two u32 values,
however, the multiplication is being performed using a 32 bit multiply so
there is a potential of an overflow.  To be fully safe, cast uspi->s_ncg
to a u64 to ensure a 64 bit multiplication occurs to avoid any chance of
overflow.

Fixes: f3e2a520f5fb ("ufs: NFS support")
Signed-off-by: Colin Ian King 
Signed-off-by: Andrew Morton 
Cc: Evgeniy Dushistov 
Cc: Alexey Dobriyan 
Link: http://lkml.kernel.org/r/20200715170355.1081713-1-colin.king@canonical.com
Addresses-Coverity: ("Unintentional integer overflow")
Signed-off-by: Linus Torvalds 
Signed-off-by: Sasha Levin

ufs: fix braino in ufs_get_inode_gid() for solaris UFS flavour

2019-05-25T16:26:56+00:00

[ Upstream commit 4e9036042fedaffcd868d7f7aa948756c48c637d ]

To choose whether to pick the GID from the old (16bit) or new (32bit)
field, we should check if the old gid field is set to 0xffff.  Mainline
checks the old *UID* field instead - cut'n'paste from the corresponding
code in ufs_get_inode_uid().

Fixes: 252e211e90ce
Signed-off-by: Al Viro 
Signed-off-by: Sasha Levin

ufs: we need to sync inode before freeing it

2018-11-10T15:42:49+00:00

[ Upstream commit 67a70017fa0a152657bc7e337e69bb9c9f5549bf ]

Signed-off-by: Al Viro 
Signed-off-by: Sasha Levin

do d_instantiate/unlock_new_inode combinations safely

2018-05-30T05:50:16+00:00

commit 1e2e547a93a00ebc21582c06ca3c6cfea2a309ee upstream.

For anything NFS-exported we do _not_ want to unlock new inode
before it has grown an alias; original set of fixes got the
ordering right, but missed the nasty complication in case of
lockdep being enabled - unlock_new_inode() does
	lockdep_annotate_inode_mutex_key(inode)
which can only be done before anyone gets a chance to touch
->i_mutex.  Unfortunately, flipping the order and doing
unlock_new_inode() before d_instantiate() opens a window when
mkdir can race with open-by-fhandle on a guessed fhandle, leading
to multiple aliases for a directory inode and all the breakage
that follows from that.

	Correct solution: a new primitive (d_instantiate_new())
combining these two in the right order - lockdep annotate, then
d_instantiate(), then the rest of unlock_new_inode().  All
combinations of d_instantiate() with unlock_new_inode() should
be converted to that.

Cc: stable@kernel.org	# 2.6.29 and later
Tested-by: Mike Marshall 
Reviewed-by: Andreas Dilger 
Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

ufs_getfrag_block(): we only grab ->truncate_mutex on block creation path

2017-06-14T13:06:01+00:00

commit 006351ac8ead0d4a67dd3845e3ceffe650a23212 upstream.

Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

ufs_extend_tail(): fix the braino in calling conventions of ufs_new_fragments()

2017-06-14T13:06:01+00:00

commit 940ef1a0ed939c2ca029fca715e25e7778ce1e34 upstream.

... and it really needs splitting into "new" and "extend" cases, but that's for
later

Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

ufs: set correct ->s_maxsize

2017-06-14T13:06:01+00:00

commit 6b0d144fa758869bdd652c50aa41aaf601232550 upstream.

Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

ufs: restore maintaining ->i_blocks

2017-06-14T13:06:01+00:00

commit eb315d2ae614493fd1ebb026c75a80573d84f7ad upstream.

Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

fix ufs_isblockset()

2017-06-14T13:06:01+00:00

commit 414cf7186dbec29bd946c138d6b5c09da5955a08 upstream.

Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

ufs: restore proper tail allocation

2017-06-14T13:06:01+00:00

commit 8785d84d002c2ce0f68fbcd6c2c86be859802c7e upstream.

Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman