linux-stable.git/fs/ufs, branch linux-4.0.y

fs/ufs: restore s_lock mutex_init()

2015-07-10T16:45:44+00:00

commit e4f95517f18271b1da36cfc5d700e46844396d6e upstream.

Add last missing line in commit "cdd9eefdf905"
("fs/ufs: restore s_lock mutex")

Signed-off-by: Fabian Frederick 
Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

ufs: Fix possible deadlock when looking up directories

2015-07-10T16:45:43+00:00

commit 514d748f69c97a51a2645eb198ac5c6218f22ff9 upstream.

Commit e4502c63f56aeca88 (ufs: deal with nfsd/iget races) made ufs
create inodes with I_NEW flag set. However ufs_mkdir() never cleared
this flag. Thus if someone ever tried to lookup the directory by inode
number, he would deadlock waiting for I_NEW to be cleared. Luckily this
mostly happens only if the filesystem is exported over NFS since
otherwise we have the inode attached to dentry and don't look it up by
inode number. In rare cases dentry can get freed without inode being
freed and then we'd hit the deadlock even without NFS export.

Fix the problem by clearing I_NEW before instantiating new directory
inode.

Fixes: e4502c63f56aeca887ced37f24e0def1ef11cec8
Reported-by: Fabian Frederick 
Signed-off-by: Jan Kara 
Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

ufs: Fix warning from unlock_new_inode()

2015-07-10T16:45:43+00:00

commit 12ecbb4b1d765a5076920999298d9625439dbe58 upstream.

Commit e4502c63f56aeca88 (ufs: deal with nfsd/iget races) introduced
unlock_new_inode() call into ufs_add_nondir(). However that function
gets called also from ufs_link() which hands it already initialized
inode and thus unlock_new_inode() complains. The problem is harmless but
annoying.

Fix the problem by opencoding necessary stuff in ufs_link()

Fixes: e4502c63f56aeca887ced37f24e0def1ef11cec8
Signed-off-by: Jan Kara 
Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

fs/ufs: restore s_lock mutex

2015-07-10T16:45:43+00:00

commit cdd9eefdf905e92e7fc6cc393314efe68dc6ff66 upstream.

Commit 0244756edc4b98c ("ufs: sb mutex merge + mutex_destroy") generated
deadlocks in read/write mode on mkdir.

This patch partially reverts it keeping fixes by Andrew Morton and
mutex_destroy()

[AV: fixed a missing bit in ufs_remount()]

Signed-off-by: Fabian Frederick 
Reported-by: Ian Campbell 
Suggested-by: Jan Kara 
Cc: Ian Campbell 
Cc: Evgeniy Dushistov 
Cc: Alexey Khoroshilov 
Cc: Roger Pau Monne 
Cc: Ian Jackson 
Cc: Al Viro 
Signed-off-by: Andrew Morton 
Signed-off-by: Al Viro 
Signed-off-by: Greg Kroah-Hartman

fs/ufs: revert "ufs: fix deadlocks introduced by sb mutex merge"

2015-07-10T16:45:42+00:00

commit 13b987ea275840d74d9df9a44326632fab1894da upstream.

This reverts commit 9ef7db7f38d0 ("ufs: fix deadlocks introduced by sb
mutex merge") That patch tried to solve commit 0244756edc4b98c ("ufs: sb
mutex merge + mutex_destroy") which is itself partially reverted due to
multiple deadlocks.

Signed-off-by: Fabian Frederick 
Suggested-by: Jan Kara 
Cc: Ian Campbell 
Cc: Evgeniy Dushistov 
Cc: Alexey Khoroshilov 
Cc: Roger Pau Monne 
Cc: Ian Jackson 
Cc: Al Viro 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

fs/ufs/super.c: fix potential race condition

2015-02-17T22:34:51+00:00

Let locking subsystem decide on mutex management.  As reported by Andrew
Morton this patch fixes a bug:

: lock_ufs() is assuming that on non-preempt uniprocessor, the calling
: code will run atomically up to the matching unlock_ufs().
:
: But that isn't true. The very first site I looked at (ufs_frag_map)
: does sb_bread() under lock_ufs().  And sb_bread() will call schedule(),
: very commonly.
:
: The ->mutex_owner stuff is a bit hacky but should work OK.

Signed-off-by: Fabian Frederick 
Cc: Evgeniy Dushistov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/ufs/super.c: remove unnecessary casting

2015-02-17T22:34:51+00:00

Fix the following coccinelle warning:

  fs/ufs/super.c:1418:7-28: WARNING: casting value returned by memory allocation function to (struct ufs_inode_info *) is useless.

Signed-off-by: Fabian Frederick 
Cc: Evgeniy Dushistov 
Cc: Joe Perches 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/ufs/balloc.c: remove unused variable

2014-10-14T00:18:20+00:00

ucg is defined and set in ufs_bitmap_search but never used.

Signed-off-by: Fabian Frederick 
Cc: Evgeniy Dushistov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ufs: deal with nfsd/iget races

2014-09-27T01:17:52+00:00

Signed-off-by: Al Viro

ufs: fix deadlocks introduced by sb mutex merge

2014-09-07T17:26:39+00:00

Commit 0244756edc4b ("ufs: sb mutex merge + mutex_destroy") introduces
deadlocks in ufs_new_inode() and ufs_free_inode().
Most callers of that functions acqure the mutex by themselves and
ufs_{new,free}_inode() do that via lock_ufs(),
i.e we have an unavoidable double lock.

The patch proposes to resolve the issue by making sure that
ufs_{new,free}_inode() are not called with the mutex held.

Found by Linux Driver Verification project (linuxtesting.org).

Cc: stable@vger.kernel.org # 3.16
Signed-off-by: Alexey Khoroshilov 
Signed-off-by: Al Viro