linux-stable.git/fs/udf, branch v3.19

udf: Release preallocation on last writeable close

2015-01-28T08:00:40+00:00

Commit 6fb1ca92a640 "udf: Fix race between write(2) and close(2)"
changed the condition when preallocation is released. The idea was that
we don't want to release the preallocation for an inode on close when
there are other writeable file descriptors for the inode. However the
condition was written in the opposite way so we released preallocation
only if there were other writeable file descriptors. Fix the problem by
changing the condition properly.

CC: stable@vger.kernel.org
Fixes: 6fb1ca92a6409a9d5b0696447cd4997bc9aaf5a2
Reported-by: Fabian Frederick 
Signed-off-by: Jan Kara

udf: Reduce repeated dereferences

2014-12-21T21:42:37+00:00

Replace repeated dereferences like dir->i_sb by storing superblock
pointer in a variable and using that.

Signed-off-by: Jan Kara

udf: Check component length before reading it

2014-12-21T21:42:19+00:00

Check that length specified in a component of a symlink fits in the
input buffer we are reading. Also properly ignore component length for
component types that do not use it. Otherwise we read memory after end
of buffer for corrupted udf image.

Reported-by: Carl Henrik Lunde 
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara

udf: Check path length when reading symlink

2014-12-19T13:12:08+00:00

Symlink reading code does not check whether the resulting path fits into
the page provided by the generic code. This isn't as easy as just
checking the symlink size because of various encoding conversions we
perform on path. So we have to check whether there is still enough space
in the buffer on the fly.

CC: stable@vger.kernel.org
Reported-by: Carl Henrik Lunde 
Signed-off-by: Jan Kara

udf: Verify symlink size before loading it

2014-12-19T12:17:10+00:00

UDF specification allows arbitrarily large symlinks. However we support
only symlinks at most one block large. Check the length of the symlink
so that we don't access memory beyond end of the symlink block.

CC: stable@vger.kernel.org
Reported-by: Carl Henrik Lunde 
Signed-off-by: Jan Kara

udf: Verify i_size when loading inode

2014-12-19T12:13:05+00:00

Verify that inode size is sane when loading inode with data stored in
ICB. Otherwise we may get confused later when working with the inode and
inode size is too big.

CC: stable@vger.kernel.org
Reported-by: Carl Henrik Lunde 
Signed-off-by: Jan Kara

udf: One function call less in udf_fill_super() after error detection

2014-11-19T20:56:06+00:00

The iput() function was called in up to three cases by the udf_fill_super()
function during error handling even if the passed data structure element
contained still a null pointer. This implementation detail could be improved
by the introduction of another jump label.

Signed-off-by: Markus Elfring 
Signed-off-by: Jan Kara

udf: Deletion of unnecessary checks before the function call "iput"

2014-11-19T20:55:45+00:00

The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Jan Kara

udf: Fix loading of special inodes

2014-10-09T11:06:14+00:00

Some UDF media have special inodes (like VAT or metadata partition
inodes) whose link_count is 0. Thus commit 4071b9136223 (udf: Properly
detect stale inodes) broke loading these inodes because udf_iget()
started returning -ESTALE for them. Since we still need to properly
detect stale inodes queried by NFS, create two variants of udf_iget() -
one which is used for looking up special inodes (which ignores
link_count == 0) and one which is used for other cases which return
ESTALE when link_count == 0.

Fixes: 4071b913622316970d0e1919f7d82b4403fec5f2
CC: stable@vger.kernel.org
Signed-off-by: Jan Kara

udf: remove redundant sys_tz declaration

2014-09-29T11:45:12+00:00

sys_tz is already declared in include/linux/time.h

Cc: Jan Kara 
Signed-off-by: Fabian Frederick 
Signed-off-by: Jan Kara