linux-stable.git/fs/udf/unicode.c, branch v4.3

udf: Make udf_get_filename() return error instead of 0 length file name

2015-05-18T09:23:06+00:00

Zero length file name isn't really valid. So check the length of the
final file name generated by udf_translate_to_linux() and return -EINVAL
instead of zero length file name. Update caller of udf_get_filename() to
not check for 0 return value.

Signed-off-by: Fabian Frederick 
Signed-off-by: Jan Kara

udf: bug on exotic flag in udf_get_filename()

2015-05-18T09:23:06+00:00

UDF volume is only mounted with UDF_FLAG_UTF8
or UDF_FLAG_NLS_MAP (see fill udf_fill_super().
BUG() if we have something different in udf_get_filename()

Suggested-by: Jan Kara 
Signed-off-by: Fabian Frederick 
Signed-off-by: Jan Kara

udf: improve error management in udf_CS0toNLS()

2015-05-18T09:23:05+00:00

Only callsite udf_get_filename() now returns error code as well.

Suggested-by: Jan Kara 
Signed-off-by: Fabian Frederick 
Signed-off-by: Jan Kara

udf: improve error management in udf_CS0toUTF8()

2015-05-18T09:23:05+00:00

udf_CS0toUTF8() now returns -EINVAL on error.
udf_load_pvoldesc() and udf_get_filename() do the same.

Suggested-by: Jan Kara 
Signed-off-by: Fabian Frederick 
Signed-off-by: Jan Kara

udf: unicode: update function name in comments

2015-05-18T09:23:04+00:00

Signed-off-by: Fabian Frederick 
Signed-off-by: Jan Kara

udf: remove unnecessary test in udf_build_ustr_exact()

2015-05-18T09:23:04+00:00

We can remove parameter checks:

udf_build_ustr_exact() is only called by udf_get_filename()
which now assures dest is not NULL

udf_find_entry() and udf_readdir() call udf_get_filename()
after checking sname
udf_symlink_filler() calls udf_pc_to_char() with sname=kmap(page).

udf_find_entry() and udf_readdir() call udf_get_filename with UDF_NAME_LEN
udf_pc_to_char() with PAGE_SIZE

Suggested-by: Jan Kara 
Signed-off-by: Fabian Frederick 
Signed-off-by: Jan Kara

udf: Return -ENOMEM when allocation fails in udf_get_filename()

2015-05-18T09:23:03+00:00

Return -ENOMEM when allocation fails in udf_get_filename(). Update
udf_pc_to_char(), udf_readdir(), and udf_find_entry() to handle the
error appropriately. This allows us to pass appropriate error to
userspace instead of corrupting symlink contents by omitting some path
elements.

Signed-off-by: Fabian Frederick 
Signed-off-by: Jan Kara

udf: Check path length when reading symlink

2014-12-19T13:12:08+00:00

Symlink reading code does not check whether the resulting path fits into
the page provided by the generic code. This isn't as easy as just
checking the symlink size because of various encoding conversions we
perform on path. So we have to check whether there is still enough space
in the buffer on the fly.

CC: stable@vger.kernel.org
Reported-by: Carl Henrik Lunde 
Signed-off-by: Jan Kara

fs/udf: re-use hex_asc_upper_{hi,lo} macros

2014-07-15T20:40:24+00:00

This patch cleans up udf_translate_to_linux() a bit by using globally defined
macros instead of custom code.

We can use sprintf(buf, "%04X", ...) there as well, but this one faster.

Signed-off-by: Andy Shevchenko 
Signed-off-by: Jan Kara

udf: Convert printks to pr_

2011-10-31T22:43:52+00:00

Use the current logging styles.

Convert a few printks that should have been udf_warn and udf_err.
Coalesce formats.  Add #define pr_fmt.
Move an #include "udfdecls.h" above other includes in udftime.c
so pr_fmt works correctly.  Strip prefixes from conversions as appropriate.
Reorder logging definitions in udfdecl.h

Signed-off-by: Joe Perches 
Signed-off-by: Jan Kara