linux-stable.git/fs/sysfs/dir.c, branch v3.12

sysfs: use check_submounts_and_drop()

2013-09-05T20:23:53+00:00

Do have_submounts(), shrink_dcache_parent() and d_drop() atomically.

check_submounts_and_drop() can deal with negative dentries and
non-directories as well.

Non-directories can also be mounted on.  And just like directories we don't
want these to disappear with invalidation.

Signed-off-by: Miklos Szeredi 
Acked-by: Greg Kroah-Hartman 
Signed-off-by: Al Viro

sysfs: dir.c: fix up odd do/while indentation

2013-08-21T23:36:02+00:00

This fixes up the odd do/while after an if statement warning in dir.c

Signed-off-by: Greg Kroah-Hartman

sysfs: fix up 80 column coding style issues

2013-08-21T23:33:34+00:00

This fixes up the 80 column coding style issues in the sysfs .c files.

Signed-off-by: Greg Kroah-Hartman

sysfs: fix up space coding style issues

2013-08-21T23:28:26+00:00

This fixes up all of the space-related coding style issues for the sysfs
code.

Signed-off-by: Greg Kroah-Hartman

sysfs: remove trailing whitespace

2013-08-21T23:21:17+00:00

This removes all trailing whitespace errors in the sysfs code.

Signed-off-by: Greg Kroah-Hartman

Merge tag 'driver-core-3.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core

2013-07-02T18:44:19+00:00

Pull driver core updates from Greg KH:
 "Here's the big driver core merge for 3.11-rc1

  Lots of little things, and larger firmware subsystem updates, all
  described in the shortlog.  Nice thing here is that we finally get rid
  of CONFIG_HOTPLUG, after 10+ years, thanks to Stephen Rohtwell (it had
  been always on for a number of kernel releases, now it's just
  removed)"

* tag 'driver-core-3.11-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core: (27 commits)
  driver core: device.h: fix doc compilation warnings
  firmware loader: fix another compile warning with PM_SLEEP unset
  build some drivers only when compile-testing
  firmware loader: fix compile warning with PM_SLEEP set
  kobject: sanitize argument for format string
  sysfs_notify is only possible on file attributes
  firmware loader: simplify holding module for request_firmware
  firmware loader: don't export cache_firmware and uncache_firmware
  drivers/base: Use attribute groups to create sysfs memory files
  firmware loader: fix compile warning
  firmware loader: fix build failure with !CONFIG_FW_LOADER_USER_HELPER
  Documentation: Updated broken link in HOWTO
  Finally eradicate CONFIG_HOTPLUG
  driver core: firmware loader: kill FW_ACTION_NOHOTPLUG requests before suspend
  driver core: firmware loader: don't cache FW_ACTION_NOHOTPLUG firmware
  Documentation: Tidy up some drivers/base/core.c kerneldoc content.
  platform_device: use a macro instead of platform_driver_register
  firmware: move EXPORT_SYMBOL annotations
  firmware: Avoid deadlock of usermodehelper lock at shutdown
  dell_rbu: Select CONFIG_FW_LOADER_USER_HELPER explicitly
  ...

[readdir] convert sysfs

2013-06-29T08:56:36+00:00

get rid of the kludges in sysfs_readdir()

Signed-off-by: Al Viro

sysfs: sysfs_link_sibling(): fix typo in comment

2013-05-17T17:26:08+00:00

Fix a typo subling->sibling in the comment of sysfs_link_sibling().

Signed-off-by: Warner Wang 
Signed-off-by: Greg Kroah-Hartman

sysfs: check if one entry has been removed before freeing

2013-04-05T22:35:52+00:00

It might be a kernel disaster if one sysfs entry is freed but
still referenced by sysfs tree.

Recently Dave and Sasha reported one use-after-free problem on
sysfs entry, and the problem has been troubleshooted with help
of debug message added in this patch.

Given sysfs_get_dirent/sysfs_put are exported APIs, even inside
sysfs they are called in many contexts(kobject/attribe add/delete,
inode init/drop, dentry lookup/release, readdir, ...), it is healthful
to check the removed flag before freeing one entry and dump message
if it is freeing without being removed first.

Cc: Dave Jones 
Cc: Sasha Levin 
Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman

sysfs: fix use after free in case of concurrent read/write and readdir

2013-04-03T18:09:02+00:00

The inode->i_mutex isn't hold when updating filp->f_pos
in read()/write(), so the filp->f_pos might be read as
0 or 1 in readdir() when there is concurrent read()/write()
on this same file, then may cause use after free in readdir().

The bug can be reproduced with Li Zefan's test code on the
link:

	https://patchwork.kernel.org/patch/2160771/

This patch fixes the use after free under this situation.

Cc: stable 
Reported-by: Li Zefan 
Signed-off-by: Ming Lei 
Signed-off-by: Greg Kroah-Hartman