linux-stable.git/fs/pstore, branch linux-4.8.y

pstore/ram: Use memcpy_fromio() to save old buffer

2016-10-28T07:45:20+00:00

commit d771fdf94180de2bd811ac90cba75f0f346abf8d upstream.

The ramoops buffer may be mapped as either I/O memory or uncached
memory.  On ARM64, this results in a device-type (strongly-ordered)
mapping.  Since unnaligned accesses to device-type memory will
generate an alignment fault (regardless of whether or not strict
alignment checking is enabled), it is not safe to use memcpy().
memcpy_fromio() is guaranteed to only use aligned accesses, so use
that instead.

Signed-off-by: Andrew Bresticker 
Signed-off-by: Enric Balletbo Serra 
Reviewed-by: Puneet Kumar 
Signed-off-by: Kees Cook 
Signed-off-by: Greg Kroah-Hartman

pstore/ram: Use memcpy_toio instead of memcpy

2016-10-28T07:45:20+00:00

commit 7e75678d23167c2527e655658a8ef36a36c8b4d9 upstream.

persistent_ram_update uses vmap / iomap based on whether the buffer is in
memory region or reserved region. However, both map it as non-cacheable
memory. For armv8 specifically, non-cacheable mapping requests use a
memory type that has to be accessed aligned to the request size. memcpy()
doesn't guarantee that.

Signed-off-by: Furquan Shaikh 
Signed-off-by: Enric Balletbo Serra 
Reviewed-by: Aaron Durbin 
Reviewed-by: Olof Johansson 
Tested-by: Furquan Shaikh 
Signed-off-by: Kees Cook 
Signed-off-by: Greg Kroah-Hartman

pstore/core: drop cmpxchg based updates

2016-10-28T07:45:20+00:00

commit d5a9bf0b38d2ac85c9a693c7fb851f74fd2a2494 upstream.

I have here a FPGA behind PCIe which exports SRAM which I use for
pstore. Now it seems that the FPGA no longer supports cmpxchg based
updates and writes back 0xff…ff and returns the same.  This leads to
crash during crash rendering pstore useless.
Since I doubt that there is much benefit from using cmpxchg() here, I am
dropping this atomic access and use the spinlock based version.

Cc: Anton Vorontsov 
Cc: Colin Cross 
Cc: Kees Cook 
Cc: Tony Luck 
Cc: Rabin Vincent 
Tested-by: Rabin Vincent 
Signed-off-by: Sebastian Andrzej Siewior 
Reviewed-by: Guenter Roeck 
[kees: remove "_locked" suffix since it's the only option now]
Signed-off-by: Kees Cook 
Signed-off-by: Greg Kroah-Hartman

pstore/ramoops: fixup driver removal

2016-10-28T07:45:20+00:00

commit 4407de74df18ed405cc5998990004c813ccfdbde upstream.

A basic rmmod ramoops segfaults. Let's see why.

Since commit 34f0ec82e0a9 ("pstore: Correct the max_dump_cnt clearing of
ramoops") sets ->max_dump_cnt to zero before looping over ->przs but we
didn't use it before that either.

And since commit ee1d267423a1 ("pstore: add pstore unregister") we free
that memory on rmmod.

But even then, we looped until a NULL pointer or ERR. I don't see where
it is ensured that the last member is NULL. Let's try this instead:
simply error recovery and free. Clean up in error case where resources
were allocated. And then, in the free path, rely on ->max_dump_cnt in
the free path.

Cc: Anton Vorontsov 
Cc: Colin Cross 
Cc: Kees Cook 
Cc: Tony Luck 
Cc: Namhyung Kim 
Acked-by: Namhyung Kim 
Signed-off-by: Sebastian Andrzej Siewior 
Signed-off-by: Kees Cook 
Signed-off-by: Greg Kroah-Hartman

ramoops: use persistent_ram_free() instead of kfree() for freeing prz

2016-08-05T18:21:46+00:00

persistent_ram_zone(=prz) structures are allocated by persistent_ram_new(),
which includes vmap() or ioremap(). But they are currently freed by
kfree(). This uses persistent_ram_free() for correct this asymmetry usage.

Signed-off-by: Hiraku Toyooka 
Signed-off-by: Nobuhiro Iwamatsu 
Cc: Mark Salyzyn 
Cc: Seiji Aguchi 
Signed-off-by: Kees Cook

ramoops: use DT reserved-memory bindings

2016-08-05T18:21:36+00:00

Instead of a ramoops-specific node, use a child node of /reserved-memory.
This requires that of_platform_device_create() be explicitly called
for the node, though, since "/reserved-memory" does not have its own
"compatible" property.

Suggested-by: Rob Herring 
Signed-off-by: Kees Cook 
Acked-by: Rob Herring

pstore/ram: add Device Tree bindings

2016-06-14T18:34:39+00:00

ramoops is one of the remaining places where ARM vendors still rely on
board-specific shims.  Device Tree lets us replace those shims with
generic code.

These bindings mirror the ramoops module parameters, with two small
differences:

(1) dump_oops becomes an optional "no-dump-oops" property, since ramoops
    sets dump_oops=1 by default.

(2) mem_type=1 becomes the more self-explanatory "unbuffered" property.

Signed-off-by: Greg Hackmann 
[fixed platform_get_drvdata() crash, thanks to Brian Norris]
[switched from u64 to u32 to simplify code, various whitespace fixes]
[use dev_of_node() to gain code-elimination for CONFIG_OF=n]
Signed-off-by: Kees Cook

pstore: drop file opened reference count

2016-06-02T18:24:52+00:00

In ee1d267423a1 ("pstore: add pstore unregister") I added:
	.owner = THIS_MODULE,
in both pstore_fs_type and pstore_file_operations to increase a reference
count when pstore filesystem is mounted and pstore file is opened.

But, it's repetitive. There is no need to increase the opened reference
count. We only need to increase the mounted reference count. When a file
is opened, the filesystem can't be unmounted. Hence the pstore module
can't be unloaded either.

So I drop the opened reference count in this patch.

Fixes: ee1d267423a1 ("pstore: add pstore unregister")
Signed-off-by: Geliang Tang 
Signed-off-by: Kees Cook

pstore: add lzo/lz4 compression support

2016-06-02T17:59:31+00:00

Like zlib compression in pstore, this patch added lzo and lz4
compression support so that users can have more options and better
compression ratio.

The original code treats the compressed data together with the
uncompressed ECC correction notice by using zlib decompress. The
ECC correction notice is missing in the decompression process. The
treatment also makes lzo and lz4 not working. So I treat them
separately by using pstore_decompress() to treat the compressed
data, and memcpy() to treat the uncompressed ECC correction notice.

Signed-off-by: Geliang Tang 
Signed-off-by: Kees Cook

pstore: Cleanup pstore_dump()

2016-05-31T19:36:45+00:00

The code is duplicate between compression is enabled or not.

Signed-off-by: Namhyung Kim 
Signed-off-by: Kees Cook