linux-stable.git/fs/nfsd, branch linux-3.8.y

nfsd: Decode and send 64bit time values

2013-05-08T03:08:23+00:00

commit bf8d909705e9d9bac31d9b8eac6734d2b51332a7 upstream.

The seconds field of an nfstime4 structure is 64bit, but we are assuming
that the first 32bits are zero-filled.  So if the client tries to set
atime to a value before the epoch (touch -t 196001010101), then the
server will save the wrong value on disk.

Signed-off-by: Bryan Schumaker 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Greg Kroah-Hartman

nfsd: don't run get_file if nfs4_preprocess_stateid_op return error

2013-05-08T03:08:23+00:00

commit b022032e195ffca83d7002d6b84297d796ed443b upstream.

we should return error status directly when nfs4_preprocess_stateid_op
return error.

Signed-off-by: fanchaoting 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Greg Kroah-Hartman

nfsd4: don't close read-write opens too soon

2013-05-08T03:08:23+00:00

commit 0c7c3e67ab91ec6caa44bdf1fc89a48012ceb0c5 upstream.

Don't actually close any opens until we don't need them at all.

This means being left with write access when it's not really necessary,
but that's better than putting a file that might still have posix locks
held on it, as we have been.

Reported-by: Toralf Förster 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Greg Kroah-Hartman

nfsd4: reject "negative" acl lengths

2013-04-05T16:26:15+00:00

commit 64a817cfbded8674f345d1117b117f942a351a69 upstream.

Since we only enforce an upper bound, not a lower bound, a "negative"
length can get through here.

The symptom seen was a warning when we attempt to a kmalloc with an
excessive size.

Reported-by: Toralf Förster 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Greg Kroah-Hartman

nfsd: fix bad offset use

2013-03-28T19:18:01+00:00

commit e49dbbf3e770aa590a8a464ac4978a09027060b9 upstream.

vfs_writev() updates the offset argument - but the code then passes the
offset to vfs_fsync_range(). Since offset now points to the offset after
what was just written, this is probably not what was intended

Introduced by face15025ffdf664de95e86ae831544154d26c9c "nfsd: use
vfs_fsync_range(), not O_SYNC, for stable writes".

Signed-off-by: Kent Overstreet 
Cc: Al Viro 
Cc: "Eric W. Biederman" 
Reviewed-by: Zach Brown 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Greg Kroah-Hartman

nfsd: Fix memleak

2013-03-03T22:03:37+00:00

commit 2d32b29a1c2830f7c42caa8258c714acd983961f upstream.

When free nfs-client, it must free the ->cl_stateids.

Signed-off-by: Jianpeng Ma 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Greg Kroah-Hartman

Revert "nfsd: warn on odd reply state in nfsd_vfs_read"

2012-12-22T01:07:45+00:00

This reverts commit 79f77bf9a4e3dd5ead006b8f17e7c4ff07d8374e.

This is obviously wrong, and I have no idea how I missed seeing the
warning in testing: I must just not have looked at the right logs.  The
caller bumps rq_resused/rq_next_page, so it will always be hit on a
large enough read.

Reported-by: Dave Jones 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Linus Torvalds

nfsd4: don't leave freed stateid hashed

2012-12-18T03:00:28+00:00

Note the stateid is hashed early on in init_stid(), but isn't currently
being unhashed on error paths.

Signed-off-by: J. Bruce Fields

nfsd4: free_stateid can use the current stateid

2012-12-18T03:00:27+00:00

Cc: Tigran Mkrtchyan 
Signed-off-by: J. Bruce Fields

nfsd4: cleanup: replace rq_resused count by rq_next_page pointer

2012-12-18T03:00:16+00:00

It may be a matter of personal taste, but I find this makes the code
clearer.

Signed-off-by: J. Bruce Fields