linux-stable.git/fs/nfs/flexfilelayout, branch linux-5.7.y

NFS: Fix flexfiles read failover

2020-08-21T11:07:41+00:00

[ Upstream commit 563c53e73b8b6ec842828736f77e633f7b0911e9 ]

The current mirrored read failover code is correctly resetting the mirror
index between failed reads, however it is not able to actually flip the
RPC call over to the next RPC client.
The end result is that we keep resending the RPC call to the same client
over and over.

The fix is to use the pnfs_read_resend_pnfs() mechanism to schedule a
new RPC call, but we need to add the ability to pass in a mirror
index so that we always retry the next mirror in the list.

Fixes: 166bd5b889ac ("pNFS/flexfiles: Fix layoutstats handling during read failovers")
Signed-off-by: Trond Myklebust 
Signed-off-by: Sasha Levin

pNFS/flexfiles: Fix list corruption if the mirror count changes

2020-06-30T19:36:30+00:00

commit 8b04013737341442ed914b336cde866b902664ae upstream.

If the mirror count changes in the new layout we pick up inside
ff_layout_pg_init_write(), then we can end up adding the
request to the wrong mirror and corrupting the mirror->pg_list.

Fixes: d600ad1f2bdb ("NFS41: pop some layoutget errors to application")
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker 
Signed-off-by: Greg Kroah-Hartman

pNFS/flexfiles: Specify the layout segment range in LAYOUTGET

2020-03-27T20:34:35+00:00

Move from requesting only full file layout segments, to requesting
layout segments that match our I/O size. This means the server is
still free to return a full file layout, but we will no longer
error out if it does not.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: remove requirement for whole file layouts

2020-03-27T20:34:35+00:00

Remove the requirement that the server always sends whole file
layouts.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: Check the layout segment range before doing I/O

2020-03-27T20:34:35+00:00

When starting to read or write with a layout segment, check that the
range matches our request.

Signed-off-by: Trond Myklebust

pNFS/flexfile: Don't merge layout segments if the mirrors don't match

2020-03-27T20:34:35+00:00

Check that the number of mirrors, and the mirror information matches
before deciding to merge layout segments in pNFS/flexfiles.

Signed-off-by: Trond Myklebust

NFS/pNFS: Clean up pNFS commit operations

2020-03-27T20:34:35+00:00

Move the pNFS commit related operations into a separate structure
that can be carried by the pnfs_ds_commit_info.

Signed-off-by: Trond Myklebust

NFS: Remove bucket array from struct pnfs_ds_commit_info

2020-03-27T20:34:35+00:00

Remove the unused bucket array in struct pnfs_ds_commit_info.

Signed-off-by: Trond Myklebust

pNFS: Enable per-layout segment commit structures

2020-03-27T20:34:34+00:00

Enable adding and lookup of per-layout segment commits in filelayout
and flexfilelayout.

Signed-off-by: Trond Myklebust

pNFS: Add infrastructure for cleaning up per-layout commit structures

2020-03-27T20:34:34+00:00

Ensure that both the file and flexfiles layout types clean up when
freeing the layout segments.

Signed-off-by: Trond Myklebust