linux-stable.git/fs/nfs/flexfilelayout, branch linux-4.8.y

pNFS: Fix a deadlock between read resends and layoutreturn

2017-01-09T07:22:02+00:00

commit 54e4a0dfa25d9365c4e80a639e80d9213eb6edbe upstream.

We must not call nfs_pageio_init_read() on a new nfs_pageio_descriptor
while holding a reference to a layout segment, as that can deadlock
pnfs_update_layout().

Fixes: d67ae825a59d6 ("pnfs/flexfiles: Add the FlexFile Layout Driver")
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

pNFS/flexfiles: Fix an Oopsable condition when connection to the DS fails

2016-08-29T19:21:16+00:00

If the attempt to connect to a DS fails inside ff_layout_pg_init_read or
ff_layout_pg_init_write, then we currently end up clearing the layout
segment carried by the struct nfs_pageio_descriptor, causing an Oops
when we later call into ff_layout_read_pagelist/ff_layout_write_pagelist.

The fix is to ensure we return the layout and then retry.

Fixes: 446ca2195303 ("pNFS/flexfiles: When initing reads or writes, we...")
Cc: stable@vger.kernel.org # v4.7+
Signed-off-by: Trond Myklebust

pNFS/flexfiles: Set reasonable default retrans values for the data channel

2016-08-16T15:16:19+00:00

Prior to this patch, the retrans value was set at 5, meaning that we
could see a maximum retransmission timeout value of more than 6 minutes.
That's a tad high for NFSv3 where the protocol does allow the server to
drop requests at any time.

Since this is a data channel, let's just set retrans to 0, and the default
timeout to 60s. The user can continue to adjust these defaults using the
dataserver_retrans and dataserver_timeo module parameters.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: Fix layoutstat periodic reporting

2016-08-15T03:01:10+00:00

Putting the periodicity timer in the mirror instances is causing
non-scalable reporting behaviour and missed reporting intervals.
When you recall layouts and/or implement client side mirroring, it
leads to consecutive reports with only a few ms between RPC calls.

Signed-off-by: Trond Myklebust 
Fixes: d0379a5d066a9 ("pNFS/flexfiles: Support server-supplied...")

pNFS: Files and flexfiles always need to commit before layoutcommit

2016-07-05T23:08:01+00:00

So ensure that we mark the layout for commit once the write is done,
and then ensure that the commit to ds is finished before sending
layoutcommit.

Note that by doing this, we're able to optimise away the commit
for the case of servers that don't need layoutcommit in order to
return updated attributes.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: Clean up calls to pnfs_set_layoutcommit()

2016-07-05T22:52:26+00:00

Let's just have one place where we check ff_layout_need_layoutcommit().

Signed-off-by: Trond Myklebust

pNFS/flexfiles: Fix layoutcommit after a commit to DS

2016-07-05T22:52:26+00:00

We should always do a layoutcommit after commit to DS, except if
the layout segment we're using has set FF_FLAGS_NO_LAYOUTCOMMIT.

Fixes: d67ae825a59d ("pnfs/flexfiles: Add the FlexFile Layout Driver")
Signed-off-by: Trond Myklebust

pnfs: pnfs_update_layout needs to consider if strict iomode checking is on

2016-05-26T12:40:56+00:00

As flexfiles has FF_FLAGS_NO_READ_IO, there is a need to generically
support enforcing that a IOMODE_RW segment will not allow READ I/O.

Signed-off-by: Tom Haynes 
Signed-off-by: Anna Schumaker

nfs/flexfiles: Use the layout segment for reading unless it a IOMODE_RW and reading is disabled

2016-05-26T12:40:51+00:00

Signed-off-by: Tom Haynes 
Signed-off-by: Anna Schumaker

nfs/flexfiles: Helper function to detect FF_FLAGS_NO_READ_IO

2016-05-25T17:35:20+00:00

The mds can inform the client not to use the IOMODE_RW layout
segment for doing READs. I.e., it is basically a
IOMODE_WRITE layout segment.

It would do this to not interfere with the WRITEs.

Signed-off-by: Tom Haynes 
Signed-off-by: Anna Schumaker