linux-stable.git/fs/nfs/flexfilelayout, branch linux-4.1.y

pNFS/flexfiles: missing error code in ff_layout_alloc_lseg()

2018-05-23T01:36:25+00:00

[ Upstream commit 662f9a105b4322b8559d448f86110e6ec24b8738 ]

If xdr_inline_decode() fails then we end up returning ERR_PTR(0).  The
caller treats NULL returns as -ENOMEM so it doesn't really hurt runtime,
but obviously we intended to set an error code here.

Fixes: d67ae825a59d ("pnfs/flexfiles: Add the FlexFile Layout Driver")
Signed-off-by: Dan Carpenter 
Signed-off-by: Trond Myklebust 
Signed-off-by: Sasha Levin

nfs/flexfiles: fix leak of nfs4_ff_ds_version arrays

2017-09-10T20:36:10+00:00

[ Upstream commit 1feb26162bee7b2f110facfec71b5c7bdbc7d14d ]

The client was freeing the nfs4_ff_layout_ds, but not the contained
nfs4_ff_ds_version array.

Signed-off-by: Weston Andros Adamson 
Cc: stable@vger.kernel.org # v4.0+
Signed-off-by: Anna Schumaker 
Signed-off-by: Sasha Levin

pNFS/flexfiles: Fix an XDR encoding bug in layoutreturn

2016-02-15T20:45:19+00:00

[ Upstream commit 082fa37d1351a41afc491d44a1d095cb8d919aa2 ]

We must not skip encoding the statistics, or the server will see an
XDR encoding error.

Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org # 4.0+
Signed-off-by: Sasha Levin

NFSv4.1/flexfiles: Fix a protocol error in layoutreturn

2015-09-29T17:26:10+00:00

commit d13549074cf066d6d5bb29903d044beffea342d3 upstream.

According to the flexfiles protocol, the layoutreturn should specify an
array of errors in the following format:

struct ff_ioerr4 {
	offset4        ffie_offset;
	length4        ffie_length;
	stateid4       ffie_stateid;
	device_error4  ffie_errors<>;
};

This patch fixes up the code to ensure that our ffie_errors is indeed
encoded as an array (albeit with only a single entry).

Reported-by: Tom Haynes 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

NFS41/flexfiles: zero out DS write wcc

2015-09-29T17:26:10+00:00

commit 5420401079e152ff68a8024f6a375804b1c21505 upstream.

We do not want to update inode attributes with DS values.

Signed-off-by: Peng Tao 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

NFS41/flexfiles: update inode after write finishes

2015-09-29T17:26:09+00:00

commit 69f230d907e8c1ca3f9bd528993eeb98f712b0dd upstream.

Otherwise we break fstest case tests/read_write/mctime.t

Does files layout need the same fix as well?

Cc: Anna Schumaker 
Signed-off-by: Peng Tao 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

nfs: always update creds in mirror, even when we have an already connected ds

2015-08-03T16:29:17+00:00

commit 0c8315dd56577445dd1afe6b9cfa06b7efdf2f82 upstream.

A ds can be associated with more than one mirror, but we currently skip
setting a mirror's credentials if we find that it's already set up with
a connected client.

The upshot is that we can end up sending DS writes with MDS credentials
instead of properly setting them up. Fix nfs4_ff_layout_prepare_ds to
always verify that the mirror's credentials are set up, even when we
have a DS that's already connected.

Reported-by: Tom Haynes 
Signed-off-by: Jeff Layton 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

nfs: fix potential credential leak in ff_layout_update_mirror_cred

2015-08-03T16:29:17+00:00

commit a24221dca1868101c9b4b5adde4a6a5b1a3a64a7 upstream.

If we have two tasks racing to update a mirror's credentials, then they
can end up leaking one (or more) sets of credentials. The first task
will set mirror->cred and then the second task will just overwrite it.

Use a cmpxchg to ensure that the creds are only set once. If we get to
the point where we would set mirror->cred and find that they're already
set, then we just release the creds that were just found.

Signed-off-by: Jeff Layton 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

pNFS/flexfiles: Fix the reset of struct pgio_header when resending

2015-08-03T16:29:17+00:00

commit d620876990f02788d5a663075df007ffb91bdfad upstream.

hdr->good_bytes needs to be set to the length of the request, not
zero.

Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

NFS: Move nfs_idmap.h into fs/nfs/

2015-04-23T19:16:14+00:00

This file is only used internally to the NFS v4 module, so it doesn't
need to be in the global include path.  I also renamed it from
nfs_idmap.h to nfs4idmap.h to emphasize that it's an NFSv4-only include
file.

Signed-off-by: Anna Schumaker 
Signed-off-by: Trond Myklebust