linux-stable.git/fs/nfs/flexfilelayout/flexfilelayoutdev.c, branch linux-4.9.y

pnfs/flexfiles: Fix misplaced barrier in nfs4_ff_layout_prepare_ds

2021-11-26T10:48:37+00:00

[ Upstream commit a2915fa06227b056a8f9b0d79b61dca08ad5cfc6 ]

_nfs4_pnfs_v3/v4_ds_connect do
   some work
   smp_wmb
   ds->ds_clp = clp;

And nfs4_ff_layout_prepare_ds currently does
   smp_rmb
   if(ds->ds_clp)
      ...

This patch places the smp_rmb after the if. This ensures that following
reads only happen once nfs4_ff_layout_prepare_ds has checked that data
has been properly initialized.

Fixes: d67ae825a59d6 ("pnfs/flexfiles: Add the FlexFile Layout Driver")
Signed-off-by: Baptiste Lepers 
Signed-off-by: Trond Myklebust 
Signed-off-by: Sasha Levin

NFS/flexfiles: Use the correct TCP timeout for flexfiles I/O

2019-07-10T07:55:39+00:00

commit 68f461593f76bd5f17e87cdd0bea28f4278c7268 upstream.

Fix a typo where we're confusing the default TCP retrans value
(NFS_DEF_TCP_RETRANS) for the default TCP timeout value.

Fixes: 15d03055cf39f ("pNFS/flexfiles: Set reasonable default ...")
Cc: stable@vger.kernel.org # 4.8+
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker 
Signed-off-by: Greg Kroah-Hartman

nfs/flexfiles: fix leak of nfs4_ff_ds_version arrays

2017-08-16T20:43:17+00:00

commit 1feb26162bee7b2f110facfec71b5c7bdbc7d14d upstream.

The client was freeing the nfs4_ff_layout_ds, but not the contained
nfs4_ff_ds_version array.

Signed-off-by: Weston Andros Adamson 
Signed-off-by: Anna Schumaker 
Signed-off-by: Greg Kroah-Hartman

pNFS/flexfiles: Fix an Oopsable condition when connection to the DS fails

2016-08-29T19:21:16+00:00

If the attempt to connect to a DS fails inside ff_layout_pg_init_read or
ff_layout_pg_init_write, then we currently end up clearing the layout
segment carried by the struct nfs_pageio_descriptor, causing an Oops
when we later call into ff_layout_read_pagelist/ff_layout_write_pagelist.

The fix is to ensure we return the layout and then retry.

Fixes: 446ca2195303 ("pNFS/flexfiles: When initing reads or writes, we...")
Cc: stable@vger.kernel.org # v4.7+
Signed-off-by: Trond Myklebust

pNFS/flexfiles: Set reasonable default retrans values for the data channel

2016-08-16T15:16:19+00:00

Prior to this patch, the retrans value was set at 5, meaning that we
could see a maximum retransmission timeout value of more than 6 minutes.
That's a tad high for NFSv3 where the protocol does allow the server to
drop requests at any time.

Since this is a data channel, let's just set retrans to 0, and the default
timeout to 60s. The user can continue to adjust these defaults using the
dataserver_retrans and dataserver_timeo module parameters.

Signed-off-by: Trond Myklebust

nfs/flexfiles: Helper function to detect FF_FLAGS_NO_READ_IO

2016-05-25T17:35:20+00:00

The mds can inform the client not to use the IOMODE_RW layout
segment for doing READs. I.e., it is basically a
IOMODE_WRITE layout segment.

It would do this to not interfere with the WRITEs.

Signed-off-by: Tom Haynes 
Signed-off-by: Anna Schumaker

flexfiles: add kerneldoc header to nfs4_ff_layout_prepare_ds

2016-05-17T19:48:11+00:00

Signed-off-by: Jeff Layton 
Signed-off-by: Anna Schumaker

flexfiles: remove pointless setting of NFS_LAYOUT_RETURN_REQUESTED

2016-05-17T19:48:11+00:00

Setting just the NFS_LAYOUT_RETURN_REQUESTED flag doesn't do anything,
unless there are lsegs that are also being marked for return. At the
point where that happens this flag is also set, so these set_bit calls
don't do anything useful.

Signed-off-by: Jeff Layton 
Signed-off-by: Anna Schumaker

pNFS/flexfiles: When checking for available DSes, conditionally check for MDS io

2016-05-17T19:48:08+00:00

Whenever we check to see if we have the needed number of DSes for the
action, we may also have to check to see whether IO is allowed to go to
the MDS or not.

[jlayton: fix merge conflict due to lack of localio patches here]

Signed-off-by: Tom Haynes 
Signed-off-by: Jeff Layton 
Signed-off-by: Anna Schumaker

NFSv4: Label stateids with the type

2016-05-17T19:48:06+00:00

In order to more easily distinguish what kind of stateid we are dealing
with, introduce a type that can be used to label the stateid structure.

The label will be useful both for debugging, but also when dealing with
operations like SETATTR, READ and WRITE that can take several different
types of stateid as arguments.

Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker