linux-stable.git/fs/nfs/flexfilelayout/flexfilelayoutdev.c, branch linux-4.2.y

NFSv4.1/flexfiles: Fix a protocol error in layoutreturn

2015-09-29T17:33:29+00:00

commit d13549074cf066d6d5bb29903d044beffea342d3 upstream.

According to the flexfiles protocol, the layoutreturn should specify an
array of errors in the following format:

struct ff_ioerr4 {
	offset4        ffie_offset;
	length4        ffie_length;
	stateid4       ffie_stateid;
	device_error4  ffie_errors<>;
};

This patch fixes up the code to ensure that our ffie_errors is indeed
encoded as an array (albeit with only a single entry).

Reported-by: Tom Haynes 
Signed-off-by: Trond Myklebust 
Signed-off-by: Greg Kroah-Hartman

nfs: always update creds in mirror, even when we have an already connected ds

2015-06-25T23:35:21+00:00

A ds can be associated with more than one mirror, but we currently skip
setting a mirror's credentials if we find that it's already set up with
a connected client.

The upshot is that we can end up sending DS writes with MDS credentials
instead of properly setting them up. Fix nfs4_ff_layout_prepare_ds to
always verify that the mirror's credentials are set up, even when we
have a DS that's already connected.

Reported-by: Tom Haynes 
Signed-off-by: Jeff Layton 
Cc: stable@vger.kernel.org # 4.0+
Signed-off-by: Trond Myklebust

nfs: fix potential credential leak in ff_layout_update_mirror_cred

2015-06-25T23:34:40+00:00

If we have two tasks racing to update a mirror's credentials, then they
can end up leaking one (or more) sets of credentials. The first task
will set mirror->cred and then the second task will just overwrite it.

Use a cmpxchg to ensure that the creds are only set once. If we get to
the point where we would set mirror->cred and find that they're already
set, then we just release the creds that were just found.

Signed-off-by: Jeff Layton 
Cc: stable@vger.kernel.org # 4.0+
Signed-off-by: Trond Myklebust

NFSv4.1: Convert pNFS deviceid to use kfree_rcu()

2015-03-27T16:32:24+00:00

Use of synchronize_rcu() when unmounting and potentially freeing a lot
of deviceids is problematic. There really is no reason why we can't just
use kfree_rcu() here.

Signed-off-by: Trond Myklebust

pnfs/flexfiles: Do not dprintk after the free

2015-02-10T03:34:29+00:00

Found by 0-DAY kernel test infrastructure:

fs/nfs/flexfilelayout/flexfilelayoutdev.c:520:13-16: ERROR: reference preceded by free on line 518
fs/nfs/flexfilelayout/flexfilelayoutdev.c:520:26-29: ERROR: reference preceded by free on line 518
fs/nfs/flexfilelayout/flexfilelayoutdev.c:520:39-42: ERROR: reference preceded by free on line 518
fs/nfs/flexfilelayout/flexfilelayoutdev.c:521:3-6: ERROR: reference preceded by free on line 518

Reported-by: Julia Lawall 
Signed-off-by: Tom Haynes 
Signed-off-by: Trond Myklebust

pnfs/flexfiles: Add the FlexFile Layout Driver

2015-02-03T19:06:52+00:00

The flexfile layout is a new layout that extends the
file layout. It is currently being drafted as a specification at
https://datatracker.ietf.org/doc/draft-ietf-nfsv4-layout-types/

Signed-off-by: Weston Andros Adamson 
Signed-off-by: Tom Haynes 
Signed-off-by: Tao Peng