linux-stable.git/fs/nfs/callback_proc.c, branch linux-5.4.y

NFSv4/pnfs: pnfs_set_layout_stateid() should update the layout cred

2025-06-04T12:32:29+00:00

[ Upstream commit 59b5639490f51aa604d18064dcf0c2d72eb1decf ]

If the cred assigned to the layout that we're updating differs from
the one used to retrieve the new layout segment, then we need to
update the layout plh_lc_cred field.

Signed-off-by: Trond Myklebust 
Stable-dep-of: 6d6d7f91cc8c ("NFSv4/pnfs: Reset the layout state after a layoutreturn")
Signed-off-by: Sasha Levin

NFSv4/pNFS: Fix another issue with a list iterator pointing to the head

2022-04-15T12:18:21+00:00

[ Upstream commit 7c9d845f0612e5bcd23456a2ec43be8ac43458f1 ]

In nfs4_callback_devicenotify(), if we don't find a matching entry for
the deviceid, we're left with a pointer to 'struct nfs_server' that
actually points to the list of super blocks associated with our struct
nfs_client.
Furthermore, even if we have a valid pointer, nothing pins the super
block, and so the struct nfs_server could end up getting freed while
we're using it.

Since all we want is a pointer to the struct pnfs_layoutdriver_type,
let's skip all the iteration over super blocks, and just use APIs to
find the layout driver directly.

Reported-by: Xiaomeng Tong 
Fixes: 1be5683b03a7 ("pnfs: CB_NOTIFY_DEVICEID")
Signed-off-by: Trond Myklebust 
Signed-off-by: Sasha Levin

NFSv4.1: Fix uninitialised variable in devicenotify

2022-02-16T11:52:48+00:00

[ Upstream commit b05bf5c63b326ce1da84ef42498d8e0e292e694c ]

When decode_devicenotify_args() exits with no entries, we need to
ensure that the struct cb_devicenotifyargs is initialised to
{ 0, NULL } in order to avoid problems in
nfs4_callback_devicenotify().

Reported-by: 
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker 
Signed-off-by: Sasha Levin

NFSv4/pnfs: Return valid stateids in nfs_layout_find_inode_by_stateid()

2020-04-23T08:36:31+00:00

[ Upstream commit d911c57a19551c6bef116a3b55c6b089901aacb0 ]

Make sure to test the stateid for validity so that we catch instances
where the server may have been reusing stateids in
nfs_layout_find_inode_by_stateid().

Fixes: 7b410d9ce460 ("pNFS: Delay getting the layout header in CB_LAYOUTRECALL handlers")
Signed-off-by: Trond Myklebust 
Signed-off-by: Sasha Levin

NFS4: Add a trace event to record invalid CB sequence IDs

2019-07-09T14:30:25+00:00

Help debug NFSv4 callback failures.

Signed-off-by: Chuck Lever 
Signed-off-by: Anna Schumaker

NFSv4.2 copy do not allocate memory under the lock

2018-11-22T18:54:46+00:00

Bruce pointed out that we shouldn't allocate memory while holding
a lock in the nfs4_callback_offload() and handle_async_copy()
that deal with a racing CB_OFFLOAD and reply to COPY case.

Signed-off-by: Olga Kornievskaia 
Signed-off-by: Trond Myklebust

NFSv4: Fix an Oops during delegation callbacks

2018-11-13T22:15:17+00:00

If the server sends a CB_GETATTR or a CB_RECALL while the filesystem is
being unmounted, then we can Oops when releasing the inode in
nfs4_callback_getattr() and nfs4_callback_recall().

Signed-off-by: Trond Myklebust

NFSv4: Fix a sleep in atomic context in nfs4_callback_sequence()

2018-08-15T16:05:15+00:00

We must drop the lock before we can sleep in referring_call_exists().

Reported-by: Jia-Ju Bai 
Fixes: 045d2a6d076a ("NFSv4.1: Delay callback processing...")
Cc: stable@vger.kernel.org # v4.9+
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFS handle COPY reply CB_OFFLOAD call race

2018-08-09T16:56:39+00:00

It's possible that server replies back with CB_OFFLOAD call and
COPY reply at the same time such that client will process
CB_OFFLOAD before reply to COPY. For that keep a list of pending
callback stateids received and then before waiting on completion
check the pending list.

Cleanup any pending copies on the client shutdown.

Signed-off-by: Olga Kornievskaia 
Signed-off-by: Anna Schumaker

NFS add support for asynchronous COPY

2018-08-09T16:56:39+00:00

Change xdr to always send COPY asynchronously.

Keep the list copies send in a list under a server structure.
Once copy is sent, it waits on a completion structure that will
be signalled by the callback thread that receives CB_OFFLOAD.

If CB_OFFLOAD returned an error and even if it returned partial
bytes, ignore them (as we can't commit without a verifier to
match) and return an error.

Signed-off-by: Olga Kornievskaia 
Signed-off-by: Anna Schumaker