linux-stable.git/fs/nfs/callback_proc.c, branch linux-3.9.y

NFSv4.1: Fix bulk recall and destroy of layouts

2013-02-14T18:22:50+00:00

The current code in pnfs_destroy_all_layouts() assumes that removing
the layout from the server->layouts list is sufficient to make it
invisible to other processes. This ignores the fact that most
users access the layout through the nfs_inode->layout...
There is further breakage due to lack of reference counting of the
layouts, meaning that the whole thing Oopses at the drop of a hat.

The code in initiate_bulk_draining() is almost correct, and can be
used as a model for pnfs_destroy_all_layouts(), so move that
code to pnfs.c, and refactor the code to allow us to choose between
a single filesystem bulk recall, and a recall of all layouts.
Also note that initiate_bulk_draining() currently calls iput() while
holding locks. Fix that too.

Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org

nfs: avoid dereferencing null pointer in initiate_bulk_draining

2013-01-05T19:26:51+00:00

Fix an inverted null pointer check in initiate_bulk_draining().

Signed-off-by: Nickolai Zeldovich 
Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org [>= 3.7]

NFSv4.1: Cleanup move session slot management to fs/nfs/nfs4session.c

2012-12-05T23:30:45+00:00

NFSv4.1 session management is getting complex enough to deserve
a separate file.

Signed-off-by: Trond Myklebust

NFSv4.1: CB_RECALL_SLOT must schedule a sequence op after updating targets

2012-12-05T23:30:43+00:00

RFC5661 requires us to make sure that the server knows we've updated
our slot table size by sending at least one SEQUENCE op containing the
new 'highest_slotid' value.
We can do so using the 'CHECK_LEASE' functionality of the state
manager.

Signed-off-by: Trond Myklebust

NFSv4.1: Remove the state manager code to resize the slot table

2012-12-05T23:30:43+00:00

The state manager no longer needs any special machinery to stop the
session flow and resize the slot table. It is all done on the fly by
the SEQUENCE op code now.

Signed-off-by: Trond Myklebust

NFSv4.1: Allow the server to recall all but one slot

2012-12-05T23:30:42+00:00

If the server wants to leave us with only one slot, or it wants
to "shrink" our slot table to something larger than we have now,
then so be it.

Signed-off-by: Trond Myklebust

NFSv4.1: Don't confuse target_highest_slotid and max_slots in cb_recall_slot

2012-12-05T23:30:41+00:00

Don't confuse the table size and the target_highest_slotid...

Signed-off-by: Trond Myklebust

NFSv4.1: Fix nfs4_callback_recallslot to work with dynamic slot allocation

2012-12-05T23:30:37+00:00

Ensure that the NFSv4.1 CB_RECALL_SLOT callback updates the slot table
target max slotid safely.

Signed-off-by: Trond Myklebust

NFSv4.1: Ensure that the client tracks the server target_highest_slotid

2012-12-05T23:29:47+00:00

Dynamic slot allocation in NFSv4.1 depends on the client being able to
track the server's target value for the highest slotid in the
slot table.  See the reference in Section 2.10.6.1 of RFC5661.

To avoid ordering problems in the case where 2 SEQUENCE replies contain
conflicting updates to this target value, we also introduce a generation
counter, to track whether or not an RPC containing a SEQUENCE operation
was launched before or after the last update.

Also rename the nfs4_slot_table target_max_slots field to
'target_highest_slotid' to avoid confusion with a slot
table size or number of slots.

Signed-off-by: Trond Myklebust

NFSv4: Get rid of unnecessary BUG_ON()s

2012-11-04T19:43:39+00:00

Signed-off-by: Trond Myklebust