linux-stable.git/fs/nfs/callback.c, branch v3.2.78

nfs: don't call blocking operations while !TASK_RUNNING

2015-05-09T22:16:14+00:00

commit 6ffa30d3f734d4f6b478081dfc09592021028f90 upstream.

Bruce reported seeing this warning pop when mounting using v4.1:

     ------------[ cut here ]------------
     WARNING: CPU: 1 PID: 1121 at kernel/sched/core.c:7300 __might_sleep+0xbd/0xd0()
    do not call blocking ops when !TASK_RUNNING; state=1 set at [] prepare_to_wait+0x2f/0x90
    Modules linked in: rpcsec_gss_krb5 auth_rpcgss nfsv4 dns_resolver nfs lockd grace sunrpc fscache ip6t_rpfilter ip6t_REJECT nf_reject_ipv6 xt_conntrack ebtable_nat ebtable_broute bridge stp llc ebtable_filter ebtables ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 ip6table_mangle ip6table_security ip6table_raw ip6table_filter ip6_tables iptable_nat nf_conntrack_ipv4 nf_defrag_ipv4 nf_nat_ipv4 nf_nat nf_conntrack iptable_mangle iptable_security iptable_raw snd_hda_codec_generic snd_hda_intel snd_hda_controller snd_hda_codec snd_hwdep snd_pcm snd_timer ppdev joydev snd virtio_console virtio_balloon pcspkr serio_raw parport_pc parport pvpanic floppy soundcore i2c_piix4 virtio_blk virtio_net qxl drm_kms_helper ttm drm virtio_pci virtio_ring ata_generic virtio pata_acpi
    CPU: 1 PID: 1121 Comm: nfsv4.1-svc Not tainted 3.19.0-rc4+ #25
    Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.7.5-20140709_153950- 04/01/2014
     0000000000000000 000000004e5e3f73 ffff8800b998fb48 ffffffff8186ac78
     0000000000000000 ffff8800b998fba0 ffff8800b998fb88 ffffffff810ac9da
     ffff8800b998fb68 ffffffff81c923e7 00000000000004d9 0000000000000000
    Call Trace:
     [] dump_stack+0x4c/0x65
     [] warn_slowpath_common+0x8a/0xc0
     [] warn_slowpath_fmt+0x55/0x70
     [] ? prepare_to_wait+0x2f/0x90
     [] ? prepare_to_wait+0x2f/0x90
     [] __might_sleep+0xbd/0xd0
     [] kmem_cache_alloc_trace+0x243/0x430
     [] ? groups_alloc+0x3e/0x130
     [] groups_alloc+0x3e/0x130
     [] svcauth_unix_accept+0x16e/0x290 [sunrpc]
     [] svc_authenticate+0xe1/0xf0 [sunrpc]
     [] svc_process_common+0x244/0x6a0 [sunrpc]
     [] bc_svc_process+0x1c4/0x260 [sunrpc]
     [] nfs41_callback_svc+0x128/0x1f0 [nfsv4]
     [] ? wait_woken+0xc0/0xc0
     [] ? nfs4_callback_svc+0x60/0x60 [nfsv4]
     [] kthread+0x11f/0x140
     [] ? local_clock+0x15/0x30
     [] ? kthread_create_on_node+0x250/0x250
     [] ret_from_fork+0x7c/0xb0
     [] ? kthread_create_on_node+0x250/0x250
    ---[ end trace 675220a11e30f4f2 ]---

nfs41_callback_svc does most of its work while in TASK_INTERRUPTIBLE,
which is just wrong. Fix that by finishing the wait immediately if we've
found that the list has something on it.

Also, we don't expect this kthread to accept signals, so we should be
using a TASK_UNINTERRUPTIBLE sleep instead. That however, opens us up
hung task warnings from the watchdog, so have the schedule_timeout
wake up every 60s if there's no callback activity.

Reported-by: "J. Bruce Fields" 
Signed-off-by: Jeff Layton 
Signed-off-by: Trond Myklebust 
[bwh: Backported to 3.2: adjust context]
Signed-off-by: Ben Hutchings

sunrpc: use better NUMA affinities

2011-08-19T17:25:36+00:00

Use NUMA aware allocations to reduce latencies and increase throughput.

sunrpc kthreads can use kthread_create_on_node() if pool_mode is
"percpu" or "pernode", and svc_prepare_thread()/svc_init_buffer() can
also take into account NUMA node affinity for memory allocations.

Signed-off-by: Eric Dumazet 
CC: "J. Bruce Fields" 
CC: Neil Brown 
CC: David Miller 
Reviewed-by: Greg Banks 
[bfields@redhat.com: fix up caller nfs41_callback_up]
Signed-off-by: J. Bruce Fields

NFS do not find client in NFSv4 pg_authenticate

2011-01-25T20:26:51+00:00

The information required to find the nfs_client cooresponding to the incoming
back channel request is contained in the NFS layer. Perform minimal checking
in the RPC layer pg_authenticate method, and push more detailed checking into
the NFS layer where the nfs_client can be found.

Signed-off-by: Andy Adamson 
Signed-off-by: Trond Myklebust

NFS rename client back channel transport field

2011-01-06T19:46:25+00:00

Differentiate from server backchannel

Signed-off-by: Andy Adamson 
Acked-by: Bruce Fields 
Signed-off-by: Trond Myklebust

NFS RPC_AUTH_GSS unsupported on v4.1 back channel

2011-01-06T19:46:24+00:00

Signed-off-by: Andy Adamson 
Acked-by: Bruce Fields 
Signed-off-by: Trond Myklebust

NFS refactor nfs_find_client and reference client across callback processing

2011-01-06T19:46:24+00:00

Fixes a bug where the nfs_client could be freed during callback processing.
Refactor nfs_find_client to use minorversion specific means to locate the
correct nfs_client structure.

In the NFS layer, V4.0 clients are found using the callback_ident field in the
CB_COMPOUND header.  V4.1 clients are found using the sessionID in the
CB_SEQUENCE operation which is also compared against the sessionID associated
with the back channel thread after a successful CREATE_SESSION.

Each of these methods finds the one an only nfs_client associated
with the incoming callback request - so nfs_find_client_next is not needed.

In the RPC layer, the pg_authenticate call needs to find the nfs_client. For
the v4.0 callback service, the callback identifier has not been decoded so a
search by address, version, and minorversion is used.  The sessionid for the
sessions based callback service has (usually) not been set for the
pg_authenticate on a CB_NULL call which can be sent prior to the return
of a CREATE_SESSION call, so the sessionid associated with the back channel
thread is not used to find the client in pg_authenticate for CB_NULL calls.

Pass the referenced nfs_client to each CB_COMPOUND operation being proceesed
via the new cb_process_state structure. The reference is held across
cb_compound processing.

Use the new cb_process_state struct to move the NFS4ERR_RETRY_UNCACHED_REP
processing from process_op into nfs4_callback_sequence where it belongs.

Signed-off-by: Andy Adamson 
Signed-off-by: Trond Myklebust

NFS associate sessionid with callback connection

2011-01-06T19:46:24+00:00

The sessions based callback service is started prior to the CREATE_SESSION call
so that it can handle CB_NULL requests which can be sent before the
CREATE_SESSION call returns and the session ID is known.

Set the callback sessionid after a sucessful CREATE_SESSION.

Signed-off-by: Andy Adamson 
Signed-off-by: Trond Myklebust

NFS use svc_create_xprt for NFSv4.1 callback service

2011-01-06T19:46:24+00:00

The new back channel transport means we call the normal creation routine as
well as svc_xprt_put.

Signed-off-by: Andy Adamson 
Signed-off-by: Trond Myklebust

BKL: remove extraneous #include

2010-11-17T16:59:32+00:00

The big kernel lock has been removed from all these files at some point,
leaving only the #include.

Remove this too as a cleanup.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Linus Torvalds

sunrpc: Add net argument to svc_create_xprt

2010-10-01T21:18:54+00:00

Signed-off-by: Pavel Emelyanov 
Signed-off-by: J. Bruce Fields