linux-stable.git/fs/nfs/callback.c, branch linux-3.7.y

NFSv4: Fix the return value for nfs_callback_start_svc

2012-10-16T17:14:42+00:00

returning PTR_ERR(cb_info->task) just after we have set it to
NULL looks like a typo...

Signed-off-by: Trond Myklebust 
Cc: Stanislav Kinsbursky

Merge branch 'for-3.7' of git://linux-nfs.org/~bfields/linux

2012-10-13T01:53:54+00:00

Pull nfsd update from J Bruce Fields:
 "Another relatively quiet cycle.  There was some progress on my
  remaining 4.1 todo's, but a couple of them were just of the form
  "check that we do X correctly", so didn't have much affect on the
  code.

  Other than that, a bunch of cleanup and some bugfixes (including an
  annoying NFSv4.0 state leak and a busy-loop in the server that could
  cause it to peg the CPU without making progress)."

* 'for-3.7' of git://linux-nfs.org/~bfields/linux: (46 commits)
  UAPI: (Scripted) Disintegrate include/linux/sunrpc
  UAPI: (Scripted) Disintegrate include/linux/nfsd
  nfsd4: don't allow reclaims of expired clients
  nfsd4: remove redundant callback probe
  nfsd4: expire old client earlier
  nfsd4: separate session allocation and initialization
  nfsd4: clean up session allocation
  nfsd4: minor free_session cleanup
  nfsd4: new_conn_from_crses should only allocate
  nfsd4: separate connection allocation and initialization
  nfsd4: reject bad forechannel attrs earlier
  nfsd4: enforce per-client sessions/no-sessions distinction
  nfsd4: set cl_minorversion at create time
  nfsd4: don't pin clientids to pseudoflavors
  nfsd4: fix bind_conn_to_session xdr comment
  nfsd4: cast readlink() bug argument
  NFSD: pass null terminated buf to kstrtouint()
  nfsd: remove duplicate init in nfsd4_cb_recall
  nfsd4: eliminate redundant nfs4_free_stateid
  fs/nfsd/nfs4idmap.c: adjust inconsistent IS_ERR and PTR_ERR
  ...

NFSv4: Fix the minor version callback channel startup

2012-10-01T23:58:39+00:00

The current spaghetti code confuses some versions of gcc (and just
looks ugly as hell)! Clean up...

Signed-off-by: Trond Myklebust

NFS: add debug messages to callback down function

2012-10-01T22:26:06+00:00

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

NFS: callback per-net usage counting introduced

2012-10-01T22:25:57+00:00

This patch also introduces refcount-aware nfs_callback_down_net() wrapper for
svc_shutdown_net().

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

NFS: make nfs_callback_tcpport6 per network context

2012-10-01T22:25:51+00:00

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

NFS: make nfs_callback_tcpport per network context

2012-10-01T22:25:47+00:00

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

NFS: callback up - users counting cleanup

2012-10-01T22:25:38+00:00

Usage coutner now increased only is the service was started sccessfully.
Even if service is running already, then goto is not required anymore, because
service creation and start will be skipped.
With this patch code looks clearer.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

NFS: callback service start function introduced

2012-10-01T22:25:35+00:00

This is just a code move, which from my POW makes code looks better.
I.e. now on start we have 3 different stages:
1) Service creation.
2) Service per-net data allocation.
3) Service start.

Patch also renames goto label "out_err:" into "err_start:" to reflect new
changes.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust

NFS: callback up - transport backchannel cleanup

2012-10-01T22:25:29+00:00

No need to assign transports backchannel server explicitly in
nfs41_callback_up() -  there is nfs_callback_bc_serv() function for this.
By using it, nfs4_callback_up() and nfs41_callback_up() can be called without
transport argument.

Note: service have to be passed to nfs_callback_bc_serv() instead of callback,
since callback link can be uninitialized.

Signed-off-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust