linux-stable.git/fs/lockd, branch linux-5.14.y

NLM: Fix svcxdr_encode_owner()

2021-09-30T08:12:57+00:00

[ Upstream commit 89c485c7a3ecbc2ebd568f9c9c2edf3a8cf7485b ]

Dai Ngo reports that, since the XDR overhaul, the NLM server crashes
when the TEST procedure wants to return NLM_DENIED. There is a bug
in svcxdr_encode_owner() that none of our standard test cases found.

Replace the open-coded function with a call to an appropriate
pre-fabricated XDR helper.

Reported-by: Dai Ngo 
Fixes: a6a63ca5652e ("lockd: Common NLM XDR helpers")
Signed-off-by: Chuck Lever 
Signed-off-by: Sasha Levin

lockd: lockd server-side shouldn't set fl_ops

2021-09-18T11:43:53+00:00

[ Upstream commit 7de875b231edb807387a81cde288aa9e1015ef9e ]

Locks have two sets of op arrays, fl_lmops for the lock manager (lockd
or nfsd), fl_ops for the filesystem.  The server-side lockd code has
been setting its own fl_ops, which leads to confusion (and crashes) in
the reexport case, where the filesystem expects to be the only one
setting fl_ops.

And there's no reason for it that I can see-the lm_get/put_owner ops do
the same job.

Reported-by: Daire Byrne 
Tested-by: Daire Byrne 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Chuck Lever 
Signed-off-by: Sasha Levin

lockd: Fix invalid lockowner cast after vfs_test_lock

2021-09-15T08:02:24+00:00

[ Upstream commit cd2d644ddba183ec7b451b7c20d5c7cc06fcf0d7 ]

After calling vfs_test_lock() the pointer to a conflicting lock can be
returned, and that lock is not guarunteed to be owned by nlm.  In that
case, we cannot cast it to struct nlm_lockowner.  Instead return the pid
of that conflicting lock.

Fixes: 646d73e91b42 ("lockd: Show pid of lockd for remote locks")
Signed-off-by: Benjamin Coddington 
Signed-off-by: Chuck Lever 
Signed-off-by: Sasha Levin

lockd: Update the NLMv4 SHARE results encoder to use struct xdr_stream

2021-07-07T00:14:44+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Update the NLMv4 nlm_res results encoder to use struct xdr_stream

2021-07-07T00:14:44+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Update the NLMv4 TEST results encoder to use struct xdr_stream

2021-07-07T00:14:44+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Update the NLMv4 void results encoder to use struct xdr_stream

2021-07-07T00:14:44+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Update the NLMv4 FREE_ALL arguments decoder to use struct xdr_stream

2021-07-07T00:14:44+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Update the NLMv4 SHARE arguments decoder to use struct xdr_stream

2021-07-07T00:14:44+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Update the NLMv4 SM_NOTIFY arguments decoder to use struct xdr_stream

2021-07-07T00:14:43+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields