linux-stable.git/fs/lockd/mon.c, branch linux-4.3.y

SUNRPC: NULL utsname dereference on NFS umount during namespace cleanup

2015-02-03T21:40:17+00:00

Fix an Oopsable condition when nsm_mon_unmon is called as part of the
namespace cleanup, which now apparently happens after the utsname
has been freed.

Link: http://lkml.kernel.org/r/20150125220604.090121ae@neptune.home
Reported-by: Bruno Prémont 
Cc: stable@vger.kernel.org # 3.18
Signed-off-by: Trond Myklebust

lockd: ratelimit "lockd: cannot monitor" messages

2014-11-06T19:47:33+00:00

When lockd can't talk to a remote statd, it'll spew a warning message
to the ring buffer. If the application is really hammering on locks
however, it's possible for that message to spam the logs. Ratelimit it
to minimize the potential for harm.

Reported-by: Ian Collier 
Signed-off-by: Jeff Layton 
Signed-off-by: J. Bruce Fields

lockd: Try to reconnect if statd has moved

2014-09-25T03:08:43+00:00

If rpc.statd is restarted, upcalls to monitor hosts can fail with
ECONNREFUSED.  In that case force a lookup of statd's new port and retry the
upcall.

Signed-off-by: Benjamin Coddington 
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust

fs: lockd: Use ktime_get_ns()

2014-07-23T22:01:44+00:00

Replace the ever recurring:
        ts = ktime_get_ts();
        ns = timespec_to_ns(&ts);
with
        ns = ktime_get_ns();

Signed-off-by: Thomas Gleixner 
Acked-by: Trond Myklebust 
Cc: "J. Bruce Fields" 
Signed-off-by: John Stultz

sunrpc: move address copy/cmp/convert routines and prototypes from clnt.h to addr.h

2013-02-05T14:41:14+00:00

These routines are used by server and client code, so having them in a
separate header would be best.

Signed-off-by: Jeff Layton 
Acked-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields

lockd: Remove trivial BUG_ON()s from the NSM code

2012-11-04T19:43:39+00:00

Signed-off-by: Trond Myklebust

LOCKD: Clear ln->nsm_clnt only when ln->nsm_users is zero

2012-10-24T14:46:22+00:00

The current code is clearing it in all cases _except_ when zero.

Reported-by: Stanislav Kinsbursky 
Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org

LOCKD: fix races in nsm_client_get

2012-10-24T14:46:22+00:00

Commit e9406db20fecbfcab646bad157b4cfdc7cadddfb (lockd: per-net
NSM client creation and destruction helpers introduced) contains
a nasty race on initialisation of the per-net NSM client because
it doesn't check whether or not the client is set after grabbing
the nsm_create_mutex.

Reported-by: Nix 
Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org

lockd: create and use per-net NSM RPC clients on MON/UNMON requests

2012-10-01T22:27:43+00:00

NSM RPC client can be required on NFSv3 umount, when child reaper is dying
(and destroying it's mount namespace). It means, that current nsproxy is set
to NULL already, but creation of RPC client requires UTS namespace for gaining
hostname string.

This patch creates reference-counted per-net NSM client on first monitor
request and destroys it after last unmonitor request.

Signed-off-by: Stanislav Kinsbursky 
Cc: 
Signed-off-by: Trond Myklebust

lockd: use rpc client's cl_nodename for id encoding

2012-10-01T22:27:38+00:00

Taking hostname from uts namespace if not safe, because this cuold be
performind during umount operation on child reaper death. And in this case
current->nsproxy is NULL already.

Signed-off-by: Stanislav Kinsbursky 
Cc: 
Signed-off-by: Trond Myklebust