linux-stable.git/fs/internal.h, branch v3.8

writeback: put unused inodes to LRU after writeback completion

2012-11-27T01:41:24+00:00

Commit 169ebd90131b ("writeback: Avoid iput() from flusher thread")
removed iget-iput pair from inode writeback.  As a side effect, inodes
that are dirty during iput_final() call won't be ever added to inode LRU
(iput_final() doesn't add dirty inodes to LRU and later when the inode
is cleaned there's noone to add the inode there).  Thus inodes are
effectively unreclaimable until someone looks them up again.

The practical effect of this bug is limited by the fact that inodes are
pinned by a dentry for long enough that the inode gets cleaned.  But
still the bug can have nasty consequences leading up to OOM conditions
under certain circumstances.  Following can easily reproduce the
problem:

  for (( i = 0; i < 1000; i++ )); do
    mkdir $i
    for (( j = 0; j < 1000; j++ )); do
      touch $i/$j
      echo 2 > /proc/sys/vm/drop_caches
    done
  done

then one needs to run 'sync; ls -lR' to make inodes reclaimable again.

We fix the issue by inserting unused clean inodes into the LRU after
writeback finishes in inode_sync_complete().

Signed-off-by: Jan Kara 
Reported-by: OGAWA Hirofumi 
Cc: Al Viro 
Cc: OGAWA Hirofumi 
Cc: Wu Fengguang 
Cc: Dave Chinner 
Cc: 		[3.5+]
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

vfs: make path_openat take a struct filename pointer

2012-10-13T00:15:09+00:00

...and fix up the callers. For do_file_open_root, just declare a
struct filename on the stack and fill out the .name field. For
do_filp_open, make it also take a struct filename pointer, and fix up its
callers to call it appropriately.

For filp_open, add a variant that takes a struct filename pointer and turn
filp_open into a wrapper around it.

Signed-off-by: Jeff Layton 
Signed-off-by: Al Viro

fs: Add freezing handling to mnt_want_write() / mnt_drop_write()

2012-07-31T05:40:38+00:00

Most of places where we want freeze protection coincides with the places where
we also have remount-ro protection. So make mnt_want_write() and
mnt_drop_write() (and their _file alternative) prevent freezing as well.
For the few cases that are really interested only in remount-ro protection
provide new function variants.

BugLink: https://bugs.launchpad.net/bugs/897421
Tested-by: Kamal Mostafa 
Tested-by: Peter M. Petrakis 
Tested-by: Dann Frazier 
Tested-by: Massimo Morana 
Signed-off-by: Jan Kara 
Signed-off-by: Al Viro

VFS: Split inode_permission()

2012-07-14T12:38:36+00:00

Split inode_permission() into inode- and superblock-dependent parts.

This is aimed at unionmounts where the superblock from the upper layer has to
be checked rather than the superblock from the lower layer as the upper layer
may be writable, thus allowing an unwritable file from the lower layer to be
copied up and modified.

Original-author: Valerie Aurora 
Signed-off-by: David Howells  (Further development)
Signed-off-by: Al Viro

kill struct opendata

2012-07-14T12:33:39+00:00

Just pass struct file *.  Methods are happier that way...
There's no need to return struct file * from finish_open() now,
so let it return int.  Next: saner prototypes for parts in
namei.c

Signed-off-by: Al Viro

kill opendata->{mnt,dentry}

2012-07-14T12:33:37+00:00

->filp->f_path is there for purpose...

Signed-off-by: Al Viro

vfs: remove open intents from nameidata

2012-07-14T12:33:18+00:00

All users of open intents have been converted to use ->atomic_{open,create}.

This patch gets rid of nd->intent.open and related infrastructure.

Signed-off-by: Miklos Szeredi 
Signed-off-by: Al Viro

vfs: add i_op->atomic_open()

2012-07-14T12:33:04+00:00

Add a new inode operation which is called on the last component of an open.
Using this the filesystem can look up, possibly create and open the file in one
atomic operation.  If it cannot perform this (e.g. the file type turned out to
be wrong) it may signal this by returning NULL instead of an open struct file
pointer.

i_op->atomic_open() is only called if the last component is negative or needs
lookup.  Handling cached positive dentries here doesn't add much value: these
can be opened using f_op->open().  If the cached file turns out to be invalid,
the open can be retried, this time using ->atomic_open() with a fresh dentry.

For now leave the old way of using open intents in lookup and revalidate in
place.  This will be removed once all the users are converted.

David Howells noticed that if ->atomic_open() opens the file but does not create
it, handle_truncate() will be called on it even if it is not a regular file.
Fix this by checking the file type in this case too.

Signed-off-by: Miklos Szeredi 
Signed-off-by: Al Viro

get rid of ->mnt_longterm

2012-07-14T12:32:47+00:00

it's enough to set ->mnt_ns of internal vfsmounts to something
distinct from all struct mnt_namespace out there; then we can
just use the check for ->mnt_ns != NULL in the fast path of
mntput_no_expire()

Signed-off-by: Al Viro

vfs: split __dentry_open()

2012-06-01T16:12:00+00:00

Split __dentry_open() into two functions:

  do_dentry_open() - does most of the actual work, doesn't put file on failure
  open_check_o_direct() - after a successful open, checks direct_IO method

This will allow i_op->atomic_open to do just the file initialization and leave
the direct_IO checking to the VFS.

Signed-off-by: Miklos Szeredi 
Signed-off-by: Al Viro