linux-stable.git/fs/hfsplus, branch v3.9

hfsplus: fix potential overflow in hfsplus_file_truncate()

2013-04-17T23:10:45+00:00

Change a u32 to loff_t hfsplus_file_truncate().

Signed-off-by: Vyacheslav Dubeyko 
Cc: Christoph Hellwig 
Cc: Al Viro 
Cc: Hin-Tak Leung 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs: Limit sys_mount to only request filesystem modules.

2013-03-04T03:36:31+00:00

Modify the request_module to prefix the file system type with "fs-"
and add aliases to all of the filesystems that can be built as modules
to match.

A common practice is to build all of the kernel code and leave code
that is not commonly needed as modules, with the result that many
users are exposed to any bug anywhere in the kernel.

Looking for filesystems with a fs- prefix limits the pool of possible
modules that can be loaded by mount to just filesystems trivially
making things safer with no real cost.

Using aliases means user space can control the policy of which
filesystem modules are auto-loaded by editing /etc/modprobe.d/*.conf
with blacklist and alias directives.  Allowing simple, safe,
well understood work-arounds to known problematic software.

This also addresses a rare but unfortunate problem where the filesystem
name is not the same as it's module name and module auto-loading
would not work.  While writing this patch I saw a handful of such
cases.  The most significant being autofs that lives in the module
autofs4.

This is relevant to user namespaces because we can reach the request
module in get_fs_type() without having any special permissions, and
people get uncomfortable when a user specified string (in this case
the filesystem type) goes all of the way to request_module.

After having looked at this issue I don't think there is any
particular reason to perform any filtering or permission checks beyond
making it clear in the module request that we want a filesystem
module.  The common pattern in the kernel is to call request_module()
without regards to the users permissions.  In general all a filesystem
module does once loaded is call register_filesystem() and go to sleep.
Which means there is not much attack surface exposed by loading a
filesytem module unless the filesystem is mounted.  In a user
namespace filesystems are not mounted unless .fs_flags = FS_USERNS_MOUNT,
which most filesystems do not set today.

Acked-by: Serge Hallyn 
Acked-by: Kees Cook 
Reported-by: Kees Cook 
Signed-off-by: "Eric W. Biederman"

hfsplus: fix issue with unzeroed unused b-tree nodes

2013-02-28T03:10:10+00:00

The fsck_hfs (under MacOS X) complains about unzeroed unused b-tree nodes
after deletion of folders' tree under Linux.

SYMPTOMS:

  Running Disk Utiltiy's "Verify Disk" on "test" gives the following:
  Verifying volume “Test”
  Checking file systemChecking Journaled HFS Plus volume.
  Checking extents overflow file.
  Checking catalog file.
  Unused node is not erased (node = 3111)
  Checking multi-linked files.
  Checking catalog hierarchy.
  Checking extended attributes file.
  Checking volume bitmap.
  Checking volume information.
  The volume Test was found corrupt and needs to be repaired.
  Error: This disk needs to be repaired. Click Repair Disk.

REPRODUCING PATH:

1. Prepare HFS+ (non-case sensitive) partition (for example, 5GB)
   under MacOS X.
2. Copy linux kernel source tree (for example, 3.7-rc6 version) on
   this partition under MacOS X.
3. Then switch to Linux and mount this prepared partition.
4. Execute `sudo rm -r` under prepared directory with linux kernel
   source tree.
5. Unmount and boot back into OS X.
6. Open up Disk Utility and verify partition.

REPRODUCIBILITY: 100%

FIX:

It is added code of node clearing in hfs_bnode_put() method for the case
when node has flag HFS_BNODE_DELETED.

Signed-off-by: Vyacheslav Dubeyko 
Reported-by: Kyle Laracey 
Acked-by: Hin-Tak Leung 
Cc: Al Viro 
Cc: Christoph Hellwig 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

hfsplus: add support of manipulation by attributes file

2013-02-28T03:10:10+00:00

Add support of manipulation by attributes file.

Signed-off-by: Vyacheslav Dubeyko 
Reported-by: Hin-Tak Leung 
Cc: Al Viro 
Cc: Christoph Hellwig 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

hfsplus: rework functionality of getting, setting and deleting of extended attributes

2013-02-28T03:10:10+00:00

Rework functionality of getting, setting and deleting of extended attributes.

Signed-off-by: Vyacheslav Dubeyko 
Reported-by: Hin-Tak Leung 
Cc: Al Viro 
Cc: Christoph Hellwig 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

hfsplus: add functionality of manipulating by records in attributes tree

2013-02-28T03:10:10+00:00

Add functionality of manipulating by records in attributes tree.

Signed-off-by: Vyacheslav Dubeyko 
Reported-by: Hin-Tak Leung 
Cc: Al Viro 
Cc: Christoph Hellwig 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

hfsplus: add on-disk layout declarations related to attributes tree

2013-02-28T03:10:10+00:00

Add all necessary on-disk layout declarations related to attributes file.

Signed-off-by: Vyacheslav Dubeyko 
Reported-by: Hin-Tak Leung 
Cc: Al Viro 
Cc: Christoph Hellwig 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

new helper: file_inode(file)

2013-02-23T04:31:31+00:00

Signed-off-by: Al Viro

Merge branch 'akpm' (Andrew's patch-bomb)

2012-12-21T04:00:43+00:00

Merge the rest of Andrew's patches for -rc1:
 "A bunch of fixes and misc missed-out-on things.

  That'll do for -rc1.  I still have a batch of IPC patches which still
  have a possible bug report which I'm chasing down."

* emailed patches from Andrew Morton : (25 commits)
  keys: use keyring_alloc() to create module signing keyring
  keys: fix unreachable code
  sendfile: allows bypassing of notifier events
  SGI-XP: handle non-fatal traps
  fat: fix incorrect function comment
  Documentation: ABI: remove testing/sysfs-devices-node
  proc: fix inconsistent lock state
  linux/kernel.h: fix DIV_ROUND_CLOSEST with unsigned divisors
  memcg: don't register hotcpu notifier from ->css_alloc()
  checkpatch: warn on uapi #includes that #include 
  mm: cma: WARN if freed memory is still in use
  exec: do not leave bprm->interp on stack
  ...

hfsplus: add error message for the case of failure of sync fs in delayed_sync_fs() method

2012-12-21T01:40:20+00:00

Add an error message for the case of failure of sync fs in
delayed_sync_fs() method.

Signed-off-by: Vyacheslav Dubeyko 
Cc: Christoph Hellwig 
Cc: Al Viro 
Cc: Hin-Tak Leung 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds