linux-stable.git/fs/gfs2, branch linux-3.10.y

gfs2: avoid uninitialized variable warning

2017-06-20T12:04:50+00:00

commit 67893f12e5374bbcaaffbc6e570acbc2714ea884 upstream.

We get a bogus warning about a potential uninitialized variable
use in gfs2, because the compiler does not figure out that we
never use the leaf number if get_leaf_nr() returns an error:

fs/gfs2/dir.c: In function 'get_first_leaf':
fs/gfs2/dir.c:802:9: warning: 'leaf_no' may be used uninitialized in this function [-Wmaybe-uninitialized]
fs/gfs2/dir.c: In function 'dir_split_leaf':
fs/gfs2/dir.c:1021:8: warning: 'leaf_no' may be used uninitialized in this function [-Wmaybe-uninitialized]

Changing the 'if (!error)' to 'if (!IS_ERR_VALUE(error))' is
sufficient to let gcc understand that this is exactly the same
condition as in IS_ERR() so it can optimize the code path enough
to understand it.

Signed-off-by: Arnd Bergmann 
Signed-off-by: Bob Peterson 
Signed-off-by: Willy Tarreau

posix_acl: Clear SGID bit when setting file permissions

2017-06-07T22:46:47+00:00

commit 073931017b49d9458aa351605b43a7e34598caef upstream.

When file permissions are modified via chmod(2) and the user is not in
the owning group or capable of CAP_FSETID, the setgid bit is cleared in
inode_change_ok().  Setting a POSIX ACL via setxattr(2) sets the file
permissions as well as the new ACL, but doesn't clear the setgid bit in
a similar way; this allows to bypass the check in chmod(2).  Fix that.

Reviewed-by: Christoph Hellwig 
Reviewed-by: Jeff Layton 
Signed-off-by: Jan Kara 
Signed-off-by: Andreas Gruenbacher 
[wt: dropped hfsplus changes : no xattr in 3.10]
Signed-off-by: Willy Tarreau

GFS2: Increase i_writecount during gfs2_setattr_chown

2014-01-25T16:27:11+00:00

commit 62e96cf81988101fe9e086b2877307b6adda5197 upstream.

This patch calls get_write_access in function gfs2_setattr_chown,
which merely increases inode->i_writecount for the duration of the
function. That will ensure that any file closes won't delete the
inode's multi-block reservation while the function is running.
It also ensures that a multi-block reservation exists when needed
for quota change operations during the chown.

Signed-off-by: Bob Peterson 
Signed-off-by: Steven Whitehouse 
Signed-off-by: Greg Kroah-Hartman

GFS2: Fix incorrect invalidation for DIO/buffered I/O

2014-01-09T20:24:24+00:00

commit dfd11184d894cd0a92397b25cac18831a1a6a5bc upstream.

In patch 209806aba9d540dde3db0a5ce72307f85f33468f we allowed
local deferred locks to be granted against a cached exclusive
lock. That opened up a corner case which this patch now
fixes.

The solution to the problem is to check whether we have cached
pages each time we do direct I/O and if so to unmap, flush
and invalidate those pages. Since the glock state machine
normally does that for us, mostly the code will be a no-op.

Signed-off-by: Steven Whitehouse 
Signed-off-by: Greg Kroah-Hartman

GFS2: don't hold s_umount over blkdev_put

2014-01-09T20:24:24+00:00

commit dfe5b9ad83a63180f358b27d1018649a27b394a9 upstream.

This is a GFS2 version of Tejun's patch:
4f331f01b9c43bf001d3ffee578a97a1e0633eac
vfs: don't hold s_umount over close_bdev_exclusive() call

In this case its blkdev_put itself that is the issue and this
patch uses the same solution of dropping and retaking s_umount.

Reported-by: Tejun Heo 
Reported-by: Al Viro 
Signed-off-by: Steven Whitehouse 
Signed-off-by: Greg Kroah-Hartman

GFS2: Don't cache iopen glocks

2013-06-03T15:40:22+00:00

This patch makes GFS2 immediately reclaim/delete all iopen glocks
as soon as they're dequeued. This allows deleters to get an
EXclusive lock on iopen so files are deleted properly instead of
being set as unlinked.

Signed-off-by: Bob Peterson 
Signed-off-by: Steven Whitehouse

GFS2: Fall back to vmalloc if kmalloc fails for dir hash tables

2013-06-03T15:39:44+00:00

This version has one more correction: the vmalloc calls are replaced
by __vmalloc calls to preserve the GFP_NOFS flag.

When GFS2's directory management code allocates buffers for a
directory hash table, if it can't get the memory it needs, it
currently gives a bad return code. Rather than giving an error,
this patch allows it to use virtual memory rather than kernel
memory for the hash table. This should make it possible for
directories to function properly, even when kernel memory becomes
very fragmented.

Signed-off-by: Bob Peterson 
Signed-off-by: Steven Whitehouse

GFS2: Increase i_writecount during gfs2_setattr_size

2013-06-03T15:38:58+00:00

This patch calls get_write_access in a few functions. This
merely increases inode->i_writecount for the duration of the function.
That will ensure that any file closes won't delete the inode's
multi-block reservation while the function is running.

Signed-off-by: Bob Peterson 
Signed-off-by: Steven Whitehouse

GFS2: Set log descriptor type for jdata blocks

2013-06-03T15:38:39+00:00

This patch sets the log descriptor type according to whether the
journal commit is for (journaled) data or metadata. This was
recently broken when the functions to process data and metadata
log ops were combined.

Signed-off-by: Bob Peterson 
Signed-off-by: Steven Whitehouse

GFS2: Fix typo in gfs2_log_end_write loop

2013-05-24T12:48:09+00:00

There was a missing _all in this loop iterator

Signed-off-by: Steven Whitehouse