linux-stable.git/fs/f2fs, branch v4.6.2

f2fs: fix deadlock when flush inline data

2016-06-08T01:23:32+00:00

commit ab47036d8f7227361cad7894adee8e66ab6f95b2 upstream.

Below backtrace info was reported by Yunlei He:

Call Trace:
 [] schedule+0x35/0x80
 [] rwsem_down_read_failed+0xed/0x130
 [] call_rwsem_down_read_failed+0x18/0x
 [] down_read+0x20/0x30
 [] f2fs_evict_inode+0x242/0x3a0 [f2fs]
 [] evict+0xc7/0x1a0
 [] iput+0x196/0x200
 [] __dentry_kill+0x179/0x1e0
 [] dput+0x199/0x1f0
 [] __fput+0x18b/0x220
 [] ____fput+0xe/0x10
 [] task_work_run+0x77/0x90
 [] exit_to_usermode_loop+0x73/0xa2
 [] do_syscall_64+0xfa/0x110
 [] entry_SYSCALL64_slow_path+0x25/0x25

Call Trace:
 [] schedule+0x35/0x80
 [] __wait_on_freeing_inode+0xa3/0xd0
 [] ? autoremove_wake_function+0x40/0x4
 [] find_inode_fast+0x7d/0xb0
 [] ilookup+0x6a/0xd0
 [] sync_node_pages+0x210/0x650 [f2fs]
 [] ? do_fsync+0x70/0x70
 [] block_operations+0x9e/0xf0 [f2fs]
 [] ? bio_endio+0x55/0x60
 [] write_checkpoint+0x92/0xba0 [f2fs]
 [] ? mempool_free_slab+0x17/0x20
 [] ? mempool_free+0x2b/0x80
 [] ? do_fsync+0x70/0x70
 [] f2fs_sync_fs+0x63/0xd0 [f2fs]
 [] ? ext4_sync_fs+0xbf/0x190
 [] sync_fs_one_sb+0x20/0x30
 [] iterate_supers+0xb9/0x110
 [] sys_sync+0x55/0x90
 [] do_syscall_64+0x69/0x110
 [] entry_SYSCALL64_slow_path+0x25/0x25

With following excuting serials, we will set inline_node in inode page
after inode was unlinked, result in a deadloop described as below:
1. open file
2. write file
3. unlink file
4. write file
5. close file

Thread A				Thread B
 - dput
  - iput_final
   - inode->i_state |= I_FREEING
   - evict
    - f2fs_evict_inode
					 - f2fs_sync_fs
					  - write_checkpoint
					   - block_operations
					    - f2fs_lock_all (down_write(cp_rwsem))
     - f2fs_lock_op (down_read(cp_rwsem))
					    - sync_node_pages
					     - ilookup
					      - find_inode_fast
					       - __wait_on_freeing_inode
					         (wait on I_FREEING clear)

Here, we change to set inline_node flag only for linked inode for fixing.

Reported-by: Yunlei He 
Signed-off-by: Chao Yu 
Tested-by: Jaegeuk Kim 
Signed-off-by: Jaegeuk Kim 
Signed-off-by: Greg Kroah-Hartman

fscrypto/f2fs: allow fs-specific key prefix for fs encryption

2016-06-01T19:17:59+00:00

commit b5a7aef1ef436ec005fef0efe31a676ec5f4ab31 upstream.

This patch allows fscrypto to handle a second key prefix given by filesystem.
The main reason is to provide backward compatibility, since previously f2fs
used "f2fs:" as a crypto prefix instead of "fscrypt:".
Later, ext4 should also provide key_prefix() to give "ext4:".

One concern decribed by Ted would be kinda double check overhead of prefixes.
In x86, for example, validate_user_key consumes 8 ms after boot-up, which turns
out derive_key_aes() consumed most of the time to load specific crypto module.
After such the cold miss, it shows almost zero latencies, which treats as a
negligible overhead.
Note that request_key() detects wrong prefix in prior to derive_key_aes() even.

Cc: Ted Tso 
Signed-off-by: Jaegeuk Kim 
Signed-off-by: Greg Kroah-Hartman

fscrypto: don't let data integrity writebacks fail with ENOMEM

2016-04-12T17:25:30+00:00

This patch fixes the issue introduced by the ext4 crypto fix in a same manner.
For F2FS, however, we flush the pending IOs and wait for a while to acquire free
memory.

Fixes: c9af28fdd4492 ("ext4 crypto: don't let data integrity writebacks fail with ENOMEM")
Cc: Theodore Ts'o 
Signed-off-by: Jaegeuk Kim

f2fs: use dget_parent and file_dentry in f2fs_file_open

2016-04-12T17:24:22+00:00

This patch synced with the below two ext4 crypto fixes together.

In 4.6-rc1, f2fs newly introduced accessing f_path.dentry which crashes
overlayfs. To fix, now we need to use file_dentry() to access that field.

Fixes: c0a37d487884 ("ext4: use file_dentry()")
Fixes: 9dd78d8c9a7b ("ext4: use dget_parent() in ext4_file_open()")
Cc: Miklos Szeredi 
Cc: Theodore Ts'o 
Signed-off-by: Jaegeuk Kim

Merge tag 'f2fs-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs

2016-04-04T20:00:39+00:00

Pull f2fs fixes from Jaegeuk Kim.

* tag 'f2fs-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs:
  f2fs: retrieve IO write stat from the right place
  f2fs crypto: fix corrupted symlink in encrypted case
  f2fs: cover large section in sanity check of super

mm, fs: get rid of PAGE_CACHE_* and page_cache_{get,release} macros

2016-04-04T17:41:08+00:00

PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} macros were introduced *long* time
ago with promise that one day it will be possible to implement page
cache with bigger chunks than PAGE_SIZE.

This promise never materialized.  And unlikely will.

We have many places where PAGE_CACHE_SIZE assumed to be equal to
PAGE_SIZE.  And it's constant source of confusion on whether
PAGE_CACHE_* or PAGE_* constant should be used in a particular case,
especially on the border between fs and mm.

Global switching to PAGE_CACHE_SIZE != PAGE_SIZE would cause to much
breakage to be doable.

Let's stop pretending that pages in page cache are special.  They are
not.

The changes are pretty straight-forward:

 -  << (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> ;

 -  >> (PAGE_CACHE_SHIFT - PAGE_SHIFT) -> ;

 - PAGE_CACHE_{SIZE,SHIFT,MASK,ALIGN} -> PAGE_{SIZE,SHIFT,MASK,ALIGN};

 - page_cache_get() -> get_page();

 - page_cache_release() -> put_page();

This patch contains automated changes generated with coccinelle using
script below.  For some reason, coccinelle doesn't patch header files.
I've called spatch for them manually.

The only adjustment after coccinelle is revert of changes to
PAGE_CAHCE_ALIGN definition: we are going to drop it later.

There are few places in the code where coccinelle didn't reach.  I'll
fix them manually in a separate patch.  Comments and documentation also
will be addressed with the separate patch.

virtual patch

@@
expression E;
@@
- E << (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E

@@
expression E;
@@
- E >> (PAGE_CACHE_SHIFT - PAGE_SHIFT)
+ E

@@
@@
- PAGE_CACHE_SHIFT
+ PAGE_SHIFT

@@
@@
- PAGE_CACHE_SIZE
+ PAGE_SIZE

@@
@@
- PAGE_CACHE_MASK
+ PAGE_MASK

@@
expression E;
@@
- PAGE_CACHE_ALIGN(E)
+ PAGE_ALIGN(E)

@@
expression E;
@@
- page_cache_get(E)
+ get_page(E)

@@
expression E;
@@
- page_cache_release(E)
+ put_page(E)

Signed-off-by: Kirill A. Shutemov 
Acked-by: Michal Hocko 
Signed-off-by: Linus Torvalds

f2fs: retrieve IO write stat from the right place

2016-03-30T20:21:16+00:00

In the following patch,

    f2fs: split journal cache from curseg cache

journal cache is split from curseg cache. So IO write statistics should be
retrived from journal cache but not curseg->sum_blk. Otherwise, it will
get 0, and the stat is lost.

Signed-off-by: Shuoran Liu 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs crypto: fix corrupted symlink in encrypted case

2016-03-30T20:21:15+00:00

In the encrypted symlink case, we should check its corrupted symname after
decrypting it.
Otherwise, we can report -ENOENT incorrectly, if encrypted symname starts with
'\0'.

Cc: stable 4.5+ 
Signed-off-by: Jaegeuk Kim

f2fs: cover large section in sanity check of super

2016-03-28T17:43:01+00:00

This patch fixes the bug which does not cover a large section case when checking
the sanity of superblock.
If f2fs detects misalignment, it will fix the superblock during the mount time,
so it doesn't need to trigger fsck.f2fs further.

Reported-by: Matthias Prager 
Reported-by: David Gnedt 
Cc: stable 4.5+ 
Signed-off-by: Jaegeuk Kim

f2fs: submit node page write bios when really required

2016-03-18T04:19:47+00:00

If many threads calls fsync with data writes, we don't need to flush every
bios having node page writes.
The f2fs_wait_on_page_writeback will flush its bios when the page is really
needed.

Signed-off-by: Jaegeuk Kim