linux-stable.git/fs/f2fs/data.c, branch v6.9

f2fs: unify the error handling of f2fs_is_valid_blkaddr

2024-03-13T01:25:17+00:00

There are some cases of f2fs_is_valid_blkaddr not handled as
ERROR_INVALID_BLKADDR,so unify the error handling about all of
f2fs_is_valid_blkaddr.
Do f2fs_handle_error in __f2fs_is_valid_blkaddr for cleanup.

Signed-off-by: Zhiguo Niu 
Signed-off-by: Chao Yu 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: relocate f2fs_precache_extents() in f2fs_swap_activate()

2024-03-04T17:51:52+00:00

This patch exchangs position of f2fs_precache_extents() and
filemap_fdatawrite(), so that f2fs_precache_extents() can load
extent info after physical addresses of all data are fixed.

Signed-off-by: Chao Yu 
Reviewed-by: Daeho Jeong 
Signed-off-by: Jaegeuk Kim

f2fs: fix blkofs_end correctly in f2fs_migrate_blocks()

2024-03-04T17:51:52+00:00

In f2fs_migrate_blocks(), when traversing blocks in last section,
blkofs_end should be (start_blk + blkcnt - 1) % blk_per_sec, fix it.

Signed-off-by: Chao Yu 
Reviewed-by: Daeho Jeong 
Signed-off-by: Jaegeuk Kim

f2fs: fix to handle segment allocation failure correctly

2024-02-29T16:34:34+00:00

If CONFIG_F2FS_CHECK_FS is off, and for very rare corner case that
we run out of free segment, we should not panic kernel, instead,
let's handle such error correctly in its caller.

Signed-off-by: Chao Yu 
Tested-by: Zhiguo Niu 
Signed-off-by: Jaegeuk Kim

f2fs: support file pinning for zoned devices

2024-02-27T17:41:15+00:00

Support file pinning with conventional storage area for zoned devices

Signed-off-by: Daeho Jeong 
Signed-off-by: Jaegeuk Kim

f2fs: deprecate io_bits

2024-02-20T19:08:57+00:00

Let's deprecate an unused io_bits feature to save CPU cycles and memory.

Reviewed-by: Daeho Jeong 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix NULL pointer dereference in f2fs_submit_page_write()

2024-02-06T02:58:40+00:00

BUG: kernel NULL pointer dereference, address: 0000000000000014
RIP: 0010:f2fs_submit_page_write+0x6cf/0x780 [f2fs]
Call Trace:

? show_regs+0x6e/0x80
? __die+0x29/0x70
? page_fault_oops+0x154/0x4a0
? prb_read_valid+0x20/0x30
? __irq_work_queue_local+0x39/0xd0
? irq_work_queue+0x36/0x70
? do_user_addr_fault+0x314/0x6c0
? exc_page_fault+0x7d/0x190
? asm_exc_page_fault+0x2b/0x30
? f2fs_submit_page_write+0x6cf/0x780 [f2fs]
? f2fs_submit_page_write+0x736/0x780 [f2fs]
do_write_page+0x50/0x170 [f2fs]
f2fs_outplace_write_data+0x61/0xb0 [f2fs]
f2fs_do_write_data_page+0x3f8/0x660 [f2fs]
f2fs_write_single_data_page+0x5bb/0x7a0 [f2fs]
f2fs_write_cache_pages+0x3da/0xbe0 [f2fs]
...
It is possible that other threads have added this fio to io->bio
and submitted the io->bio before entering f2fs_submit_page_write().
At this point io->bio = NULL.
If is_end_zone_blkaddr(sbi, fio->new_blkaddr) of this fio is true,
then an NULL pointer dereference error occurs at bio_get(io->bio).
The original code for determining zone end was after "out:",
which would have missed some fio who is zone end. I've moved
 this code before "skip:" to make sure it's done for each fio.

Fixes: e067dc3c6b9c ("f2fs: maintain six open zones for zoned devices")
Signed-off-by: Wenjie Qi 
Reviewed-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: zone: fix to wait completion of last bio in zone correctly

2024-02-06T02:58:40+00:00

It needs to check last zone_pending_bio and wait IO completion before
traverse next fio in io->io_list, otherwise, bio in next zone may be
submitted before all IO completion in current zone.

Fixes: e067dc3c6b9c ("f2fs: maintain six open zones for zoned devices")
Cc: Daeho Jeong 
Signed-off-by: Chao Yu 
Reviewed-by: Daeho Jeong 
Signed-off-by: Jaegeuk Kim

f2fs: compress: fix to avoid inconsistence bewteen i_blocks and dnode

2024-02-06T02:58:39+00:00

In reserve_compress_blocks(), we update blkaddrs of dnode in prior to
inc_valid_block_count(), it may cause inconsistent status bewteen
i_blocks and blkaddrs once inc_valid_block_count() fails.

To fix this issue, it needs to reverse their invoking order.

Fixes: c75488fb4d82 ("f2fs: introduce F2FS_IOC_RESERVE_COMPRESS_BLOCKS")
Reviewed-by: Daeho Jeong 
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: compress: fix to cover normal cluster write with cp_rwsem

2024-02-06T02:58:38+00:00

When we overwrite compressed cluster w/ normal cluster, we should
not unlock cp_rwsem during f2fs_write_raw_pages(), otherwise data
will be corrupted if partial blocks were persisted before CP & SPOR,
due to cluster metadata wasn't updated atomically.

Fixes: 4c8ff7095bef ("f2fs: support data compression")
Reviewed-by: Daeho Jeong 
Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim