linux-stable.git/fs/f2fs/data.c, branch v4.7

Merge tag 'for-f2fs-4.7' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs

2016-05-22T01:25:28+00:00

Pull f2fs updates from Jaegeuk Kim:
 "In this round, as Ted pointed out, fscrypto allows one more key prefix
  given by filesystem to resolve backward compatibility issues.  Other
  than that, we've fixed several error handling cases by introducing
  a fault injection facility.  We've also achieved performance
  improvement in some workloads as well as a bunch of bug fixes.

  Summary:

  Enhancements:
   - fs-specific prefix for fscrypto
   - fault injection facility
   - expose validity bitmaps for user to be aware of fragmentation
   - fallocate/rm/preallocation speed up
   - use percpu counters

  Bug fixes:
   - some inline_dentry/inline_data bugs
   - error handling for atomic/volatile/orphan inodes
   - recover broken superblock"

* tag 'for-f2fs-4.7' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs: (73 commits)
  f2fs: fix to update dirty page count correctly
  f2fs: flush pending bios right away when error occurs
  f2fs: avoid ENOSPC fault in the recovery process
  f2fs: make exit_f2fs_fs more clear
  f2fs: use percpu_counter for total_valid_inode_count
  f2fs: use percpu_counter for alloc_valid_block_count
  f2fs: use percpu_counter for # of dirty pages in inode
  f2fs: use percpu_counter for page counters
  f2fs: use bio count instead of F2FS_WRITEBACK page count
  f2fs: manipulate dirty file inodes when DATA_FLUSH is set
  f2fs: add fault injection to sysfs
  f2fs: no need inc dirty pages under inode lock
  f2fs: fix incorrect error path handling in f2fs_move_rehashed_dirents
  f2fs: fix i_current_depth during inline dentry conversion
  f2fs: correct return value type of f2fs_fill_super
  f2fs: fix deadlock when flush inline data
  f2fs: avoid f2fs_bug_on during recovery
  f2fs: show # of orphan inodes
  f2fs: support in batch fzero in dnode page
  f2fs: support in batch multi blocks preallocation
  ...

f2fs: flush pending bios right away when error occurs

2016-05-20T18:46:15+00:00

Given errors, this patch flushes pending bios as soon as possible.

Signed-off-by: Jaegeuk Kim

f2fs: use bio count instead of F2FS_WRITEBACK page count

2016-05-18T20:57:25+00:00

This can reduce page counting overhead.

Signed-off-by: Jaegeuk Kim

Merge branch 'work.preadv2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2016-05-17T22:05:23+00:00

Pull vfs cleanups from Al Viro:
 "More cleanups from Christoph"

* 'work.preadv2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
  nfsd: use RWF_SYNC
  fs: add RWF_DSYNC aand RWF_SYNC
  ceph: use generic_write_sync
  fs: simplify the generic_write_sync prototype
  fs: add IOCB_SYNC and IOCB_DSYNC
  direct-io: remove the offset argument to dio_complete
  direct-io: eliminate the offset argument to ->direct_IO
  xfs: eliminate the pos variable in xfs_file_dio_aio_write
  filemap: remove the pos argument to generic_file_direct_write
  filemap: remove pos variables in generic_file_read_iter

f2fs: fix deadlock when flush inline data

2016-05-11T16:56:38+00:00

Below backtrace info was reported by Yunlei He:

Call Trace:
 [] schedule+0x35/0x80
 [] rwsem_down_read_failed+0xed/0x130
 [] call_rwsem_down_read_failed+0x18/0x
 [] down_read+0x20/0x30
 [] f2fs_evict_inode+0x242/0x3a0 [f2fs]
 [] evict+0xc7/0x1a0
 [] iput+0x196/0x200
 [] __dentry_kill+0x179/0x1e0
 [] dput+0x199/0x1f0
 [] __fput+0x18b/0x220
 [] ____fput+0xe/0x10
 [] task_work_run+0x77/0x90
 [] exit_to_usermode_loop+0x73/0xa2
 [] do_syscall_64+0xfa/0x110
 [] entry_SYSCALL64_slow_path+0x25/0x25

Call Trace:
 [] schedule+0x35/0x80
 [] __wait_on_freeing_inode+0xa3/0xd0
 [] ? autoremove_wake_function+0x40/0x4
 [] find_inode_fast+0x7d/0xb0
 [] ilookup+0x6a/0xd0
 [] sync_node_pages+0x210/0x650 [f2fs]
 [] ? do_fsync+0x70/0x70
 [] block_operations+0x9e/0xf0 [f2fs]
 [] ? bio_endio+0x55/0x60
 [] write_checkpoint+0x92/0xba0 [f2fs]
 [] ? mempool_free_slab+0x17/0x20
 [] ? mempool_free+0x2b/0x80
 [] ? do_fsync+0x70/0x70
 [] f2fs_sync_fs+0x63/0xd0 [f2fs]
 [] ? ext4_sync_fs+0xbf/0x190
 [] sync_fs_one_sb+0x20/0x30
 [] iterate_supers+0xb9/0x110
 [] sys_sync+0x55/0x90
 [] do_syscall_64+0x69/0x110
 [] entry_SYSCALL64_slow_path+0x25/0x25

With following excuting serials, we will set inline_node in inode page
after inode was unlinked, result in a deadloop described as below:
1. open file
2. write file
3. unlink file
4. write file
5. close file

Thread A				Thread B
 - dput
  - iput_final
   - inode->i_state |= I_FREEING
   - evict
    - f2fs_evict_inode
					 - f2fs_sync_fs
					  - write_checkpoint
					   - block_operations
					    - f2fs_lock_all (down_write(cp_rwsem))
     - f2fs_lock_op (down_read(cp_rwsem))
					    - sync_node_pages
					     - ilookup
					      - find_inode_fast
					       - __wait_on_freeing_inode
					         (wait on I_FREEING clear)

Here, we change to set inline_node flag only for linked inode for fixing.

Reported-by: Yunlei He 
Signed-off-by: Chao Yu 
Tested-by: Jaegeuk Kim 
Cc: stable@vger.kernel.org # v4.6
Signed-off-by: Jaegeuk Kim

f2fs: support in batch multi blocks preallocation

2016-05-11T16:56:35+00:00

This patch introduces reserve_new_blocks to make preallocation of multi
blocks as in batch operation, so it can avoid lots of redundant
operation, result in better performance.

In virtual machine, with rotational device:

time fallocate -l 32G /mnt/f2fs/file

Before:
real	0m4.584s
user	0m0.000s
sys	0m4.580s

After:
real	0m0.292s
user	0m0.000s
sys	0m0.272s

In x86, with SSD:

time fallocate -l 500G $MNT/testfile

Before : 24.758 s
After  :  1.604 s

Signed-off-by: Chao Yu 
[Jaegeuk Kim: fix bugs and add performance numbers measured in x86.]
Signed-off-by: Jaegeuk Kim

f2fs: do not preallocate block unaligned to 4KB

2016-05-07T17:44:57+00:00

Previously f2fs_preallocate_blocks() tries to allocate unaligned blocks.
In f2fs_write_begin(), however, prepare_write_begin() does not skip its
allocation due to (len != 4KB).
So, it needs locking node page twice unexpectedly.

Signed-off-by: Jaegeuk Kim

f2fs: fix incorrect mapping in ->bmap

2016-05-07T17:32:32+00:00

Currently, generic_block_bmap is used in f2fs_bmap, its semantics is when
the mapping is been found, return position of target physical block,
otherwise return zero.

But, previously, when there is no mapping info for specified logical block,
f2fs_bmap will map target physical block to a uninitialized variable, which
should be wrong. Fix it.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

f2fs: fix to clear private data in page

2016-05-03T18:20:05+00:00

Private data in page should be removed during ->releasepage or
->invalidatepage, otherwise garbage data would be remained in that page.

Signed-off-by: Chao Yu 
Signed-off-by: Jaegeuk Kim

direct-io: eliminate the offset argument to ->direct_IO

2016-05-01T23:58:39+00:00

Including blkdev_direct_IO and dax_do_io.  It has to be ki_pos to actually
work, so eliminate the superflous argument.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro