linux-stable.git/fs/ext4, branch v4.4.166

ext4: fix buffer leak in __ext4_read_dirblock() on error path

2018-11-21T08:27:44+00:00

commit de59fae0043f07de5d25e02ca360f7d57bfa5866 upstream.

Fixes: dc6982ff4db1 ("ext4: refactor code to read directory blocks ...")
Signed-off-by: Vasily Averin 
Signed-off-by: Theodore Ts'o 
Cc: stable@kernel.org # 3.9
Signed-off-by: Greg Kroah-Hartman

ext4: fix buffer leak in ext4_xattr_move_to_block() on error path

2018-11-21T08:27:43+00:00

commit 6bdc9977fcdedf47118d2caf7270a19f4b6d8a8f upstream.

Fixes: 3f2571c1f91f ("ext4: factor out xattr moving")
Fixes: 6dd4ee7cab7e ("ext4: Expand extra_inodes space per ...")
Reviewed-by: Jan Kara 
Signed-off-by: Vasily Averin 
Signed-off-by: Theodore Ts'o 
Cc: stable@kernel.org # 2.6.23
Signed-off-by: Greg Kroah-Hartman

ext4: release bs.bh before re-using in ext4_xattr_block_find()

2018-11-21T08:27:43+00:00

commit 45ae932d246f721e6584430017176cbcadfde610 upstream.

bs.bh was taken in previous ext4_xattr_block_find() call,
it should be released before re-using

Fixes: 7e01c8e5420b ("ext3/4: fix uninitialized bs in ...")
Signed-off-by: Vasily Averin 
Signed-off-by: Theodore Ts'o 
Cc: stable@kernel.org # 2.6.26
Signed-off-by: Greg Kroah-Hartman

ext4: fix possible leak of sbi->s_group_desc_leak in error path

2018-11-21T08:27:43+00:00

commit 9e463084cdb22e0b56b2dfbc50461020409a5fd3 upstream.

Fixes: bfe0a5f47ada ("ext4: add more mount time checks of the superblock")
Reported-by: Vasily Averin 
Signed-off-by: Theodore Ts'o 
Cc: stable@kernel.org # 4.18
Signed-off-by: Greg Kroah-Hartman

ext4: avoid possible double brelse() in add_new_gdb() on error path

2018-11-21T08:27:43+00:00

commit 4f32c38b4662312dd3c5f113d8bdd459887fb773 upstream.

Fixes: b40971426a83 ("ext4: add error checking to calls to ...")
Reported-by: Vasily Averin 
Signed-off-by: Theodore Ts'o 
Cc: stable@kernel.org # 2.6.38
Signed-off-by: Greg Kroah-Hartman

ext4: fix missing cleanup if ext4_alloc_flex_bg_array() fails while resizing

2018-11-21T08:27:43+00:00

commit f348e2241fb73515d65b5d77dd9c174128a7fbf2 upstream.

Fixes: 117fff10d7f1 ("ext4: grow the s_flex_groups array as needed ...")
Signed-off-by: Vasily Averin 
Signed-off-by: Theodore Ts'o 
Cc: stable@kernel.org # 3.7
Signed-off-by: Greg Kroah-Hartman

ext4: avoid buffer leak in ext4_orphan_add() after prior errors

2018-11-21T08:27:43+00:00

commit feaf264ce7f8d54582e2f66eb82dd9dd124c94f3 upstream.

Fixes: d745a8c20c1f ("ext4: reduce contention on s_orphan_lock")
Fixes: 6e3617e579e0 ("ext4: Handle non empty on-disk orphan link")
Cc: Dmitry Monakhov 
Signed-off-by: Vasily Averin 
Signed-off-by: Theodore Ts'o 
Cc: stable@kernel.org # 2.6.34
Signed-off-by: Greg Kroah-Hartman

ext4: fix possible inode leak in the retry loop of ext4_resize_fs()

2018-11-21T08:27:43+00:00

commit db6aee62406d9fbb53315fcddd81f1dc271d49fa upstream.

Fixes: 1c6bd7173d66 ("ext4: convert file system to meta_bg if needed ...")
Signed-off-by: Vasily Averin 
Signed-off-by: Theodore Ts'o 
Cc: stable@kernel.org # 3.7
Signed-off-by: Greg Kroah-Hartman

ext4: avoid potential extra brelse in setup_new_flex_group_blocks()

2018-11-21T08:27:43+00:00

commit 9e4028935cca3f9ef9b6a90df9da6f1f94853536 upstream.

Currently bh is set to NULL only during first iteration of for cycle,
then this pointer is not cleared after end of using.
Therefore rollback after errors can lead to extra brelse(bh) call,
decrements bh counter and later trigger an unexpected warning in __brelse()

Patch moves brelse() calls in body of cycle to exclude requirement of
brelse() call in rollback.

Fixes: 33afdcc5402d ("ext4: add a function which sets up group blocks ...")
Signed-off-by: Vasily Averin 
Signed-off-by: Theodore Ts'o 
Cc: stable@kernel.org # 3.3+
Signed-off-by: Greg Kroah-Hartman

ext4: add missing brelse() add_new_gdb_meta_bg()'s error path

2018-11-21T08:27:43+00:00

commit 61a9c11e5e7a0dab5381afa5d9d4dd5ebf18f7a0 upstream.

Fixes: 01f795f9e0d6 ("ext4: add online resizing support for meta_bg ...")
Signed-off-by: Vasily Averin 
Signed-off-by: Theodore Ts'o 
Cc: stable@kernel.org # 3.7
Signed-off-by: Greg Kroah-Hartman