linux-stable.git/fs/ext4, branch linux-2.6.26.y

ext[234]: Avoid printk floods in the face of directory corruption (CVE-2008-3528)

2008-11-10T19:17:52+00:00

This is a trivial backport of the following upstream commits:

- bd39597cbd42a784105a04010100e27267481c67 (ext2)
- cdbf6dba28e8e6268c8420857696309470009fd9 (ext3)
- 9d9f177572d9e4eba0f2e18523b44f90dd51fe74 (ext4)

This addresses CVE-2008-3528

ext[234]: Avoid printk floods in the face of directory corruption

Note: some people thinks this represents a security bug, since it
might make the system go away while it is printing a large number of
console messages, especially if a serial console is involved.  Hence,
it has been assigned CVE-2008-3528, but it requires that the attacker
either has physical access to your machine to insert a USB disk with a
corrupted filesystem image (at which point why not just hit the power
button), or is otherwise able to convince the system administrator to
mount an arbitrary filesystem image (at which point why not just
include a setuid shell or world-writable hard disk device file or some
such).  Me, I think they're just being silly. --tytso

Signed-off-by: Eric Sandeen 
Signed-off-by: "Theodore Ts'o" 
Cc: linux-ext4@vger.kernel.org
Cc: Eugene Teo 
Signed-off-by: Greg Kroah-Hartman

ext4: add missing unlock to an error path in ext4_quota_write()

2008-07-04T17:40:05+00:00

When write in ext4_quota_write() fails, we have to properly release
i_mutex.  One error path has been missing the unlock...

Signed-off-by: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Ext4: Fix online resize block group descriptor corruption

2008-06-20T15:48:48+00:00

This is the patch for the group descriptor table corruption during
online resize pointed out by Theodore Tso.  The problem was caused by
the fact that the ext4 group descriptor can be either 32 or 64 bytes
long.  Only the 64 bytes structure was taken into account.

Signed-off-by: Frederic Bohe 
Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

ext4: enable barriers by default

2008-05-26T16:29:46+00:00

I can't think of any valid reason for ext4 to not use barriers when
they are available;  I believe this is necessary for filesystem
integrity in the face of a volatile write cache on storage.

An administrator who trusts that the cache is sufficiently battery-
backed (and power supplies are sufficiently redundant, etc...)
can always turn it back off again.

SuSE has carried such a patch for ext3 for quite some time now.

Also document the mount option while we're at it.

Signed-off-by: Eric Sandeen 
Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

ext4: Display the journal_async_commit mount option in /proc/mounts

2008-05-26T14:28:28+00:00

Cc: Andreas Dilger 
Cc: Girish Shilamkar 
Signed-off-by: "Theodore Ts'o"

jbd2: If a journal checksum error is detected, propagate the error to ext4

2008-06-06T21:50:40+00:00

If a journal checksum error is detected, the ext4 filesystem will call
ext4_error(), and the mount will either continue, become a read-only
mount, or cause a kernel panic based on the superblock flags
indicating the user's preference of what to do in case of filesystem
corruption being detected.

Signed-off-by: "Theodore Ts'o"

ext4: fix online resize bug

2008-06-06T22:05:52+00:00

There is a bug when we are trying to verify that the reserve inode's
double indirect blocks point back to the primary gdt blocks.  The fix is
obvious, we need to mod the gdb count by the addr's per block.  This was
verified using the same testcase as with the ext3 equivalent of this
patch.

Signed-off-by: Josef Bacik 
Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

ext4: Fix uninit block group initialization with FLEX_BG

2008-06-03T18:07:29+00:00

With FLEX_BG block bitmaps, inode bitmaps and inode tables _MAY_ be
allocated outside the group.  So, when initializing an uninitialized
block bitmap, we need to check the location of this blocks before
setting the corresponding bits in the block bitmap of the newly
initialized group.  Also return the right number of free blocks when
counting the available free blocks in uninit group.

Tested-by: Aneesh Kumar K.V 
Signed-off-by: Jose R. Santos 
Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

ext4: Fix use of uninitialized data with debug enabled.

2008-06-06T00:59:29+00:00

Fix use of uninitialized data with debug enabled.

Signed-off-by: Aneesh Kumar K.V 
Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

ext4: Retry block allocation if new blocks are allocated from system zone.

2008-05-15T18:43:20+00:00

If the block allocator gets blocks out of system zone ext4 calls
ext4_error. But if the file system is mounted with errors=continue
retry block allocation. We need to mark the system zone blocks as
in use to make sure retry don't pick them again

System zone is the block range mapping block bitmap, inode bitmap and inode
table.

Signed-off-by: Aneesh Kumar K.V 
Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"