linux-stable.git/fs/ext4/ioctl.c, branch linux-3.17.y

ext4: Replace open coded mdata csum feature to helper function

2014-11-14T18:10:30+00:00

commit 9aa5d32ba269bec0e7eaba2697a986a7b0bc8528 upstream.

Besides the fact that this replacement improves code readability
it also protects from errors caused direct EXT4_S(sb)->s_es manipulation
which may result attempt to use uninitialized  csum machinery.

#Testcase_BEGIN
IMG=/dev/ram0
MNT=/mnt
mkfs.ext4 $IMG
mount $IMG $MNT
#Enable feature directly on disk, on mounted fs
tune2fs -O metadata_csum  $IMG
# Provoke metadata update, likey result in OOPS
touch $MNT/test
umount $MNT
#Testcase_END

# Replacement script
@@
expression E;
@@
- EXT4_HAS_RO_COMPAT_FEATURE(E, EXT4_FEATURE_RO_COMPAT_METADATA_CSUM)
+ ext4_has_metadata_csum(E)

https://bugzilla.kernel.org/show_bug.cgi?id=82201

Signed-off-by: Dmitry Monakhov 
Signed-off-by: Theodore Ts'o 
Signed-off-by: Greg Kroah-Hartman

ext4: grab missed write_count for EXT4_IOC_SWAP_BOOT

2014-11-14T18:10:30+00:00

commit 3e67cfad22230ebed85c56cbe413876f33fea82b upstream.

Otherwise this provokes complain like follows:
WARNING: CPU: 12 PID: 5795 at fs/ext4/ext4_jbd2.c:48 ext4_journal_check_start+0x4e/0xa0()
Modules linked in: brd iTCO_wdt lpc_ich mfd_core igb ptp dm_mirror dm_region_hash dm_log dm_mod
CPU: 12 PID: 5795 Comm: python Not tainted 3.17.0-rc2-00175-gae5344f #158
Hardware name: Intel Corporation W2600CR/W2600CR, BIOS SE5C600.86B.99.99.x028.061320111235 06/13/2011
 0000000000000030 ffff8808116cfd28 ffffffff815c7dfc 0000000000000030
 0000000000000000 ffff8808116cfd68 ffffffff8106ce8c ffff8808116cfdc8
 ffff880813b16000 ffff880806ad6ae8 ffffffff81202008 0000000000000000
Call Trace:
 [] dump_stack+0x51/0x6d
 [] warn_slowpath_common+0x8c/0xc0
 [] ? ext4_ioctl+0x9e8/0xeb0
 [] warn_slowpath_null+0x1a/0x20
 [] ext4_journal_check_start+0x4e/0xa0
 [] __ext4_journal_start_sb+0x90/0x110
 [] ext4_ioctl+0x9e8/0xeb0
 [] ? ptrace_stop+0x24d/0x2f0
 [] ? alloc_pid+0x480/0x480
 [] ? ptrace_do_notify+0x92/0xb0
 [] do_vfs_ioctl+0x4e5/0x550
 [] ? _raw_spin_unlock_irq+0x2b/0x40
 [] SyS_ioctl+0x53/0x80
 [] tracesys+0xd0/0xd5

Reviewed-by: Jan Kara 
Signed-off-by: Dmitry Monakhov 
Signed-off-by: Theodore Ts'o 
Signed-off-by: Greg Kroah-Hartman

ext4: clean up error handling in swap_inode_boot_loader()

2014-02-18T01:44:36+00:00

Tighten up the code to make the code easier to read and maintain.

Signed-off-by: "Theodore Ts'o"

ext4: fix error paths in swap_inode_boot_loader()

2014-02-12T16:48:31+00:00

In swap_inode_boot_loader() we forgot to release ->i_mutex and resume
unlocked dio for inode and inode_bl if there is an error starting the
journal handle.  This commit fixes this issue.

Reported-by: Ahmed Tamrawi 
Cc: Andreas Dilger 
Cc: Dr. Tilmann Bubeck 
Signed-off-by: Zheng Liu 
Signed-off-by: "Theodore Ts'o" 
Cc: stable@vger.kernel.org  # v3.10+

ext4: delete "set but not used" variables

2014-01-11T18:26:56+00:00

Signed-off-by: Jon Ernst 
Signed-off-by: "Theodore Ts'o" 
Reviewed-by: Zheng Liu

vfs: pull ext4's double-i_mutex-locking into common code

2013-11-09T05:16:39+00:00

We want to do this elsewhere as well.

Also catch any attempts to use it for directories (where this ordering
would conflict with ancestor-first directory ordering in lock_rename).

Cc: Andreas Dilger 
Cc: Dave Chinner 
Acked-by: Jeff Layton 
Acked-by: "Theodore Ts'o" 
Signed-off-by: J. Bruce Fields 
Signed-off-by: Al Viro

ext4: isolate ext4_extents.h file

2013-08-28T18:47:06+00:00

After applied the commit (4a092d73), we have reduced the number of
source files that need to #include ext4_extents.h.  But we can do
better.

This commit defines ext4_zeroout_es() in extents.c and move
EXT_MAX_BLOCKS into ext4.h in order not to include ext4_extents.h in
indirect.c and ioctl.c.  Meanwhile we just need to include this file in
extent_status.c when ES_AGGRESSIVE_TEST is defined.  Otherwise, this
commit removes a duplicated declaration in trace/events/ext4.h.

After applied this patch, we just need to include ext4_extents.h file
in {super,migrate,move_extents,extents}.c, and it is easy for us to
define a new extent disk layout.

Signed-off-by: Zheng Liu 
Signed-off-by: "Theodore Ts'o"

ext4: add support for extent pre-caching

2013-08-17T02:05:14+00:00

Add a new fiemap flag which forces the all of the extents in an inode
to be cached in the extent_status tree.  This is critically important
when using AIO to a preallocated file, since if we need to read in
blocks from the extent tree, the io_submit(2) system call becomes
synchronous, and the AIO is no longer "A", which is bad.

In addition, for most files which have an external leaf tree block,
the cost of caching the information in the extent status tree will be
less than caching the entire 4k block in the buffer cache.  So it is
generally a win to keep the extent information cached.

Signed-off-by: "Theodore Ts'o"

ext4: flush the extent status cache during EXT4_IOC_SWAP_BOOT

2013-08-12T13:29:30+00:00

Previously we weren't swapping only some of the extent_status LRU
fields during the processing of the EXT4_IOC_SWAP_BOOT ioctl.  The
much safer thing to do is to just completely flush the extent status
tree when doing the swap.

Signed-off-by: "Theodore Ts'o" 
Cc: Zheng Liu 
Cc: stable@vger.kernel.org

ext4: fix usless declarations

2013-04-10T02:48:36+00:00

This patch should fix sparse complains about shadow declatations.

Signed-off-by: Dmitry Monakhov 
Signed-off-by: "Theodore Ts'o"