linux-stable.git/fs/ext4/dir.c, branch linux-2.6.26.y

ext[234]: Avoid printk floods in the face of directory corruption (CVE-2008-3528)

2008-11-10T19:17:52+00:00

This is a trivial backport of the following upstream commits:

- bd39597cbd42a784105a04010100e27267481c67 (ext2)
- cdbf6dba28e8e6268c8420857696309470009fd9 (ext3)
- 9d9f177572d9e4eba0f2e18523b44f90dd51fe74 (ext4)

This addresses CVE-2008-3528

ext[234]: Avoid printk floods in the face of directory corruption

Note: some people thinks this represents a security bug, since it
might make the system go away while it is printing a large number of
console messages, especially if a serial console is involved.  Hence,
it has been assigned CVE-2008-3528, but it requires that the attacker
either has physical access to your machine to insert a USB disk with a
corrupted filesystem image (at which point why not just hit the power
button), or is otherwise able to convince the system administrator to
mount an arbitrary filesystem image (at which point why not just
include a setuid shell or world-writable hard disk device file or some
such).  Me, I think they're just being silly. --tytso

Signed-off-by: Eric Sandeen 
Signed-off-by: "Theodore Ts'o" 
Cc: linux-ext4@vger.kernel.org
Cc: Eugene Teo 
Signed-off-by: Greg Kroah-Hartman

ext4: move headers out of include/linux

2008-04-29T22:13:32+00:00

Move ext4 headers out of include/linux.  This is just the trivial move,
there's some more thing that could be done later. 

Signed-off-by: Christoph Hellwig 
Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o"

Convert ext4 to use unlocked_ioctl

2008-04-30T02:03:54+00:00

I checked ext4_ioctl and it looked largely safe to not be used
without BKL.  So convert it over to unlocked_ioctl.

Signed-off-by: Andi Kleen 
Signed-off-by: Theodore Ts'o

Remove incorrect BKL comments in ext4

2008-02-25T22:20:46+00:00

Signed-off-by: Andi Kleen 
Signed-off-by: "Theodore Ts'o"

ext4: Introduce ext4_lblk_t

2008-01-29T04:58:27+00:00

This patch adds a new data type ext4_lblk_t to represent
the logical file blocks.

This is the preparatory patch to support large files in ext4
The follow up patch with convert the ext4_inode i_blocks to
represent the number of blocks in file system block size. This
changes makes it possible to have a block number 2**32 -1 which
will result in overflow if the block number is represented by
signed long. This patch convert all the block number to type
ext4_lblk_t which is typedef to __u32

Also remove dead code ext4_ext_walk_space

Signed-off-by: Aneesh Kumar K.V 
Signed-off-by: Mingming Cao 
Signed-off-by: Eric Sandeen

ext4: Avoid rec_len overflow with 64KB block size

2008-01-29T04:58:27+00:00

With 64KB blocksize, a directory entry can have size 64KB which does not fit
into 16 bits we have for entry lenght. So we store 0xffff instead and convert
value when read from / written to disk. The patch also converts some places
to use ext4_next_entry() when we are changing them anyway.

Signed-off-by: Jan Kara 
Signed-off-by: Mingming Cao

ext4: remove #ifdef CONFIG_EXT4_INDEX

2007-10-17T22:50:00+00:00

CONFIG_EXT4_INDEX is not an exposed config option in the kernel, and it is
unconditionally defined in ext4_fs.h.  tune2fs is already able to turn off
dir indexing, so at this point it's just cluttering up the code.  Remove
it.

Signed-off-by: Eric Sandeen 
Signed-off-by: Mingming Cao 
Signed-off-by: "Theodore Ts'o" 
Signed-off-by: Andrew Morton

Fix f_version type: should be u64 instead of unsigned long

2007-10-17T15:42:53+00:00

Fix f_version type: should be u64 instead of long

There is a type inconsistency between struct inode i_version and struct file
f_version.

fs.h:

struct inode
  u64                     i_version;

and

struct file
  unsigned long           f_version;

Users do:

fs/ext3/dir.c:

if (filp->f_version != inode->i_version) {

So why isn't f_version a u64 ? It becomes a problem if versions gets
higher than 2^32 and we are on an architecture where longs are 32 bits.

This patch changes the f_version type to u64, and updates the users accordingly.

It applies to 2.6.23-rc2-mm2.

Signed-off-by: Mathieu Desnoyers 
Cc: Martin Bligh 
Cc: "Randy.Dunlap" 
Cc: Al Viro 
Cc: 
Cc: Mark Fasheh 
Cc: Christoph Hellwig 
Cc: "J. Bruce Fields" 
Cc: Trond Myklebust 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

readahead: combine file_ra_state.prev_index/prev_offset into prev_pos

2007-10-16T16:42:52+00:00

Combine the file_ra_state members
				unsigned long prev_index
				unsigned int prev_offset
into
				loff_t prev_pos

It is more consistent and better supports huge files.

Thanks to Peter for the nice proposal!

[akpm@linux-foundation.org: fix shift overflow]
Cc: Peter Zijlstra 
Signed-off-by: Fengguang Wu 
Cc: Rusty Russell 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

readahead: split ondemand readahead interface into two functions

2007-07-19T17:04:44+00:00

Split ondemand readahead interface into two functions.  I think this makes it
a little clearer for non-readahead experts (like Rusty).

Internally they both call ondemand_readahead(), but the page argument is
changed to an obvious boolean flag.

Signed-off-by: Rusty Russell 
Signed-off-by: Fengguang Wu 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds