linux-stable.git/fs/ext4/acl.c, branch linux-3.0.y

ext4: fix memory leak in ext4_xattr_set_acl()'s error path

2013-01-17T16:43:55+00:00

commit 24ec19b0ae83a385ad9c55520716da671274b96c upstream.

In ext4_xattr_set_acl(), if ext4_journal_start() returns an error,
posix_acl_release() will not be called for 'acl' which may result in a
memory leak.

This patch fixes that.

Reviewed-by: Lukas Czerner 
Signed-off-by: Eugene Shatokhin 
Signed-off-by: "Theodore Ts'o" 
Signed-off-by: Greg Kroah-Hartman

userns: rename is_owner_or_cap to inode_owner_or_capable

2011-03-24T02:47:13+00:00

And give it a kernel-doc comment.

[akpm@linux-foundation.org: btrfs changed in linux-next]
Signed-off-by: Serge E. Hallyn 
Cc: "Eric W. Biederman" 
Cc: Daniel Lezcano 
Acked-by: David Howells 
Cc: James Morris 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext2,3,4: provide simple rcu-walk ACL implementation

2011-01-07T06:50:30+00:00

This simple implementation just checks for no ACLs on the inode, and
if so, then the rcu-walk may proceed, otherwise fail it.

Signed-off-by: Nick Piggin

fs: provide rcu-walk aware permission i_ops

2011-01-07T06:50:29+00:00

Signed-off-by: Nick Piggin

ext4: update ctime when changing the file's permission by setfacl

2010-06-15T16:19:59+00:00

ext4 didn't update the ctime of the file when its permission was
changed.

Steps to reproduce:
 # touch aaa
 # stat -c %Z aaa
 1275289822
 # setfacl -m  'u::x,g::x,o::x' aaa
 # stat -c %Z aaa
 1275289822                         <- unchanged

But, according to the spec of the ctime, ext4 must update it.

Port of ext3 patch by Miao Xie .

CC: linux-ext4@vger.kernel.org
Signed-off-by: Jan Kara 
Signed-off-by: "Theodore Ts'o"

ext4: constify xattr_handler

2010-05-21T22:31:19+00:00

Signed-off-by: Stephen Hemminger 
Signed-off-by: Al Viro

sanitize xattr handler prototypes

2009-12-16T17:16:49+00:00

Add a flags argument to struct xattr_handler and pass it to all xattr
handler methods.  This allows using the same methods for multiple
handlers, e.g. for the ACL methods which perform exactly the same action
for the access and default ACLs, just using a different underlying
attribute.  With a little more groundwork it'll also allow sharing the
methods for the regular user/trusted/secure handlers in extN, ocfs2 and
jffs2 like it's already done for xfs in this patch.

Also change the inode argument to the handlers to a dentry to allow
using the handlers mechnism for filesystems that require it later,
e.g. cifs.

[with GFS2 bits updated by Steven Whitehouse ]

Signed-off-by: Christoph Hellwig 
Reviewed-by: James Morris 
Acked-by: Joel Becker 
Signed-off-by: Al Viro

ext[234]: move over to 'check_acl' permission model

2009-09-08T18:09:04+00:00

Don't implement per-filesystem 'extX_permission()' functions that have
to be called for every path component operation, and instead just expose
the actual ACL checking so that the VFS layer can now do it for us.

Reviewed-by: James Morris 
Acked-by: Serge Hallyn 
Signed-off-by: Linus Torvalds

helpers for acl caching + switch to those

2009-06-24T12:17:07+00:00

helpers: get_cached_acl(inode, type), set_cached_acl(inode, type, acl),
forget_cached_acl(inode, type).

ubifs/xattr.c needed includes reordered, the rest is a plain switchover.

Signed-off-by: Al Viro

switch ext4 to inode->i_acl

2009-06-24T12:17:04+00:00

Signed-off-by: Al Viro