linux-stable.git/fs/ext3, branch linux-2.6.33.y

ext3: Fix oops in ext3_try_to_allocate_with_rsv()

2011-08-08T17:36:02+00:00

commit ad95c5e9bc8b5885f94dce720137cac8fa8da4c9 upstream.

Block allocation is called from two places: ext3_get_blocks_handle() and
ext3_xattr_block_set(). These two callers are not necessarily synchronized
because xattr code holds only xattr_sem and i_mutex, and
ext3_get_blocks_handle() may hold only truncate_mutex when called from
writepage() path. Block reservation code does not expect two concurrent
allocations to happen to the same inode and thus assertions can be triggered
or reservation structure corruption can occur.

Fix the problem by taking truncate_mutex in xattr code to serialize
allocations.

CC: Sage Weil 
Reported-by: Fyodor Ustinov 
Signed-off-by: Jan Kara 
Signed-off-by: Greg Kroah-Hartman

ext3: Fix fs corruption when make_indexed_dir() fails

2011-06-23T22:28:34+00:00

commit 86c4f6d85595cd7da635dc6985d27bfa43b1ae10 upstream.

When make_indexed_dir() fails (e.g. because of ENOSPC) after it has allocated
block for index tree root, we did not properly mark all changed buffers dirty.
This lead to only some of these buffers being written out and thus effectively
corrupting the directory.

Fix the issue by marking all changed data dirty even in the error failure case.

Signed-off-by: Jan Kara 
Signed-off-by: Greg Kroah-Hartman

ext3: skip orphan cleanup on rocompat fs

2011-03-28T14:31:20+00:00

commit ce654b37f87980d95f339080e4c3bdb2370bdf22 upstream.

Orphan cleanup is currently executed even if the file system has some
number of unknown ROCOMPAT features, which deletes inodes and frees
blocks, which could be very bad for some RO_COMPAT features.

This patch skips the orphan cleanup if it contains readonly compatible
features not known by this ext3 implementation, which would prevent
the fs from being mounted (or remounted) readwrite.

Signed-off-by: Amir Goldstein 
Signed-off-by: Jan Kara 
Signed-off-by: Greg Kroah-Hartman

ext3: Always set dx_node's fake_dirent explicitly.

2011-03-21T19:45:52+00:00

commit d7433142b63d727b5a217c37b1a1468b116a9771 upstream.

(crossport of 1f7bebb9e911d870fa8f997ddff838e82b5715ea
by Andreas Schlick )

When ext3_dx_add_entry() has to split an index node, it has to ensure that
name_len of dx_node's fake_dirent is also zero, because otherwise e2fsck
won't recognise it as an intermediate htree node and consider the htree to
be corrupted.

Signed-off-by: Eric Sandeen 
Signed-off-by: Jan Kara 
Signed-off-by: Greg Kroah-Hartman

ext3: Replace lock/unlock_super() with an explicit lock for resizing

2009-12-23T12:44:12+00:00

Use a separate lock to protect s_groups_count and the other block
group descriptors which get changed via an on-line resize operation,
so we can stop overloading the use of lock_super().

Port of ext4 commit 32ed5058ce90024efcd811254b4b1de0468099df by
Theodore Ts'o .

CC: Theodore Ts'o 
Signed-off-by: Eric Sandeen 
Signed-off-by: Jan Kara

ext3: Replace lock/unlock_super() with an explicit lock for the orphan list

2009-12-23T12:44:11+00:00

Use a separate lock to protect the orphan list, so we can stop
overloading the use of lock_super().

Port of ext4 commit 3b9d4ed26680771295d904a6b83e88e620780893
by Theodore Ts'o .

CC: Theodore Ts'o 
Signed-off-by: Eric Sandeen 
Signed-off-by: Jan Kara

ext3: ext3_mark_recovery_complete() doesn't need to use lock_super

2009-12-23T12:44:11+00:00

The function ext3_mark_recovery_complete() is called from two call
paths: either (a) while mounting the filesystem, in which case there's
no danger of any other CPU calling write_super() until the mount is
completed, and (b) while remounting the filesystem read-write, in
which case the fs core has already locked the superblock.  This also
allows us to take out a very vile unlock_super()/lock_super() pair in
ext3_remount().

Port of ext4 commit a63c9eb2ce6f5028da90f282798232c4f398ceb8 by
Theodore Ts'o .

CC: Theodore Ts'o 
Signed-off-by: Eric Sandeen 
Signed-off-by: Jan Kara

ext3: Remove outdated comment about lock_super()

2009-12-23T12:43:50+00:00

ext3_fill_super() is no longer called by read_super(), and it is no
longer called with the superblock locked.  The
unlock_super()/lock_super() is no longer present, so this comment is
entirely superfluous.

Port of ext4 commit 32ed5058ce90024efcd811254b4b1de0468099df by
Theodore Ts'o .

CC: Theodore Ts'o 
Signed-off-by: Eric Sandeen 
Signed-off-by: Jan Kara

ext3: quota macros cleanup [V2]

2009-12-23T12:33:54+00:00

Currently all quota block reservation macros contains hardcoded "2"
aka MAXQUOTAS value. This is no good because in some places it is not
obvious to understand what does this digit represent. Let's introduce
new macro with self descriptive name.

Signed-off-by: Dmitry Monakhov 
Signed-off-by: Jan Kara

sanitize xattr handler prototypes

2009-12-16T17:16:49+00:00

Add a flags argument to struct xattr_handler and pass it to all xattr
handler methods.  This allows using the same methods for multiple
handlers, e.g. for the ACL methods which perform exactly the same action
for the access and default ACLs, just using a different underlying
attribute.  With a little more groundwork it'll also allow sharing the
methods for the regular user/trusted/secure handlers in extN, ocfs2 and
jffs2 like it's already done for xfs in this patch.

Also change the inode argument to the handlers to a dentry to allow
using the handlers mechnism for filesystems that require it later,
e.g. cifs.

[with GFS2 bits updated by Steven Whitehouse ]

Signed-off-by: Christoph Hellwig 
Reviewed-by: James Morris 
Acked-by: Joel Becker 
Signed-off-by: Al Viro