linux-stable.git/fs/ext2, branch linux-6.5.y

ext2: fix datatype of block number in ext2_xattr_set2()

2023-09-23T09:14:26+00:00

[ Upstream commit e88076348425b7d0491c8c98d8732a7df8de7aa3 ]

I run a small server that uses external hard drives for backups. The
backup software I use uses ext2 filesystems with 4KiB block size and
the server is running SELinux and therefore relies on xattr. I recently
upgraded the hard drives from 4TB to 12TB models. I noticed that after
transferring some TBs I got a filesystem error "Freeing blocks not in
datazone - block = 18446744071529317386, count = 1" and the backup
process stopped. Trying to fix the fs with e2fsck resulted in a
completely corrupted fs. The error probably came from ext2_free_blocks(),
and because of the large number 18e19 this problem immediately looked
like some kind of integer overflow. Whereas the 4TB fs was about 1e9
blocks, the new 12TB is about 3e9 blocks. So, searching the ext2 code,
I came across the line in fs/ext2/xattr.c:745 where ext2_new_block()
is called and the resulting block number is stored in the variable block
as an int datatype. If a block with a block number greater than
INT32_MAX is returned, this variable overflows and the call to
sb_getblk() at line fs/ext2/xattr.c:750 fails, then the call to
ext2_free_blocks() produces the error.

Signed-off-by: Georg Ottinger 
Signed-off-by: Jan Kara 
Message-Id: <20230815100340.22121-1-g.ottinger@gmx.at>
Signed-off-by: Sasha Levin

Merge tag 'fs_for_v6.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs

2023-06-29T20:39:51+00:00

Pull misc filesystem updates from Jan Kara:

 - Rewrite kmap_local() handling in ext2

 - Convert ext2 direct IO path to iomap (with some infrastructure tweaks
   associated with that)

 - Convert two boilerplate licenses in udf to SPDX identifiers

 - Other small udf, ext2, and quota fixes and cleanups

* tag 'fs_for_v6.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs:
  udf: Fix uninitialized array access for some pathnames
  ext2: Drop fragment support
  quota: fix warning in dqgrab()
  quota: Properly disable quotas when add_dquot_ref() fails
  fs: udf: udftime: Replace LGPL boilerplate with SPDX identifier
  fs: udf: Replace GPL 2.0 boilerplate license notice with SPDX identifier
  fs: Drop wait_unfrozen wait queue
  ext2_find_entry()/ext2_dotdot(): callers don't need page_addr anymore
  ext2_{set_link,delete_entry}(): don't bother with page_addr
  ext2_put_page(): accept any pointer within the page
  ext2_get_page(): saner type
  ext2: use offset_in_page() instead of open-coding it as subtraction
  ext2_rename(): set_link and delete_entry may fail
  ext2: Add direct-io trace points
  ext2: Move direct-io to use iomap
  ext2: Use generic_buffers_fsync() implementation
  ext4: Use generic_buffers_fsync_noflush() implementation
  fs/buffer.c: Add generic_buffers_fsync*() implementation
  ext2/dax: Fix ext2_setsize when len is page aligned

ext2: Drop fragment support

2023-06-13T10:37:31+00:00

Ext2 has fields in superblock reserved for subblock allocation support.
However that never landed. Drop the many years dead code.

Reported-by: syzbot+af5e10f73dbff48f70af@syzkaller.appspotmail.com
Signed-off-by: Jan Kara

ext2_find_entry()/ext2_dotdot(): callers don't need page_addr anymore

2023-05-29T09:03:31+00:00

... and that's how it should've been done in the first place

Signed-off-by: Al Viro 
Reviewed-by: Fabio M. De Francesco 
Tested-by: Fabio M. De Francesco 
Signed-off-by: Jan Kara

ext2_{set_link,delete_entry}(): don't bother with page_addr

2023-05-29T09:03:28+00:00

ext2_set_link() simply doesn't use it anymore and ext2_delete_entry()
can easily obtain it from the directory entry pointer...

Signed-off-by: Al Viro 
Reviewed-by: Fabio M. De Francesco 
Tested-by: Fabio M. De Francesco 
Signed-off-by: Jan Kara

ext2_put_page(): accept any pointer within the page

2023-05-29T09:03:25+00:00

eliminates the need to keep the pointer to the first byte within
the page if we are guaranteed to have pointers to some byte
in the same page at hand.

Don't backport without commit 88d7b12068b9 ("highmem: round down the
address passed to kunmap_flush_on_unmap()").

Signed-off-by: Al Viro 
Reviewed-by: Fabio M. De Francesco 
Tested-by: Fabio M. De Francesco 
Signed-off-by: Jan Kara

ext2_get_page(): saner type

2023-05-29T09:03:22+00:00

We need to pass to caller both the page reference and pointer to the
first byte in the now-mapped page.  The former always has the same type,
the latter varies from caller to caller.  So make it
	void *ext2_get_page(...., struct page **page)
rather than
	struct page *ext2_get_page(..., void **page_addr)
and avoid the casts...

Signed-off-by: Al Viro 
Reviewed-by: Fabio M. De Francesco 
Tested-by: Fabio M. De Francesco 
Signed-off-by: Jan Kara

ext2: use offset_in_page() instead of open-coding it as subtraction

2023-05-29T09:03:19+00:00

Signed-off-by: Al Viro 
Reviewed-by: Fabio M. De Francesco 
Tested-by: Fabio M. De Francesco 
Signed-off-by: Jan Kara

ext2_rename(): set_link and delete_entry may fail

2023-05-29T09:03:06+00:00

Signed-off-by: Al Viro 
Reviewed-by: Fabio M. De Francesco 
Tested-by: Fabio M. De Francesco 
Signed-off-by: Jan Kara

splice: Use filemap_splice_read() instead of generic_file_splice_read()

2023-05-24T14:42:17+00:00

Replace pointers to generic_file_splice_read() with calls to
filemap_splice_read().

Signed-off-by: David Howells 
Reviewed-by: Christoph Hellwig 
Reviewed-by: Christian Brauner 
cc: Jens Axboe 
cc: Al Viro 
cc: David Hildenbrand 
cc: John Hubbard 
cc: linux-mm@kvack.org
cc: linux-block@vger.kernel.org
cc: linux-fsdevel@vger.kernel.org
Link: https://lore.kernel.org/r/20230522135018.2742245-29-dhowells@redhat.com
Signed-off-by: Jens Axboe