linux-stable.git/fs/ext2, branch linux-2.6.25.y

ext[234]: Avoid printk floods in the face of directory corruption (CVE-2008-3528)

2008-11-10T18:50:05+00:00

This is a trivial backport of the following upstream commits:

- bd39597cbd42a784105a04010100e27267481c67 (ext2)
- cdbf6dba28e8e6268c8420857696309470009fd9 (ext3)
- 9d9f177572d9e4eba0f2e18523b44f90dd51fe74 (ext4)

This addresses CVE-2008-3528

ext[234]: Avoid printk floods in the face of directory corruption

Note: some people thinks this represents a security bug, since it
might make the system go away while it is printing a large number of
console messages, especially if a serial console is involved.  Hence,
it has been assigned CVE-2008-3528, but it requires that the attacker
either has physical access to your machine to insert a USB disk with a
corrupted filesystem image (at which point why not just hit the power
button), or is otherwise able to convince the system administrator to
mount an arbitrary filesystem image (at which point why not just
include a setuid shell or world-writable hard disk device file or some
such).  Me, I think they're just being silly. --tytso

Signed-off-by: Eric Sandeen 
Signed-off-by: "Theodore Ts'o" 
Cc: linux-ext4@vger.kernel.org
Cc: Eugene Teo 
Signed-off-by: Greg Kroah-Hartman

vfs: fix possible deadlock in ext2, ext3, ext4 when using xattrs

2008-04-16T02:35:41+00:00

mb_cache_entry_alloc() was allocating cache entries with GFP_KERNEL.  But
filesystems are calling this function while holding xattr_sem so possible
recursion into the fs violates locking ordering of xattr_sem and transaction
start / i_mutex for ext2-4.  Change mb_cache_entry_alloc() so that filesystems
can specify desired gfp mask and use GFP_NOFS from all of them.

Signed-off-by: Jan Kara 
Reported-by: Dave Jones 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

mount options: fix ext2

2008-02-08T17:22:40+00:00

Add noreservation option to /proc/mounts for ext2 filesystems.

Signed-off-by: Miklos Szeredi 
Acked-by: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext2: remove unused ext2_put_inode prototype

2008-02-08T17:22:33+00:00

Signed-off-by: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

iget: stop EXT2 from using iget() and read_inode()

2008-02-07T16:42:27+00:00

Stop the EXT2 filesystem from using iget() and read_inode().  Replace
ext2_read_inode() with ext2_iget(), and call that instead of iget().
ext2_iget() then uses iget_locked() directly and returns a proper error code
instead of an inode in the event of an error.

ext2_fill_super() returns any error incurred when getting the root inode
instead of EINVAL.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: David Howells 
Acked-by: "Theodore Ts'o" 
Cc: 
Acked-by: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext[234]: cleanup ext[234]_bg_num_gdb()

2008-02-06T18:41:21+00:00

Use ext[234]_bg_has_super() to remove duplicate code.

Signed-off-by: Akinobu Mita 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext[234]: remove unused argument for ext[234]_find_goal()

2008-02-06T18:41:21+00:00

The argument chain for ext[234]_find_goal() is not used.  This patch removes
it and fixes comment as well.

Cc: 
Signed-off-by: Akinobu Mita 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext[234]: use ext[234]_get_group_desc()

2008-02-06T18:41:21+00:00

Use ext[234]_get_group_desc() to get group descriptor from group number.

Cc: 
Signed-off-by: Akinobu Mita 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ext[234]: fix comment for nonexistent variable

2008-02-06T18:41:21+00:00

The comment in ext[234]_new_blocks() describes about "i".  But there is no
local variable called "i" in that scope.  I guess it has been renamed to
group_no.

Cc: 
Signed-off-by: Akinobu Mita 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

BKL-removal: remove incorrect BKL comment in ext2

2008-02-06T18:41:20+00:00

No BKL used anywhere, so don't mention it.

Signed-off-by: Andi Kleen 
Cc: Theodore Ts'o 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds