linux-stable.git/fs/exfat, branch linux-5.7.y

exfat: fix name_hash computation on big endian systems

2020-07-29T08:19:38+00:00

commit db415f7aae07cadcabd5d2a659f8ad825c905299 upstream.

On-disk format for name_hash field is LE, so it must be explicitly
transformed on BE system for proper result.

Fixes: 370e812b3ec1 ("exfat: add nls operations")
Cc: stable@vger.kernel.org # v5.7
Signed-off-by: Chen Minqiang 
Signed-off-by: Ilya Ponetayev 
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon 
Signed-off-by: Greg Kroah-Hartman

exfat: fix wrong size update of stream entry by typo

2020-07-29T08:19:38+00:00

commit 41e3928f8c58184fcf0bb22e822af39a436370c7 upstream.

The stream.size field is updated to the value of create timestamp
of the file entry. Fix this to use correct stream entry pointer.

Fixes: 29bbb14bfc80 ("exfat: fix incorrect update of stream entry in __exfat_truncate()")
Signed-off-by: Hyeongseok Kim 
Signed-off-by: Namjae Jeon 
Signed-off-by: Greg Kroah-Hartman

exfat: fix wrong hint_stat initialization in exfat_find_dir_entry()

2020-07-29T08:19:38+00:00

commit d2fa0c337d97a5490190b9f3b9c73c8f9f3602a1 upstream.

We found the wrong hint_stat initialization in exfat_find_dir_entry().
It should be initialized when cluster is EXFAT_EOF_CLUSTER.

Fixes: ca06197382bd ("exfat: add directory operations")
Cc: stable@vger.kernel.org # v5.7
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon 
Signed-off-by: Greg Kroah-Hartman

exfat: fix overflow issue in exfat_cluster_to_sector()

2020-07-29T08:19:38+00:00

commit 43946b70494beefe40ec1b2ba4744c0f294d7736 upstream.

An overflow issue can occur while calculating sector in
exfat_cluster_to_sector(). It needs to cast clus's type to sector_t
before left shifting.

Fixes: 1acf1a564b60 ("exfat: add in-memory and on-disk structures and headers")
Cc: stable@vger.kernel.org # v5.7
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon 
Signed-off-by: Greg Kroah-Hartman

exfat: flush dirty metadata in fsync

2020-07-09T07:39:26+00:00

[ Upstream commit 5267456e953fd8c5abd8e278b1cc6a9f9027ac0a ]

generic_file_fsync() exfat used could not guarantee the consistency of
a file because it has flushed not dirty metadata but only dirty data pages
for a file.

Instead of that, use exfat_file_fsync() for files and directories so that
it guarantees to commit both the metadata and data pages for a file.

Signed-off-by: Sungjong Seo 
Signed-off-by: Namjae Jeon 
Signed-off-by: Sasha Levin

exfat: move setting VOL_DIRTY over exfat_remove_entries()

2020-07-09T07:39:26+00:00

[ Upstream commit 3bcfb701099acf96b0e883bf5544f96af473aa1d ]

Move setting VOL_DIRTY over exfat_remove_entries() to avoid unneeded
leaving VOL_DIRTY on -ENOTEMPTY.

Fixes: 5f2aa075070c ("exfat: add inode operations")
Cc: stable@vger.kernel.org # v5.7
Reported-by: Tetsuhiro Kohada 
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon 
Signed-off-by: Sasha Levin

exfat: call sync_filesystem for read-only remount

2020-07-09T07:39:25+00:00

[ Upstream commit a0271a15cf2cf907ea5b0f2ba611123f1b7935ec ]

We need to commit dirty metadata and pages to disk
before remounting exfat as read-only.

This fixes a failure in xfstests generic/452

generic/452 does the following:
cp something /
mount -o remount,ro 

the /something is corrupted. because while
exfat is remounted as read-only, exfat doesn't
have a chance to commit metadata and
vfs invalidates page caches in a block device.

Signed-off-by: Hyunchul Lee 
Acked-by: Sungjong Seo 
Signed-off-by: Namjae Jeon 
Signed-off-by: Sasha Levin

exfat: add missing brelse() calls on error paths

2020-07-09T07:39:25+00:00

[ Upstream commit e8dd3cda8667118b70d9fe527f61fe22623de04d ]

If the second exfat_get_dentry() call fails then we need to release
"old_bh" before returning.  There is a similar bug in exfat_move_file().

Fixes: 5f2aa075070c ("exfat: add inode operations")
Reported-by: Markus Elfring 
Signed-off-by: Dan Carpenter 
Signed-off-by: Namjae Jeon 
Signed-off-by: Sasha Levin

exfat: Set the unused characters of FileName field to the value 0000h

2020-07-09T07:39:25+00:00

[ Upstream commit 4ba6ccd695f5ed3ae851e59b443b757bbe4557fe ]

Some fsck tool complain that padding part of the FileName field
is not set to the value 0000h. So let's maintain filesystem cleaner,
as exfat's spec. recommendation.

Signed-off-by: Hyeongseok.Kim 
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon 
Signed-off-by: Sasha Levin

exfat: fix incorrect update of stream entry in __exfat_truncate()

2020-06-17T14:42:59+00:00

commit 29bbb14bfc80dd760b07d2be0a27e610562982e3 upstream.

At truncate, there is a problem of incorrect updating in the file entry
pointer instead of stream entry. This will cause the problem of
overwriting the time field of the file entry to new_size. Fix it to
update stream entry.

Fixes: 98d917047e8b ("exfat: add file operations")
Cc: stable@vger.kernel.org # v5.7
Signed-off-by: Namjae Jeon 
Signed-off-by: Greg Kroah-Hartman