linux-stable.git/fs/exfat, branch linux-5.14.y

exfat: fix incorrect loading of i_blocks for large files

2021-11-17T10:03:23+00:00

commit 0c336d6e33f4bedc443404c89f43c91c8bd9ee11 upstream.

When calculating i_blocks, there was a mistake that was masked with a
32-bit variable. So i_blocks for files larger than 4 GiB had incorrect
values. Mask with a 64-bit variable instead of 32-bit one.

Fixes: 5f2aa075070c ("exfat: add inode operations")
Cc: stable@vger.kernel.org # v5.7+
Reported-by: Ganapathi Kamath 
Signed-off-by: Sungjong Seo 
Signed-off-by: Namjae Jeon 
Signed-off-by: Greg Kroah-Hartman

Merge tag 'exfat-for-5.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/exfat

2021-07-06T18:06:04+00:00

Pull exfat updates from Namjae Jeon:

 - Improved compatibility issue with exfat from some camera vendors.

 - Do not need to release root inode on error path.

* tag 'exfat-for-5.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/linkinjeon/exfat:
  exfat: handle wrong stream entry size in exfat_readdir()
  exfat: avoid incorrectly releasing for root inode

exfat: handle wrong stream entry size in exfat_readdir()

2021-07-04T00:33:00+00:00

The compatibility issue between linux exfat and exfat of some camera
company was reported from Florian. In their exfat, if the number of files
exceeds any limit, the DataLength in stream entry of the directory is
no longer updated. So some files created from camera does not show in
linux exfat. because linux exfat doesn't allow that cpos becomes larger
than DataLength of stream entry. This patch check DataLength in stream
entry only if the type is ALLOC_NO_FAT_CHAIN and add the check ensure
that dentry offset does not exceed max dentries size(256 MB) to avoid
the circular FAT chain issue.

Fixes: ca06197382bd ("exfat: add directory operations")
Cc: stable@vger.kernel.org # v5.9
Reported-by: Florian Cramer 
Reviewed-by: Sungjong Seo 
Tested-by: Chris Down 
Signed-off-by: Namjae Jeon

mm: require ->set_page_dirty to be explicitly wired up

2021-06-29T17:53:48+00:00

Remove the CONFIG_BLOCK default to __set_page_dirty_buffers and just wire
that method up for the missing instances.

[hch@lst.de: ecryptfs: add a ->set_page_dirty cludge]
  Link: https://lkml.kernel.org/r/20210624125250.536369-1-hch@lst.de

Link: https://lkml.kernel.org/r/20210614061512.3966143-4-hch@lst.de
Signed-off-by: Christoph Hellwig 
Reviewed-by: Greg Kroah-Hartman 
Reviewed-by: Jan Kara 
Cc: Al Viro 
Cc: Matthew Wilcox (Oracle) 
Cc: Tyler Hicks 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

exfat: avoid incorrectly releasing for root inode

2021-06-28T12:49:47+00:00

In d_make_root, when we fail to allocate dentry for root inode,
we will iput root inode and returned value is NULL in this function.

So we do not need to release this inode again at d_make_root's caller.

Signed-off-by: Chen Li 
Signed-off-by: Namjae Jeon

exfat: speed up iterate/lookup by fixing start point of traversing cluster chain

2021-04-27T11:45:07+00:00

When directory iterate and lookup is called, there's a buggy rewinding
of start point for traversing cluster chain to the parent directory
entry's first cluster. This caused repeated cluster chain traversing
from the first entry of the parent directory that would show worse
performance if huge amounts of files exist under the parent directory.
Fix not to rewind, make continue from currently referenced cluster and
dir entry.

Tested with 50,000 files under single directory / 256GB sdcard,
with command "time ls -l > /dev/null",
Before :     0m08.69s real     0m00.27s user     0m05.91s system
After  :     0m07.01s real     0m00.25s user     0m04.34s system

Signed-off-by: Hyeongseok Kim 
Reviewed-by: Sungjong Seo 
Signed-off-by: Namjae Jeon

exfat: improve write performance when dirsync enabled

2021-04-27T11:45:06+00:00

Degradation of write speed caused by frequent disk access for cluster
bitmap update on every cluster allocation could be improved by
selective syncing bitmap buffer. Change to flush bitmap buffer only
for the directory related operations.

Signed-off-by: Hyeongseok Kim 
Acked-by: Sungjong Seo 
Signed-off-by: Namjae Jeon

exfat: add support ioctl and FITRIM function

2021-04-27T11:45:06+00:00

Add FITRIM ioctl to enable discarding unused blocks while mounted.
As current exFAT doesn't have generic ioctl handler, add empty ioctl
function first, and add FITRIM handler.

Signed-off-by: Hyeongseok Kim 
Reviewed-by: Chaitanya Kulkarni 
Acked-by: Sungjong Seo 
Signed-off-by: Namjae Jeon

exfat: introduce bitmap_lock for cluster bitmap access

2021-04-27T11:45:06+00:00

s_lock which is for protecting concurrent access of file operations is
too huge for cluster bitmap protection, so introduce a new bitmap_lock
to narrow the lock range if only need to access cluster bitmap.

Signed-off-by: Hyeongseok Kim 
Acked-by: Sungjong Seo 
Signed-off-by: Namjae Jeon

exfat: fix erroneous discard when clear cluster bit

2021-04-27T11:45:06+00:00

If mounted with discard option, exFAT issues discard command when clear
cluster bit to remove file. But the input parameter of cluster-to-sector
calculation is abnormally added by reserved cluster size which is 2,
leading to discard unrelated sectors included in target+2 cluster.
With fixing this, remove the wrong comments in set/clear/find bitmap
functions.

Fixes: 1e49a94cf707 ("exfat: add bitmap operations")
Cc: stable@vger.kernel.org # v5.7+
Signed-off-by: Hyeongseok Kim 
Acked-by: Sungjong Seo 
Signed-off-by: Namjae Jeon