linux-stable.git/fs/ecryptfs, branch linux-2.6.26.y

eCryptfs: use page_alloc not kmalloc to get a page of memory

2008-08-01T19:43:10+00:00

commit 7fcba054373d5dfc43d26e243a5c9b92069972ee upstream
Date: Mon, 28 Jul 2008 15:46:39 -0700
Subject: eCryptfs: use page_alloc not kmalloc to get a page of memory

With SLUB debugging turned on in 2.6.26, I was getting memory corruption
when testing eCryptfs.  The root cause turned out to be that eCryptfs was
doing kmalloc(PAGE_CACHE_SIZE); virt_to_page() and treating that as a nice
page-aligned chunk of memory.  But at least with SLUB debugging on, this
is not always true, and the page we get from virt_to_page does not
necessarily match the PAGE_CACHE_SIZE worth of memory we got from kmalloc.

My simple testcase was 2 loops doing "rm -f fileX; cp /tmp/fileX ." for 2
different multi-megabyte files.  With this change I no longer see the
corruption.

Signed-off-by: Eric Sandeen 
Acked-by: Michael Halcrow 
Acked-by: Rik van Riel 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds 
Signed-off-by: Greg Kroah-Hartman

ecryptfs: remove unnecessary mux from ecryptfs_init_ecryptfs_miscdev()

2008-07-04T17:40:05+00:00

The misc_mtx should provide all the protection required to keep the daemon
hash table sane during miscdev registration.  Since this mutex is causing
gratuitous lockdep warnings, this patch removes it.

Signed-off-by: Michael Halcrow 
Reported-by: Cyrill Gorcunov 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: remove unnecessary page decrypt call

2008-06-06T18:29:09+00:00

The page decrypt calls in ecryptfs_write() are both pointless and buggy.
Pointless because ecryptfs_get_locked_page() has already brought the page
up to date, and buggy because prior mmap writes will just be blown away by
the decrypt call.

This patch also removes the declaration of a now-nonexistent function
ecryptfs_write_zeros().

Thanks to Eric Sandeen and David Kleikamp for helping to track this
down.

Eric said:

   fsx w/ mmap dies quickly ( < 100 ops) without this, and survives
   nicely (to millions of ops+) with it in place.

Signed-off-by: Michael Halcrow 
Cc: Eric Sandeen 
Cc: Dave Kleikamp 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ecryptfs: fix missed mutex_unlock

2008-05-24T16:56:07+00:00

Cc: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ecryptfs fixes

2008-05-21T23:55:59+00:00

memcpy() from userland pointer is a Bad Thing(tm)

Signed-off-by: Al Viro 
Signed-off-by: Linus Torvalds

eCryptFS: fix imbalanced mutex locking

2008-05-13T15:02:26+00:00

Fix imbalanced calls for mutex lock/unlock on ecryptfs_daemon_hash_mux
Revealed by Ingo Molnar: http://lkml.org/lkml/2008/5/7/260

Signed-off-by: Cyrill Gorcunov 
Cc: Michael Halcrow 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

ecryptfs: clean up (un)lock_parent

2008-05-13T15:02:23+00:00

dget(dentry->d_parent) --> dget_parent(dentry)

unlock_parent() is racy and unnecessary.  Replace single caller with
unlock_dir().

There are several other suspect uses of ->d_parent in ecryptfs...

Signed-off-by: Miklos Szeredi 
Cc: Michael Halcrow 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Remove duplicated unlikely() in IS_ERR()

2008-04-29T15:06:25+00:00

Some drivers have duplicated unlikely() macros.  IS_ERR() already has
unlikely() in itself.

This patch cleans up such pointless code.

Signed-off-by: Hirofumi Nakagawa 
Acked-by: David S. Miller 
Acked-by: Jeff Garzik 
Cc: Paul Clements 
Cc: Richard Purdie 
Cc: Alessandro Zummo 
Cc: David Brownell 
Cc: James Bottomley 
Cc: Michael Halcrow 
Cc: Anton Altaparmakov 
Cc: Al Viro 
Cc: Carsten Otte 
Cc: Patrick McHardy 
Cc: Paul Mundt 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Acked-by: Mike Frysinger 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: protect crypt_stat->flags in ecryptfs_open()

2008-04-29T15:06:07+00:00

Make sure crypt_stat->flags is protected with a lock in ecryptfs_open().

Signed-off-by: Michael Halcrow 
Cc: Al Viro 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

eCryptfs: make key module subsystem respect namespaces

2008-04-29T15:06:07+00:00

Make eCryptfs key module subsystem respect namespaces.

Since I will be removing the netlink interface in a future patch, I just made
changes to the netlink.c code so that it will not break the build.  With my
recent patches, the kernel module currently defaults to the device handle
interface rather than the netlink interface.

[akpm@linux-foundation.org: export free_user_ns()]
Signed-off-by: Michael Halcrow 
Acked-by: Serge Hallyn 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds