linux-stable.git/fs/dlm/lockspace.c, branch linux-4.9.y

dlm: Fix kobject memleak

2020-08-21T09:02:04+00:00

[ Upstream commit 0ffddafc3a3970ef7013696e7f36b3d378bc4c16 ]

Currently the error return path from kobject_init_and_add() is not
followed by a call to kobject_put() - which means we are leaking
the kobject.

Set do_unreg = 1 before kobject_init_and_add() to ensure that
kobject_put() can be called in its error patch.

Fixes: 901195ed7f4b ("Kobject: change GFS2 to use kobject_init_and_add")
Reported-by: Hulk Robot 
Signed-off-by: Wang Hai 
Signed-off-by: David Teigland 
Signed-off-by: Sasha Levin

dlm: fix missing idr_destroy for recover_idr

2019-12-21T09:40:56+00:00

[ Upstream commit 8fc6ed9a3508a0435b9270c313600799d210d319 ]

Which would leak memory for the idr internals.

Signed-off-by: David Teigland 
Signed-off-by: Sasha Levin

dlm: fixed memory leaks after failed ls_remove_names allocation

2019-01-13T09:03:52+00:00

commit b982896cdb6e6a6b89d86dfb39df489d9df51e14 upstream.

If allocation fails on last elements of array need to free already
allocated elements.

v2: just move existing out_rsbtbl label to right place

Fixes 789924ba635f ("dlm: fix race between remove and lookup")
Cc: stable@kernel.org # 3.6

Signed-off-by: Vasily Averin 
Signed-off-by: David Teigland 
Signed-off-by: Greg Kroah-Hartman

fs/dlm/lockspace.c: convert simple_str to kstr

2014-06-06T23:08:18+00:00

Replace obsolete functions.

Signed-off-by: Fabian Frederick 
Cc: Christine Caulfield 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dlm: use INFO for recovery messages

2014-02-14T17:54:44+00:00

The log messages relating to the progress of recovery
are minimal and very often useful.  Change these to
the KERN_INFO level so they are always available.

Signed-off-by: David Teigland

dlm: Avoid that dlm_release_lockspace() incorrectly returns -EBUSY

2013-10-16T15:32:42+00:00

When dlm_release_lockspace(ls, 1) is invoked on a busy system
immediately after the last dlm_unlock() AST has finished it can occur
that lkb_idr_is_local() is invoked for the unlocked LKB since removal
from ls_lkbidr only occurs after the AST has returned. If that happens
dlm_release_lockspace(ls, 1) will return -EBUSY instead of releasing
the lockspace. Fix this race condition by changing lkb_idr_is_local()
such that it only returns true for LKB's that have not yet been
unlocked.

Signed-off-by: Bart Van Assche 
Signed-off-by: David Teigland

dlm: log an error for unmanaged lockspaces

2013-06-25T17:53:20+00:00

Log an error message if the dlm user daemon exits
before all the lockspaces have been removed.

Signed-off-by: David Teigland

dlm: don't use idr_remove_all()

2013-02-28T03:10:13+00:00

idr_destroy() can destroy idr by itself and idr_remove_all() is being
deprecated.

The conversion isn't completely trivial for recover_idr_clear() as it's
the only place in kernel which makes legitimate use of idr_remove_all()
w/o idr_destroy().  Replace it with idr_remove() call inside
idr_for_each_entry() loop.  It goes on top so that it matches the
operation order in recover_idr_del().

Signed-off-by: Tejun Heo 
Cc: Christine Caulfield 
Cc: David Teigland 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

dlm: fix unlock balance warnings

2012-08-08T16:33:49+00:00

The in_recovery rw_semaphore has always been acquired and
released by different threads by design.  To work around
the "BUG: bad unlock balance detected!" messages, adjust
things so the dlm_recoverd thread always does both down_write
and up_write.

Signed-off-by: David Teigland

dlm: fix race between remove and lookup

2012-07-16T19:18:01+00:00

It was possible for a remove message on an old
rsb to be sent after a lookup message on a new
rsb, where the rsbs were for the same resource
name.  This could lead to a missing directory
entry for the new rsb.

It is fixed by keeping a copy of the resource
name being removed until after the remove has
been sent.  A lookup checks if this in-progress
remove matches the name it is looking up.

Signed-off-by: David Teigland