linux-stable.git/fs/cifs, branch linux-5.7.y

cifs: Fix leak when handling lease break for cached root fid

2020-08-21T11:07:23+00:00

commit baf57b56d3604880ccb3956ec6c62ea894f5de99 upstream.

Handling a lease break for the cached root didn't free the
smb2_lease_break_work allocation, resulting in a leak:

    unreferenced object 0xffff98383a5af480 (size 128):
      comm "cifsd", pid 684, jiffies 4294936606 (age 534.868s)
      hex dump (first 32 bytes):
        c0 ff ff ff 1f 00 00 00 88 f4 5a 3a 38 98 ff ff  ..........Z:8...
        88 f4 5a 3a 38 98 ff ff 80 88 d6 8a ff ff ff ff  ..Z:8...........
      backtrace:
        [<0000000068957336>] smb2_is_valid_oplock_break+0x1fa/0x8c0
        [<0000000073b70b9e>] cifs_demultiplex_thread+0x73d/0xcc0
        [<00000000905fa372>] kthread+0x11c/0x150
        [<0000000079378e4e>] ret_from_fork+0x22/0x30

Avoid this leak by only allocating when necessary.

Fixes: a93864d93977 ("cifs: add lease tracking to the cached root fid")
Signed-off-by: Paul Aurich 
CC: Stable  # v4.18+
Reviewed-by: Aurelien Aptel 
Signed-off-by: Steve French 
Signed-off-by: Greg Kroah-Hartman

smb3: warn on confusing error scenario with sec=krb5

2020-08-21T11:07:17+00:00

commit 0a018944eee913962bce8ffebbb121960d5125d9 upstream.

When mounting with Kerberos, users have been confused about the
default error returned in scenarios in which either keyutils is
not installed or the user did not properly acquire a krb5 ticket.
Log a warning message in the case that "ENOKEY" is returned
from the get_spnego_key upcall so that users can better understand
why mount failed in those two cases.

CC: Stable 
Signed-off-by: Steve French 
Signed-off-by: Greg Kroah-Hartman

Revert "cifs: Fix the target file was deleted when rename failed."

2020-07-29T08:19:55+00:00

commit 0e6705182d4e1b77248a93470d6d7b3013d59b30 upstream.

This reverts commit 9ffad9263b467efd8f8dc7ae1941a0a655a2bab2.

Upon additional testing with older servers, it was found that
the original commit introduced a regression when using the old SMB1
dialect and rsyncing over an existing file.

The patch will need to be respun to address this, likely including
a larger refactoring of the SMB1 and SMB3 rename code paths to make
it less confusing and also to address some additional rename error
cases that SMB3 may be able to workaround.

Signed-off-by: Steve French 
Reported-by: Patrick Fernie 
CC: Stable 
Acked-by: Ronnie Sahlberg 
Acked-by: Pavel Shilovsky 
Acked-by: Zhang Xiaoxu 
Signed-off-by: Greg Kroah-Hartman

cifs: prevent truncation from long to int in wait_for_free_credits

2020-07-22T07:34:00+00:00

[ Upstream commit 19e888678bac8c82206eb915eaf72741b2a2615c ]

The wait_event_... defines evaluate to long so we should not assign it an int as this may truncate
the value.

Reported-by: Marshall Midden 
Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French 
Signed-off-by: Sasha Levin

smb3: fix unneeded error message on change notify

2020-07-16T06:13:32+00:00

commit 8668115cf2db40e22e7be02652a3673d8d30c9f0 upstream.

We should not be logging a warning repeatedly on change notify.

CC: Stable  # v5.6+
Signed-off-by: Steve French 
Reviewed-by: Ronnie Sahlberg 
Signed-off-by: Greg Kroah-Hartman

smb3: fix access denied on change notify request to some servers

2020-07-16T06:13:32+00:00

commit 4ef9b4f1a76ea2370fbfe20e80fef141ab92b65e upstream.

read permission, not just read attributes permission, is required
on the directory.

See MS-SMB2 (protocol specification) section 3.3.5.19.

Signed-off-by: Steve French 
CC: Stable  # v5.6+
Reviewed-by: Pavel Shilovsky 
Signed-off-by: Greg Kroah-Hartman

cifs: fix reference leak for tlink

2020-07-16T06:13:32+00:00

commit a77592a70081edb58a95b9da18fd5a2882a25666 upstream.

Don't leak a reference to tlink during the NOTIFY ioctl

Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French 
Reviewed-by: Aurelien Aptel 
CC: Stable  # v5.6+
Signed-off-by: Greg Kroah-Hartman

cifs: update ctime and mtime during truncate

2020-07-16T06:13:15+00:00

[ Upstream commit 5618303d8516f8ac5ecfe53ee8e8bc9a40eaf066 ]

As the man description of the truncate, if the size changed,
then the st_ctime and st_mtime fields should be updated. But
in cifs, we doesn't do it.

It lead the xfstests generic/313 failed.

So, add the ATTR_MTIME|ATTR_CTIME flags on attrs when change
the file size

Reported-by: Hulk Robot 
Signed-off-by: Zhang Xiaoxu 
Signed-off-by: Steve French 
Signed-off-by: Sasha Levin

cifs: Fix the target file was deleted when rename failed.

2020-07-09T07:39:37+00:00

commit 9ffad9263b467efd8f8dc7ae1941a0a655a2bab2 upstream.

When xfstest generic/035, we found the target file was deleted
if the rename return -EACESS.

In cifs_rename2, we unlink the positive target dentry if rename
failed with EACESS or EEXIST, even if the target dentry is positived
before rename. Then the existing file was deleted.

We should just delete the target file which created during the
rename.

Reported-by: Hulk Robot 
Signed-off-by: Zhang Xiaoxu 
Cc: stable@vger.kernel.org
Signed-off-by: Steve French 
Reviewed-by: Aurelien Aptel 
Signed-off-by: Greg Kroah-Hartman

SMB3: Honor 'handletimeout' flag for multiuser mounts

2020-07-09T07:39:37+00:00

commit 6b356f6cf941d5054d7fab072cae4a5f8658e3db upstream.

Fixes: ca567eb2b3f0 ("SMB3: Allow persistent handle timeout to be configurable on mount")
Signed-off-by: Paul Aurich 
CC: Stable 
Signed-off-by: Steve French 
Reviewed-by: Aurelien Aptel 
Signed-off-by: Greg Kroah-Hartman