linux-stable.git/fs/ceph/addr.c, branch linux-3.6.y

ceph: avoid 32-bit page index overflow

2012-11-05T08:56:50+00:00

commit 6285bc231277419255f3498d3eb5ddc9f8e7fe79 upstream.

A pgoff_t is defined (by default) to have type (unsigned long).  On
architectures such as i686 that's a 32-bit type.  The ceph address
space code was attempting to produce 64 bit offsets by shifting a
page's index by PAGE_CACHE_SHIFT, but the result was not what was
desired because the shift occurred before the result got promoted
to 64 bits.

Fix this by converting all uses of page->index used in this way to
use the page_offset() macro, which ensures the 64-bit result has the
intended value.

This fixes http://tracker.newdream.net/issues/3112

Reported-by:  Mohamed Pakkeer 
Signed-off-by: Alex Elder 
Reviewed-by: Sage Weil 
Signed-off-by: Greg Kroah-Hartman

ceph: Push file_update_time() into ceph_page_mkwrite()

2012-07-30T21:02:45+00:00

CC: Sage Weil 
CC: ceph-devel@vger.kernel.org
Acked-by: Sage Weil 
Signed-off-by: Jan Kara 
Signed-off-by: Al Viro

ceph: check PG_Private flag before accessing page->private

2012-06-20T12:43:48+00:00

I got lots of NULL pointer dereference Oops when compiling kernel on ceph.
The bug is because the kernel page migration routine replaces some pages
in the page cache with new pages, these new pages' private can be non-zero.

Signed-off-by: Zheng Yan 
Signed-off-by: Sage Weil 
(cherry picked from commit 28c0254ede13ab575d2df5c6585ed3d4817c3e6b)

ceph: use i_ceph_lock instead of i_lock

2011-12-07T18:46:44+00:00

We have been using i_lock to protect all kinds of data structures in the
ceph_inode_info struct, including lists of inodes that we need to iterate
over while avoiding races with inode destruction.  That requires grabbing
a reference to the inode with the list lock protected, but igrab() now
takes i_lock to check the inode flags.

Changing the list lock ordering would be a painful process.

However, using a ceph-specific i_ceph_lock in the ceph inode instead of
i_lock is a simple mechanical change and avoids the ordering constraints
imposed by igrab().

Reported-by: Amon Ott 
Signed-off-by: Sage Weil

libceph: fix double-free of page vector

2011-10-25T23:10:17+00:00

ceph_release_page_vector() kfrees the vector; we shouldn't do it here too.

Reported-by: Jeff Wu 
Signed-off-by: Sage Weil

ceph: implement (optional) max read size

2011-10-25T23:10:15+00:00

The 'rsize' mount option limits the maximum size of an individual
read(ahead) operation that is sent off to an OSD.  This is distinct from
'rasize', which controls the size of the readahead window.

Signed-off-by: Sage Weil

ceph: make readpages fully async

2011-10-25T23:10:14+00:00

When we get a ->readpages() aop, submit async reads for all page ranges
in the provided page list.  Lock the pages immediately, so that VFS/MM
will block until the reads complete.

Signed-off-by: Sage Weil

ceph: use ihold when we already have an inode ref

2011-06-08T04:34:11+00:00

We should use ihold whenever we already have a stable inode ref, even
when we aren't holding i_lock.  This avoids adding new and unnecessary
locking dependencies.

Signed-off-by: Sage Weil

ceph: check return value for start_request in writepages

2011-05-19T18:25:05+00:00

Since we pass the nofail arg, we should never get an error; BUG if we do.
(And fix the function to not return an error if __map_request fails.)

Signed-off-by: Sage Weil

ceph: remove useless check

2011-05-19T18:25:05+00:00

rc is only ever 0 or negative in this method.

Signed-off-by: Sage Weil