linux-stable.git/fs/btrfs/root-tree.c, branch linux-3.4.y

btrfs: replace many BUG_ONs with proper error handling

2012-03-22T10:52:54+00:00

 btrfs currently handles most errors with BUG_ON. This patch is a work-in-
 progress but aims to handle most errors other than internal logic
 errors and ENOMEM more gracefully.

 This iteration prevents most crashes but can run into lockups with
 the page lock on occasion when the timing "works out."

Signed-off-by: Jeff Mahoney

btrfs: btrfs_update_root error push-up

2012-03-22T00:45:33+00:00

btrfs_update_root BUG's when it can't alloc a path, yet it can recover
from a search error. This patch returns -ENOMEM instead.

Signed-off-by: Jeff Mahoney

btrfs: Simplify btrfs_insert_root

2012-03-22T00:45:31+00:00

btrfs_insert_root is just a wrapper for btrfs_insert_item. Just return
the error directly.

Signed-off-by: Jeff Mahoney

btrfs: make btrfs_set_root_node void

2011-08-01T18:30:44+00:00

This is fairly trivial - btrfs_set_root_node() - always returns zero so we
can just make it void.  All callers ignore the return code now anyway.  I
also made sure to check that none of the functions that
btrfs_set_root_node() calls returns an error that we might have needed to
catch and pass back.

Signed-off-by: Mark Fasheh 
Signed-off-by: Chris Mason

Merge branch 'cleanups_and_fixes' into inode_numbers

2011-05-23T18:37:47+00:00

Conflicts:
	fs/btrfs/tree-log.c
	fs/btrfs/volumes.c

Signed-off-by: Chris Mason

Btrfs: return error code to caller when btrfs_del_item fails

2011-05-23T17:24:39+00:00

The error code is returned instead of calling BUG_ON when
btrfs_del_item returns the error.

Signed-off-by: Tsutomu Itoh 
Signed-off-by: Chris Mason

btrfs: remove all unused functions

2011-05-06T10:34:03+00:00

Remove static and global declarations and/or definitions. Reduces size
of btrfs.ko by ~3.4kB.

  text    data     bss     dec     hex filename
402081    7464     200  409745   64091 btrfs.ko.base
398620    7144     200  405964   631cc btrfs.ko.remove-all

Signed-off-by: David Sterba

btrfs: drop unused parameter from btrfs_release_path

2011-05-02T11:57:22+00:00

parameter tree root it's not used since commit
5f39d397dfbe140a14edecd4e73c34ce23c4f9ee ("Btrfs: Create extent_buffer
interface for large blocksizes")

Signed-off-by: David Sterba

Btrfs: Fix uninitialized root flags for subvolumes

2011-04-05T05:20:24+00:00

root_item->flags and root_item->byte_limit are not initialized when
a subvolume is created. This bug is not revealed until we added
readonly snapshot support - now you mount a btrfs filesystem and you
may find the subvolumes in it are readonly.

To work around this problem, we steal a bit from root_item->inode_item->flags,
and use it to indicate if those fields have been properly initialized.
When we read a tree root from disk, we check if the bit is set, and if
not we'll set the flag and initialize the two fields of the root item.

Reported-by: Andreas Philipp 
Signed-off-by: Li Zefan 
Tested-by: Andreas Philipp 
cc: stable@kernel.org
Signed-off-by: Chris Mason

Btrfs: cleanup some BUG_ON()

2011-03-28T09:37:35+00:00

This patch changes some BUG_ON() to the error return.
(but, most callers still use BUG_ON())

Signed-off-by: Tsutomu Itoh 
Signed-off-by: Chris Mason