linux-stable.git/fs/btrfs/dev-replace.c, branch v4.19.2

btrfs: fix error handling in btrfs_dev_replace_start

2018-11-13T19:08:56+00:00

commit 5c06147128fbbdf7a84232c5f0d808f53153defe upstream.

When we fail to start a transaction in btrfs_dev_replace_start, we leave
dev_replace->replace_start set to STARTED but clear ->srcdev and
->tgtdev.  Later, that can result in an Oops in
btrfs_dev_replace_progress when having state set to STARTED or SUSPENDED
implies that ->srcdev is valid.

Also fix error handling when the state is already STARTED or SUSPENDED
while starting.  That, too, will clear ->srcdev and ->tgtdev even though
it doesn't own them.  This should be an impossible case to hit since we
should be protected by the BTRFS_FS_EXCL_OP bit being set.  Let's add an
ASSERT there while we're at it.

Fixes: e93c89c1aaaaa (Btrfs: add new sources for device replace code)
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Jeff Mahoney 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba 
Signed-off-by: Greg Kroah-Hartman

btrfs: replace: Reset on-disk dev stats value after replace

2018-08-06T11:13:01+00:00

on-disk devs stats value is updated in btrfs_run_dev_stats(),
which is called during commit transaction, if device->dev_stats_ccnt
is not zero.

Since current replace operation does not touch dev_stats_ccnt,
on-disk dev stats value is not updated. Therefore "btrfs device stats"
may return old device's value after umount/mount
(Example: See "btrfs ins dump-t -t DEV $DEV" after btrfs/100 finish).

Fix this by just incrementing dev_stats_ccnt in
btrfs_dev_replace_finishing() when replace is succeeded and this will
update the values.

Signed-off-by: Misono Tomohiro 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: Remove fs_info from btrfs_destroy_dev_replace_tgtdev

2018-08-06T11:12:57+00:00

This function is always passed a well-formed tgtdevice so the fs_info
can be referenced from there.

Signed-off-by: Nikolay Borisov 
Reviewed-by: Lu Fengqi 
Signed-off-by: David Sterba

btrfs: Remove fs_info from btrfs_assign_next_active_device

2018-08-06T11:12:57+00:00

It can be referenced from the passed 'device' argument which is always
a well-formed device.

Signed-off-by: Nikolay Borisov 
Reviewed-by: Lu Fengqi 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: Remove fs_info from btrfs_rm_dev_replace_remove_srcdev

2018-08-06T11:12:57+00:00

It can be referenced from the passed srcdev argument.

Signed-off-by: Nikolay Borisov 
Reviewed-by: Lu Fengqi 
Signed-off-by: David Sterba

btrfs: prune unused includes

2018-08-06T11:12:43+00:00

Remove includes if none of the interfaces and exports is used in the
given source file.

Signed-off-by: David Sterba

btrfs: replace get_seconds with new 64bit time API

2018-08-06T11:12:29+00:00

The get_seconds() function is deprecated as it truncates the timestamp
to 32 bits. Change it to or ktime_get_real_seconds().

Signed-off-by: Allen Pais 
Reviewed-by: David Sterba 
[ update changelog ]
Signed-off-by: David Sterba

btrfs: drop uuid_mutex in btrfs_dev_replace_finishing

2018-05-28T16:23:16+00:00

btrfs_dev_replace_finishing updates devices (soruce and target) which
are within the btrfs_fs_devices::devices or withint the cloned seed
devices (btrfs_fs_devices::seed::devices), so we don't need the global
uuid_mutex.

The device replace context is also locked by its own locks.

Signed-off-by: Anand Jain 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba

btrfs: replace waitqueue_actvie with cond_wake_up

2018-05-28T16:23:09+00:00

Use the wrappers and reduce the amount of low-level details about the
waitqueue management.

Reviewed-by: Nikolay Borisov 
Signed-off-by: David Sterba

btrfs: Remove delayed_iput parameter of btrfs_start_delalloc_roots

2018-05-28T16:07:28+00:00

This parameter was introduced alongside the function in
eb73c1b7cea7 ("Btrfs: introduce per-subvolume delalloc inode list") to
avoid deadlocks since this function was used in the transaction commit
path. However, commit 8d875f95da43 ("btrfs: disable strict file flushes
for renames and truncates") removed that usage, rendering the parameter
obsolete.

Signed-off-by: Nikolay Borisov 
Reviewed-by: Qu Wenruo 
Signed-off-by: David Sterba