linux-stable.git/fs/btrfs/dev-replace.c, branch linux-4.5.y

btrfs: Reset IO error counters before start of device replacing

2016-05-19T01:35:18+00:00

commit 7ccefb98ce3e5c4493cd213cd03714b7149cf0cb upstream.

If device replace entry was found on disk at mounting and its num_write_errors
stats counter has non-NULL value, then replace operation will never be
finished and -EIO error will be reported by btrfs_scrub_dev() because
this counter is never reset.

 # mount -o degraded /media/a4fb5c0a-21c5-4fe7-8d0e-fdd87d5f71ee/
 # btrfs replace status /media/a4fb5c0a-21c5-4fe7-8d0e-fdd87d5f71ee/
 Started on 25.Mar 07:28:00, canceled on 25.Mar 07:28:01 at 0.0%, 40 write errs, 0 uncorr. read errs
 # btrfs replace start -B 4 /dev/sdg /media/a4fb5c0a-21c5-4fe7-8d0e-fdd87d5f71ee/
 ERROR: ioctl(DEV_REPLACE_START) failed on "/media/a4fb5c0a-21c5-4fe7-8d0e-fdd87d5f71ee/": Input/output error, no error

Reset num_write_errors and num_uncorrectable_read_errors counters in the
dev_replace structure before start of replacing.

Signed-off-by: Yauhen Kharuzhy 
Reviewed-by: David Sterba 
Signed-off-by: David Sterba 
Signed-off-by: Greg Kroah-Hartman

btrfs: cleanup, stop casting for extent_map->lookup everywhere

2016-01-15T18:22:28+00:00

Overloading extent_map->bdev to struct map_lookup * might have started out
as a means to an end, but it's a pattern that's used all over the place
now. Let's get rid of the casting and just add a union instead.

Signed-off-by: Jeff Mahoney 
Signed-off-by: David Sterba

Merge branch 'fix/waitqueue-barriers' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.4

2015-10-12T23:24:40+00:00

Merge branch 'anand/sysfs-updates-v4.3-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.4

2015-10-12T23:24:15+00:00

Signed-off-by: Chris Mason

btrfs: remove waitqueue_active check from btrfs_rm_dev_replace_unblocked

2015-10-10T16:16:38+00:00

Normally the waitqueue_active would need a barrier, but this is not
necessary here because it's not a performance sensitive context and we
can call wake_up directly.

Suggested-by: Chris Mason 
Signed-off-by: David Sterba

btrfs: switch message printers to _in_rcu variants

2015-10-08T09:07:55+00:00

Signed-off-by: David Sterba

Btrfs: move kobj stuff out of dev_replace lock range

2015-10-01T16:07:59+00:00

To avoid deadlock described in commit 084b6e7c7607 ("btrfs: Fix a
lockdep warning when running xfstest."), we should move kobj stuff out
of dev_replace lock range.

  "It is because the btrfs_kobj_{add/rm}_device() will call memory
  allocation with GFP_KERNEL,
  which may flush fs page cache to free space, waiting for it self to do
  the commit, causing the deadlock.

  To solve the problem, move btrfs_kobj_{add/rm}_device() out of the
  dev_replace lock range, also involing split the
  btrfs_rm_dev_replace_srcdev() function into remove and free parts.

  Now only btrfs_rm_dev_replace_remove_srcdev() is called in dev_replace
  lock range, and kobj_{add/rm} and btrfs_rm_dev_replace_free_srcdev() are
  called out of the lock range."

Signed-off-by: Liu Bo 
Signed-off-by: Anand Jain 
[added lockup description]
Signed-off-by: David Sterba

Btrfs: kernel operation should come after user input has been verified

2015-10-01T15:45:10+00:00

By general rule of thumb there shouldn't be any way that user land
could trigger a kernel operation just by sending wrong arguments.

Here do commit cleanups after user input has been verified.

Signed-off-by: Anand Jain 
Signed-off-by: David Sterba

Btrfs: rename btrfs_kobj_rm_device to btrfs_sysfs_rm_device_link

2015-09-29T14:29:59+00:00

Signed-off-by: Anand Jain 
Signed-off-by: David Sterba

Btrfs: rename btrfs_kobj_add_device to btrfs_sysfs_add_device_link

2015-09-29T14:29:59+00:00

Signed-off-by: Anand Jain 
Signed-off-by: David Sterba