linux-stable.git/fs/btrfs/backref.c, branch linux-3.13.y

btrfs: Use WARN_ON()'s return value in place of WARN_ON(1)

2013-11-12T03:11:53+00:00

Use WARN_ON()'s return value in place of WARN_ON(1) for cleaner source
code that outputs a more descriptive warnings. Also fix the styling
warning of redundant braces that came up as a result of this fix.

Signed-off-by: Dulshani Gunawardhana 
Reviewed-by: Zach Brown 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: fix a crash when running balance and defrag concurrently

2013-11-12T03:11:07+00:00

Running balance and defrag concurrently can end up with a crash:

kernel BUG at fs/btrfs/relocation.c:4528!
RIP: 0010:[]  [] btrfs_reloc_cow_block+ 0x1eb/0x230 [btrfs]
Call Trace:
  [] ? update_ref_for_cow+0x241/0x380 [btrfs]
  [] ? copy_extent_buffer+0xad/0x110 [btrfs]
  [] __btrfs_cow_block+0x3a1/0x520 [btrfs]
  [] btrfs_cow_block+0x116/0x1b0 [btrfs]
  [] btrfs_search_slot+0x43d/0x970 [btrfs]
  [] btrfs_lookup_file_extent+0x37/0x40 [btrfs]
  [] __btrfs_drop_extents+0x11e/0xae0 [btrfs]
  [] ? generic_bin_search.constprop.39+0x8d/0x1a0 [btrfs]
  [] ? kmem_cache_alloc+0x1da/0x200
  [] ? btrfs_alloc_path+0x1a/0x20 [btrfs]
  [] btrfs_drop_extents+0x60/0x90 [btrfs]
  [] relink_extent_backref+0x2ed/0x780 [btrfs]
  [] ? btrfs_submit_bio_hook+0x1e0/0x1e0 [btrfs]
  [] ? iterate_inodes_from_logical+0x87/0xa0 [btrfs]
  [] btrfs_finish_ordered_io+0x229/0xac0 [btrfs]
  [] finish_ordered_fn+0x15/0x20 [btrfs]
  [] worker_loop+0x125/0x4e0 [btrfs]
  [] ? btrfs_queue_worker+0x300/0x300 [btrfs]
  [] kthread+0xc0/0xd0
  [] ? insert_kthread_work+0x40/0x40
  [] ret_from_fork+0x7c/0xb0
  [] ? insert_kthread_work+0x40/0x40
----------------------------------------------------------------------

It turns out to be that balance operation will bump root's @last_snapshot,
which enables snapshot-aware defrag path, and backref walking stuff will
find data reloc tree as refs' parent, and hit the BUG_ON() during COW.

As data reloc tree's data is just for relocation purpose, and will be deleted right
after relocation is done, it's unnecessary to walk those refs belonged to data reloc
tree, it'd be better to skip them.

Signed-off-by: Liu Bo 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

btrfs: drop unused parameter from btrfs_item_nr

2013-11-12T02:50:48+00:00

Remove unused eb parameter from btrfs_item_nr

Signed-off-by: Ross Kirk 
Reviewed-by: David Sterba 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: allocate prelim_ref with a slab allocater

2013-09-01T12:16:27+00:00

struct __prelim_ref is allocated and freed frequently when
walking backref tree, using slab allocater can not only
speed up allocating but also detect memory leaks.

Signed-off-by: Wang Shilong 
Reviewed-by: Miao Xie 
Reviewed-by: Jan Schmidt 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: pass gfp_t to __add_prelim_ref() to avoid always using GFP_ATOMIC

2013-09-01T12:16:26+00:00

Currently, only add_delayed_refs have to allocate with GFP_ATOMIC,
So just pass arg 'gfp_t' to decide which allocation mode.

Signed-off-by: Wang Shilong 
Reviewed-by: Miao Xie 
Reviewed-by: Jan Schmidt 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: Remove superfluous casts from u64 to unsigned long long

2013-09-01T12:16:08+00:00

u64 is "unsigned long long" on all architectures now, so there's no need to
cast it when formatting it using the "ll" length modifier.

Signed-off-by: Geert Uytterhoeven 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: get rid of sparse warnings

2013-09-01T12:15:50+00:00

make C=2 fs/btrfs/ CF=-D__CHECK_ENDIAN__

I tried to filter out the warnings for which patches have already
been sent to the mailing list, pending for inclusion in btrfs-next.

All these changes should be obviously safe.

Signed-off-by: Stefan Behrens 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: fix possible memory leak in find_parent_nodes()

2013-09-01T12:04:56+00:00

Signed-off-by: Wang Shilong 
Reviewed-by: Miao Xie 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: add missing error check to find_parent_nodes

2013-09-01T12:04:44+00:00

Signed-off-by: Filipe David Borba Manana 
Reviewed-by: Jan Schmidt 
Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason

Btrfs: make sure the backref walker catches all refs to our extent

2013-08-09T23:30:03+00:00

Because we don't mess with the offset into the extent for compressed we will
properly find both extents for this case

[extent a][extent b][rest of extent a]

but because we already added a ref for the front half we won't add the inode
information for the second half.  This causes us to leak that memory and not
print out the other offset when we do logical-resolve.  So fix this by calling
ulist_add_merge and then add our eie to the existing entry if there is one.
With this patch we get both offsets out of logical-resolve.  With this and the
other 2 patches I've sent we now pass btrfs/276 on my vm with compress-force=lzo
set.  Thanks,

Signed-off-by: Josef Bacik 
Signed-off-by: Chris Mason