linux-stable.git/fs/befs/linuxvfs.c, branch linux-4.9.y

Merge tag 'befs-v4.9-rc1' of git://github.com/luisbg/linux-befs

2016-10-15T19:09:13+00:00

Pull befs fixes from Luis de Bethencourt:
 "I recently took maintainership of the befs file system [0]. This is
  the first time I send you a git pull request, so please let me know if
  all the below is OK.

  Salah Triki and myself have been cleaning the code and fixing a few
  small bugs.

  Sorry I couldn't send this sooner in the merge window, I was waiting
  to have my GPG key signed by kernel members at ELCE in Berlin a few
  days ago."

[0] https://lkml.org/lkml/2016/7/27/502

* tag 'befs-v4.9-rc1' of git://github.com/luisbg/linux-befs: (39 commits)
  befs: befs: fix style issues in datastream.c
  befs: improve documentation in datastream.c
  befs: fix typos in datastream.c
  befs: fix typos in btree.c
  befs: fix style issues in super.c
  befs: fix comment style
  befs: add check for ag_shift in superblock
  befs: dump inode_size superblock information
  befs: remove unnecessary initialization
  befs: fix typo in befs_sb_info
  befs: add flags field to validate superblock state
  befs: fix typo in befs_find_key
  befs: remove unused BEFS_BT_PARMATCH
  fs: befs: remove ret variable
  fs: befs: remove in vain variable assignment
  fs: befs: remove unnecessary *befs_sb variable
  fs: befs: remove useless initialization to zero
  fs: befs: remove in vain variable assignment
  fs: befs: Insert NULL inode to dentry
  fs: befs: Remove useless calls to brelse in befs_find_brun_dblindirect
  ...

fs: befs: remove ret variable

2016-10-08T09:01:25+00:00

ret is initialized to -EIO and is never modified, so remove ret and use
-EIO directly.

Signed-off-by: Salah Triki 
Acked-by: Luis de Bethencourt

fs: befs: remove in vain variable assignment

2016-10-08T09:01:24+00:00

There is no need to init res, since it will be overwitten later by
befs_fblock2brun().

Signed-off-by: Salah Triki 
Acked-by: Luis de Bethencourt

fs: befs: Insert NULL inode to dentry

2016-10-08T09:01:21+00:00

As VFS expects, lookup inserts NULL inode to dentry when the named inode
does not exist.

Signed-off-by: Salah Triki 
Acked-by: Luis de Bethencourt

befs: make consistent use of befs_error()

2016-10-08T09:01:16+00:00

befs_error() is used in potential errors that could happen in befs to
provide informational log messages. befs_debug() is silent when
CONFIG_BEFS_DEBUG=no, and very verbose when switched on, which is why it is
used for general debugging but not for errors.

Fix a few cases where the befs debug utility usage isn't following the
expected pattern. To make sure we have consistent information in the logs.

Signed-off-by: Luis de Bethencourt

befs: use simpler while loop

2016-10-08T09:01:16+00:00

Replace goto with simpler while loop to make befs_readdir() more readable.

Signed-off-by: Luis de Bethencourt

befs: remove constant variable

2016-10-08T09:01:15+00:00

Use macro directly instead of via assigning it to an unchanging variable.

Signed-off-by: Luis de Bethencourt 
Acked-by: Salah Triki

befs: avoid dereferencing dentry twice

2016-10-08T09:01:15+00:00

No need to dereference dentry twice to get the name when we already have
it stored in a local variable.

Signed-off-by: Luis de Bethencourt

fs: befs: remove comment that confuses kernel-doc

2016-10-08T09:01:14+00:00

This comment with a mysterious unfinished line confuses the kernel-doc
system since, because it starts with /**, it thinks it is documenting a
function.

Signed-off-by: Luis de Bethencourt

fs: befs: check silent flag before logging error

2016-10-08T09:01:13+00:00

Log error only when silent flag is not set.

Fixes: dbe6460388bc ("fs/befs/linuxvfs.c: check silent flag before logging errors")
Signed-off-by: Luis de Bethencourt 
Acked-by: Salah Triki