linux-stable.git/fs/bcachefs, branch v6.9

bcachefs: Add missing sched_annotate_sleep() in bch2_journal_flush_seq_async()

2024-05-07T15:02:37+00:00

Signed-off-by: Kent Overstreet

bcachefs: Fix race in bch2_write_super()

2024-05-07T15:02:36+00:00

bch2_write_super() was looping over online devices multiple times -
dropping and retaking io_ref each time.

This meant it could race with device removal; it could increment the
sequence number on a device but fail to write it - and then if the
device was re-added, it would get confused the next time around thinking
a superblock write was silently dropped.

Fix this by taking io_ref once, and stashing pointers to online devices
in a darray.

Signed-off-by: Kent Overstreet

bcachefs: BCH_SB_LAYOUT_SIZE_BITS_MAX

2024-05-06T14:58:17+00:00

Define a constant for the max superblock size, to avoid a too-large
shift.

Reported-by: syzbot+a8b0fb419355c91dda7f@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet

bcachefs: Add missing skcipher_request_set_callback() call

2024-05-06T14:58:17+00:00

Signed-off-by: Kent Overstreet

bcachefs: Fix snapshot_t() usage in bch2_fs_quota_read_inode()

2024-05-06T14:58:17+00:00

bch2_fs_quota_read_inode() wasn't entirely updated to the
bch2_snapshot_tree() helper, which takes rcu lock.

Reported-by: syzbot+a3a9a61224ed3b7f0010@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet

bcachefs: Fix shift-by-64 in bformat_needs_redo()

2024-05-06T14:58:17+00:00

Ancient versions of bcachefs produced packed formats that could
represent keys that our in memory format cannot represent;
bformat_needs_redo() has some tricky shifts to check for this sort of
overflow.

Reported-by: syzbot+594427aebfefeebe91c6@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet

bcachefs: Guard against unknown k.k->type in __bkey_invalid()

2024-05-06T14:58:17+00:00

For forwards compatibility we have to allow unknown key types, and only
run the checks that make sense against them.

Fix a missing guard on k.k->type being known.

Reported-by: syzbot+ae4dc916da3ce51f284f@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet

bcachefs: Add missing validation for superblock section clean

2024-05-06T14:58:17+00:00

We were forgetting to check for jset entries that overrun the end of the
section - both in validate and to_text(); to_text() needs to be safe for
types that fail to validate.

Reported-by: syzbot+c48865e11e7e893ec4ab@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet

bcachefs: Fix assert in bch2_alloc_v4_invalid()

2024-05-06T14:58:17+00:00

Reported-by: syzbot+10827fa6b176e1acf1d0@syzkaller.appspotmail.com
Signed-off-by: Kent Overstreet

bcachefs: fix overflow in fiemap

2024-05-06T14:58:17+00:00

filefrag (and potentially other utilities that call fiemap) sometimes
pass ULONG_MAX as the length.  fiemap_prep clamps excessively large
lengths - but the calculation of end can overflow if it occurs before
calling fiemap_prep.  When this happens, filefrag assumes it has read to
the end and exits.

Signed-off-by: Reed Riley 
Signed-off-by: Kent Overstreet