linux-stable.git/fs/bcachefs, branch linux-6.8.y

mean_and_variance: Drop always failing tests

2024-04-10T14:38:08+00:00

[ Upstream commit 97ca7c1f93bbac6982717a7055cd727813c45e61 ]

mean_and_variance_test_2 and mean_and_variance_test_4 always fail.
The input parameters to those tests are identical to the input parameters
to tests 1 and 3, yet the expected result for tests 2 and 4 is different
for the mean and stddev tests. That will always fail.

     Expected mean_and_variance_get_mean(mv) == mean[i], but
        mean_and_variance_get_mean(mv) == 22 (0x16)
        mean[i] == 10 (0xa)

Drop the bad tests.

Fixes: 65bc41090720 ("mean and variance: More tests")
Closes: https://lore.kernel.org/lkml/065b94eb-6a24-4248-b7d7-d3212efb4787@roeck-us.net/
Cc: Kent Overstreet 
Signed-off-by: Guenter Roeck 
Signed-off-by: Kent Overstreet 
Signed-off-by: Sasha Levin

bcachefs: fix bch2_save_backtrace()

2024-02-25T20:45:36+00:00

Missed a call in the previous fix.

Signed-off-by: Kent Overstreet

bcachefs: Fix check_snapshot() memcpy

2024-02-25T01:47:47+00:00

check_snapshot() copies the bch_snapshot to a temporary to easily handle
older versions that don't have all the fields of the current version,
but it lacked a min() to correctly handle keys newer and larger than the
current version.

Signed-off-by: Kent Overstreet

bcachefs: Fix bch2_journal_flush_device_pins()

2024-02-25T01:46:48+00:00

If a journal write errored, the list of devices it was written to could
be empty - we're not supposed to mark an empty replicas list.

Signed-off-by: Kent Overstreet

bcachefs: fix iov_iter count underflow on sub-block dio read

2024-02-25T01:45:24+00:00

bch2_direct_IO_read() checks the request offset and size for sector
alignment and then falls through to a couple calculations to shrink
the size of the request based on the inode size. The problem is that
these checks round up to the fs block size, which runs the risk of
underflowing iter->count if the block size happens to be large
enough. This is triggered by fstest generic/361 with a 4k block
size, which subsequently leads to a crash. To avoid this crash,
check that the shorten length doesn't exceed the overall length of
the iter.

Fixes:
Signed-off-by: Brian Foster 
Reviewed-by: Su Yue 
Signed-off-by: Kent Overstreet

bcachefs: Fix BTREE_ITER_FILTER_SNAPSHOTS on inodes btree

2024-02-25T01:41:46+00:00

If we're in FILTER_SNAPSHOTS mode and we start scanning a range of the
keyspace where no keys are visible in the current snapshot, we have a
problem - we'll scan for a very long time before scanning terminates.

Awhile back, this was fixed for most cases with peek_upto() (and
assertions that enforce that it's being used).

But the fix missed the fact that the inodes btree is different - every
key offset is in a different snapshot tree, not just the inode field.

Fixes:
Signed-off-by: Kent Overstreet

bcachefs: Kill __GFP_NOFAIL in buffered read path

2024-02-25T01:41:42+00:00

Recently, we fixed our __GFP_NOFAIL usage in the readahead path, but the
easy one in read_single_folio() (where wa can return an error) was
missed - oops.

Fixes:
Signed-off-by: Kent Overstreet

bcachefs: fix backpointer_to_text() when dev does not exist

2024-02-25T01:41:37+00:00

Fixes:
Signed-off-by: Kent Overstreet

bcachefs: Fix missing va_end()

2024-02-14T02:59:27+00:00

Fixes: https://lore.kernel.org/linux-bcachefs/202402131603.E953E2CF@keescook/T/#u
Reported-by: coverity scan
Signed-off-by: Kent Overstreet

bcachefs: Fix check_version_upgrade()

2024-02-14T02:58:37+00:00

When also downgrading, check_version_upgrade() could pick a new version
greater than the latest supported version.

Fixes:
Signed-off-by: Kent Overstreet