linux-stable.git/drivers/watchdog, branch v3.10

drivers/watchdog: don't check resource with devm_ioremap_resource

2013-05-18T09:58:04+00:00

devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.

Signed-off-by: Wolfram Sang

watchdog: Fix race condition in registration code

2013-05-09T06:13:41+00:00

A race condition exists when registering the first watchdog device.
Sequence of events:

- watchdog_register_device calls watchdog_dev_register
- watchdog_dev_register creates the watchdog misc device by calling
  misc_register.
  At that time, the matching character device (/dev/watchdog0) does not yet
  exist, and old_wdd is not set either.
- Userspace gets an event and opens /dev/watchdog
- watchdog_open is called and sets wdd = old_wdd, which is still NULL,
  and tries to dereference it. This causes the kernel to panic.

Seen with systemd trying to open /dev/watchdog immediately after
it was created.

Reported-by: Arkadiusz Miskiewicz 
Signed-off-by: Guenter Roeck 
Tested-by: Arkadiusz Miskiewicz 
Signed-off-by: Wim Van Sebroeck

watchdog: Convert to devm_ioremap_resource()

2013-05-09T06:12:00+00:00

Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error handling.

devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Sachin Kamat 
Reviewed-by: Thierry Reding 
Cc: Gabor Juhos 
Cc: Paul Mundt 
Signed-off-by: Wim Van Sebroeck

watchdog: Revert the AT91RM9200_WATCHDOG dependency

2013-04-14T07:09:10+00:00

Compiling the at91rm9200_wdt.c driver without at91rm9200
support was leading to several errors:

drivers/built-in.o: In function `at91_wdt_close':
at91_adc.c:(.text+0xc9fe4): undefined reference to `at91_st_base'
drivers/built-in.o: In function `at91_wdt_write':
at91_adc.c:(.text+0xca004): undefined reference to `at91_st_base'
drivers/built-in.o: In function `at91wdt_shutdown':
at91_adc.c:(.text+0xca01c): undefined reference to `at91_st_base'
drivers/built-in.o: In function `at91wdt_suspend':
at91_adc.c:(.text+0xca038): undefined reference to `at91_st_base'
drivers/built-in.o: In function `at91_wdt_open':
at91_adc.c:(.text+0xca0cc): undefined reference to `at91_st_base'
drivers/built-in.o:at91_adc.c:(.text+0xca2c8): more undefined references to
`at91_st_base' follow

So, reverting the modification of the "depends" Kconfig line
introduced by patch a6a1bcd37 (watchdog: at91rm9200: add DT support)
seems to be the good solution.

Signed-off-by: Nicolas Ferre 
Acked-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: sp5100_tco: Set the AcpiMmioSel bitmask value to 1 instead of 2

2013-03-22T22:21:55+00:00

The AcpiMmioSel bit is bit 1 in the AcpiMmioEn register, but the current
sp5100_tco driver is using bit 2.

See 2.3.3 Power Management (PM) Registers page 150 of the
AMD SB800-Series Southbridges Register Reference Guide [1].

        AcpiMmioEn - RW – 8/16/32 bits - [PM_Reg: 24h]
        Field Name        Bits  Default  Description
        AcpiMMioDecodeEn  0     0b       Set to 1 to enable AcpiMMio space.
        AcpiMMIoSel       1     0b       Set AcpiMMio registers to be memory-mapped or IO-mapped space.
                                         0: Memory-mapped space
                                         1: I/O-mapped space

The sp5100_tco driver expects zero as a value of AcpiMmioSel (bit 1).

Fortunately, no problems were caused by this typo, because the default
value of the undocumented misused bit 2 seems to be zero.

However, the sp5100_tco driver should use the correct bitmask value.

[1] http://support.amd.com/us/Embedded_TechDocs/45482.pdf

Signed-off-by: Takahisa Tanaka 
Signed-off-by: Paul Menzel 
Signed-off-by: Wim Van Sebroeck 
Cc: stable

watchdog: sp5100_tco: Remove code that may cause a boot failure

2013-03-22T22:21:47+00:00

A problem was found on PC's with the SB700 chipset: The PC fails to
load BIOS after running the 3.8.x kernel until the power is completely
cut off. It occurs in all 3.8.x versions and the mainline version as of
2/4. The issue does not occur with the 3.7.x builds.

There are two methods for accessing the watchdog registers.

 1. Re-programming a resource address obtained by allocate_resource()
to chipset.
 2. Use the direct memory-mapped IO access.

The method 1 can be used by all the chipsets (SP5100, SB7x0, SB8x0 or
later). However, experience shows that only PC with the SB8x0 (or
later) chipsets can use the method 2.

This patch removes the method 1, because the critical problem was found.
That's why the watchdog timer was able to be used on SP5100 and SB7x0
chipsets until now.

Link: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1116835
Link: https://lkml.org/lkml/2013/2/14/271

Signed-off-by: Takahisa Tanaka 
Signed-off-by: Wim Van Sebroeck 
Cc: stable

watchdog: sp805_wdt depends on ARM

2013-03-01T11:56:26+00:00

The SP805 driver is only used by the Spear machines, and uses
writel_relaxed, which is not available on all architectures.

The dependency from CONFIG_ARM avoids compilation problems under
randomconfig when CONFIG_ARM_AMBA is enabled for x86 builds.

Signed-off-by: Alessandro Rubini 
Acked-by: Giancarlo Asnaghi 
Signed-off-by: Davide Ciminaghi 
Acked-by: Linus Walleij 
Acked-by: Viresh Kumar 
Signed-off-by: H. Peter Anvin 
Signed-off-by: Wim Van Sebroeck

watchdog: davinci_wdt: update to devm_* API

2013-03-01T11:56:18+00:00

Update the code to use devm_* API so that driver
core will manage resources.

Signed-off-by: Kumar, Anil 
Signed-off-by: Wim Van Sebroeck

watchdog: davinci_wdt: use devm managed clk get

2013-03-01T11:56:14+00:00

Get the clock using devm_clk_get().

Signed-off-by: Mrugesh Katepallewar 
Signed-off-by: Wim Van Sebroeck

watchdog: at91rm9200: add DT support

2013-03-01T11:55:27+00:00

Add DT support for at91rm9200_wdt.

Signed-off-by: Joachim Eastwood 
Signed-off-by: Wim Van Sebroeck