linux-stable.git/drivers/watchdog, branch linux-3.13.y

sc1200_wdt: Fix oops

2013-12-10T07:48:15+00:00

If loaded with isapnp = 0 the driver explodes. This is catching
people out now and then. What should happen in the working case is
a complete mystery and the code appears terminally confused, but we
can at least make the error path work properly.

Signed-off-by: Alan Cox 
Reviewed-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck 
Partially-Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=53991

watchdog: Drop unnecessary include of miscdevice.h

2013-12-10T07:48:09+00:00

After commit 487722cf2 (watchdog: Get rid of MODULE_ALIAS_MISCDEV
statements) the affected drivers no longer need to include miscdevice.h.
Only exception is rt2880_wdt.c which never needed it.

Signed-off-by: Guenter Roeck 
Reviewed-by: Jean Delvare 
Signed-off-by: Wim Van Sebroeck

watchdog: w83627hf: Use helper functions to access superio registers

2013-11-18T20:34:19+00:00

Use helper functions named similar to other drivers to access
superio registers.

Request memory region only when needed, and use request_muxed_region().
This lets other devices (hwmon, gpio) use the same region.

Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: w83627hf: Enable watchdog device only if not already enabled

2013-11-18T20:34:13+00:00

There is no need to enable the watchdog device if it is already enabled.
Also, when enabling the watchdog device, only set the watchdog device
enable bit and do not touch other bits; depending on the chip type,
those bits may enable other functionality.

Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: w83627hf: Enable watchdog only once

2013-11-18T20:34:08+00:00

It is unnecessary to enable the logical device and WDT0 each time
the watchdog is accessed. Do it only once during initialization.

Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: w83627hf: Convert to watchdog infrastructure

2013-11-18T20:34:01+00:00

Signed-off-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: omap_wdt: raw read and write endian fix

2013-11-17T18:42:38+00:00

All OMAP IP blocks expect LE data, but CPU may operate in BE mode.
Need to use endian neutral functions to read/write h/w registers.
I.e instead of __raw_read[lw] and __raw_write[lw] functions code
need to use read[lw]_relaxed and write[lw]_relaxed functions.
If the first simply reads/writes register, the second will byteswap
it if host operates in BE mode.

Changes are trivial sed like replacement of __raw_xxx functions
with xxx_relaxed variant.

Signed-off-by: Victor Kamensky 
Signed-off-by: Taras Kondratiuk 
Acked-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: sirf: don't depend on dummy value of CLOCK_TICK_RATE

2013-11-17T18:42:31+00:00

As CSR SiRF is converted to multi platform CLOCK_TICK_RATE is a dummy
value that seems to match the right value is used.
(arch/arm/mach-prima2/include/mach/timex.h which defined CLOCK_TICK_RATE
to 1000000 was removed in commit cf82e0e (ARM: sirf: enable
multiplatform support); marco used the same file.)

To not depend on that dummy value use a local #define instead.

Signed-off-by: Uwe Kleine-König 
Signed-off-by: Wim Van Sebroeck

watchdog: pcwd_usb: overflow in usb_pcwd_send_command()

2013-11-17T18:42:18+00:00

We changed "buf" from being an array of 6 chars to being a pointer this
sizeof(buf) needs to be updated as well.

Fixes: 2ddb8089a7e5 ('watchdog: pcwd_usb: Use allocated buffer for usb_control_msg')
Signed-off-by: Dan Carpenter 
Reviewed-by: Guenter Roeck 
Signed-off-by: Wim Van Sebroeck

watchdog: rt2880_wdt: fix return value check in rt288x_wdt_probe()

2013-11-17T18:38:44+00:00

In case of error, the function devm_request_and_ioremap() returns NULL
pointer not ERR_PTR(). Fix it by using devm_ioremap_resource() instead
of devm_request_and_ioremap().

Signed-off-by: Wei Yongjun 
Signed-off-by: Wim Van Sebroeck